v3: Make ApiUrlBuilder have class method, not instance method

There was no need to have multiple instances of this class, so change
its single method to a class method.

Authored-by: Reid Mitchell <rmitchell@pivotal.io>

Author: reidmit

app/controllers/runtime/root_controller.rb

@@ -7,7 +7,7 @@ class RootController < RestController::BaseController
     get '/', :read
 
     def read
-      api_url_builder = VCAP::CloudController::Presenters::ApiUrlBuilder.new
+      api_url_builder = VCAP::CloudController::Presenters::ApiUrlBuilder
 
       response = {
         links: {

app/controllers/v3/application_controller.rb

@@ -89,7 +89,7 @@ def user_audit_info
   end
 
   def url_builder
-    @url_builder ||= VCAP::CloudController::Presenters::ApiUrlBuilder.new
+    @url_builder ||= VCAP::CloudController::Presenters::ApiUrlBuilder
   end
 
   def request_id

app/controllers/v3/space_manifests_controller.rb

@@ -37,7 +37,7 @@ def apply_manifest
     app_guid_message_hash.each { |app_guid, message| record_apply_manifest_audit_event(AppModel.find(guid: app_guid), message, space) }
     job = Jobs::Enqueuer.new(apply_manifest_job, queue: Jobs::Queues.generic).enqueue_pollable
 
-    url_builder = Presenters::ApiUrlBuilder.new
+    url_builder = Presenters::ApiUrlBuilder
     head HTTP::ACCEPTED, 'Location' => url_builder.build_url(path: "/v3/jobs/#{job.guid}")
   end
 

app/presenters/api_url_builder.rb

@@ -1,6 +1,6 @@
 module VCAP::CloudController::Presenters
   class ApiUrlBuilder
-    def build_url(path: nil, query: nil)
+    def self.build_url(path: nil, query: nil)
       my_uri = URI::HTTP.build(host: VCAP::CloudController::Config.config.get(:external_domain), path: path, query: query)
       my_uri.scheme = VCAP::CloudController::Config.config.get(:external_protocol)
       my_uri.to_s

app/presenters/v3/base_presenter.rb

@@ -22,7 +22,7 @@ def redact_hash(unredacted_value)
         end
 
         def url_builder
-          @url_builder ||= VCAP::CloudController::Presenters::ApiUrlBuilder.new
+          @url_builder ||= VCAP::CloudController::Presenters::ApiUrlBuilder
         end
       end
     end

spec/unit/presenters/api_url_builder_spec.rb

@@ -7,24 +7,18 @@ module VCAP::CloudController::Presenters
     let(:host) { TestConfig.config[:external_domain] }
 
     it 'builds a url when path is provided' do
-      builder = ApiUrlBuilder.new
-
       expected_url = "#{scheme}://#{host}/v3/foo/bar"
-      expect(builder.build_url(path: '/v3/foo/bar')).to eq expected_url
+      expect(ApiUrlBuilder.build_url(path: '/v3/foo/bar')).to eq expected_url
     end
 
     it 'can build urls with query string' do
-      builder = ApiUrlBuilder.new
-
       expected_url = "#{scheme}://#{host}/v3/foo/bar?baz=quux"
-      expect(builder.build_url(path: '/v3/foo/bar', query: 'baz=quux')).to eq expected_url
+      expect(ApiUrlBuilder.build_url(path: '/v3/foo/bar', query: 'baz=quux')).to eq expected_url
     end
 
     it 'builds a url without a trailing slash when path is NOT provided' do
-      builder = ApiUrlBuilder.new
-
       expected_url = "#{scheme}://#{host}"
-      expect(builder.build_url).to eq expected_url
+      expect(ApiUrlBuilder.build_url).to eq expected_url
     end
   end
 end

spec/unit/presenters/v3/to_many_relationship_presenter_spec.rb

@@ -28,7 +28,7 @@ def generate_relationships(count)
     let(:relation_url) { 'cash/guid' }
     let(:relationship_path) { 'money' }
     subject(:relationship_presenter) { ToManyRelationshipPresenter.new(relation_url, data, relationship_path, build_related: build_related) }
-    let(:url_builder) { VCAP::CloudController::Presenters::ApiUrlBuilder.new }
+    let(:url_builder) { VCAP::CloudController::Presenters::ApiUrlBuilder }
 
     describe '#to_hash' do
       let(:result) { relationship_presenter.to_hash }