Renamed ServiceCredentialBindingCreate to ServiceCredentialBindingAppCreate

Author: FelisiaM

…ons/service_credential_binding_create.rb …service_credential_binding_app_create.rbapp/actions/service_credential_binding_create.rb renamed to app/actions/service_credential_binding_app_create.rb app/actions/service_credential_binding_create.rb renamed to app/actions/service_credential_binding_app_create.rb

@@ -4,7 +4,7 @@
 
 module VCAP::CloudController
   module V3
-    class ServiceCredentialBindingCreate < V3::ServiceBindingCreate
+    class ServiceCredentialBindingAppCreate < V3::ServiceBindingCreate
       class UnprocessableCreate < StandardError
       end
 

app/controllers/v3/service_credential_bindings_controller.rb

@@ -1,4 +1,4 @@
-require 'actions/service_credential_binding_create'
+require 'actions/service_credential_binding_app_create'
 require 'actions/service_credential_binding_key_create'
 require 'actions/service_credential_binding_delete'
 require 'fetchers/service_credential_binding_fetcher'
@@ -56,7 +56,7 @@ def create
 
       unauthorized! unless can_write_to_space?(app.space)
 
-      action = V3::ServiceCredentialBindingCreate.new(user_audit_info, message.audit_hash)
+      action = V3::ServiceCredentialBindingAppCreate.new(user_audit_info, message.audit_hash)
       binding = action.precursor(service_instance, app: app, name: message.name, volume_mount_services_enabled: volume_services_enabled?)
 
       case service_instance
@@ -78,7 +78,7 @@ def create
       head :not_implemented
       return
     end
-  rescue V3::ServiceCredentialBindingCreate::UnprocessableCreate,
+  rescue V3::ServiceCredentialBindingAppCreate::UnprocessableCreate,
          V3::ServiceCredentialBindingKeyCreate::UnprocessableCreate => e
     unprocessable!(e.message)
   end

app/jobs/v3/create_binding_async_job.rb

@@ -1,6 +1,6 @@
 require 'jobs/reoccurring_job'
 require 'actions/service_route_binding_create'
-require 'actions/service_credential_binding_create'
+require 'actions/service_credential_binding_app_create'
 require 'cloud_controller/errors/api_error'
 require 'jobs/v3/create_service_binding_job_factory'
 

app/jobs/v3/create_service_binding_job_factory.rb

@@ -23,7 +23,7 @@ def self.action(type, user_audit_info, audit_hash)
         when :route
           V3::ServiceRouteBindingCreate.new(user_audit_info, audit_hash)
         when :credential
-          V3::ServiceCredentialBindingCreate.new(user_audit_info, audit_hash)
+          V3::ServiceCredentialBindingAppCreate.new(user_audit_info, audit_hash)
         else
           raise InvalidType
         end

app/jobs/v3/create_service_credential_binding_job_actor.rb

@@ -1,5 +1,5 @@
 require 'jobs/reoccurring_job'
-require 'actions/service_credential_binding_create'
+require 'actions/service_credential_binding_app_create'
 require 'cloud_controller/errors/api_error'
 
 module VCAP::CloudController

app/jobs/v3/delete_service_credential_binding_job_actor.rb

@@ -1,5 +1,5 @@
 require 'jobs/reoccurring_job'
-require 'actions/service_credential_binding_create'
+require 'actions/service_credential_binding_app_create'
 require 'cloud_controller/errors/api_error'
 
 module VCAP::CloudController

…ervice_credential_binding_create_spec.rb …ce_credential_binding_app_create_spec.rbspec/unit/actions/service_credential_binding_create_spec.rb renamed to spec/unit/actions/service_credential_binding_app_create_spec.rb spec/unit/actions/service_credential_binding_create_spec.rb renamed to spec/unit/actions/service_credential_binding_app_create_spec.rb

@@ -1,12 +1,12 @@
 require 'spec_helper'
-require 'actions/service_credential_binding_create'
+require 'actions/service_credential_binding_app_create'
 require 'support/shared_examples/v3_service_binding_create'
 require 'cloud_controller/user_audit_info'
 require 'repositories/service_generic_binding_event_repository'
 
 module VCAP::CloudController
   module V3
-    RSpec.describe ServiceCredentialBindingCreate do
+    RSpec.describe ServiceCredentialBindingAppCreate do
       subject(:action) { described_class.new(user_audit_info, audit_hash) }
 
       let(:audit_hash) { { some_info: 'some_value' } }
@@ -40,15 +40,15 @@ module V3
 
           it 'raises an error when no app is specified' do
             expect { action.precursor(service_instance) }.to raise_error(
-              ServiceCredentialBindingCreate::UnprocessableCreate,
+              ServiceCredentialBindingAppCreate::UnprocessableCreate,
               'No app was specified'
             )
           end
 
           it 'raises an error when a binding already exists' do
             ServiceBinding.make(service_instance: service_instance, app: app)
             expect { action.precursor(service_instance, app: app, name: details[:name]) }.to raise_error(
-              ServiceCredentialBindingCreate::UnprocessableCreate,
+              ServiceCredentialBindingAppCreate::UnprocessableCreate,
               'The app is already bound to the service instance'
             )
           end
@@ -57,7 +57,7 @@ module V3
             another_space = Space.make
             another_app = AppModel.make(space: another_space)
             expect { action.precursor(service_instance, app: another_app, name: details[:name]) }.to raise_error(
-              ServiceCredentialBindingCreate::UnprocessableCreate,
+              ServiceCredentialBindingAppCreate::UnprocessableCreate,
               'The service instance and the app are in different spaces'
             )
           end
@@ -92,7 +92,7 @@ module V3
 
             it 'raises an error' do
               expect { action.precursor(service_instance, app: app) }.to raise_error(
-                ServiceCredentialBindingCreate::UnprocessableCreate,
+                ServiceCredentialBindingAppCreate::UnprocessableCreate,
                 'Service plan does not allow bindings'
               )
             end
@@ -105,7 +105,7 @@ module V3
 
             it 'raises an error' do
               expect { action.precursor(service_instance, app: app) }.to raise_error(
-                ServiceCredentialBindingCreate::UnprocessableCreate,
+                ServiceCredentialBindingAppCreate::UnprocessableCreate,
                 'Service plan is not available'
               )
             end
@@ -118,7 +118,7 @@ module V3
               expect {
                 action.precursor(service_instance, app: app, volume_mount_services_enabled: false)
               }.to raise_error(
-                ServiceCredentialBindingCreate::UnprocessableCreate,
+                ServiceCredentialBindingAppCreate::UnprocessableCreate,
                 'Support for volume mount services is disabled'
               )
             end
@@ -131,7 +131,7 @@ module V3
               expect {
                 action.precursor(service_instance, app: app, volume_mount_services_enabled: false)
               }.to raise_error(
-                ServiceCredentialBindingCreate::UnprocessableCreate,
+                ServiceCredentialBindingAppCreate::UnprocessableCreate,
                 'There is an operation in progress for the service instance'
               )
             end

spec/unit/jobs/v3/create_service_binding_job_factory_spec.rb

@@ -30,7 +30,7 @@ module V3
 
         it 'should return credential binding action when type is credential' do
           actor = CreateServiceBindingFactory.action(:credential, {}, {})
-          expect(actor).to be_an_instance_of(ServiceCredentialBindingCreate)
+          expect(actor).to be_an_instance_of(ServiceCredentialBindingAppCreate)
         end
 
         it 'raise for unknown types' do