Fix v3 🐞: UnknownError when API user specifies big numbers for quota limits

-Both mysql and postgres use ints to store these fields which have a max
value of 2^31 -1.

[finishes #172549179]

Co-authored-by: Reid Mitchell <rmitchell@pivotal.io>
Co-authored-by: Merric de Launey <mdelauney@pivotal.io>

Author: reidmit

app/messages/base_message.rb

@@ -6,6 +6,8 @@ class BaseMessage
     include ActiveModel::Model
     include Validators
 
+    MAX_DB_INT = 2**31 - 1
+
     attr_accessor :requested_keys, :extra_keys
 
     def self.allowed_keys

app/messages/quotas_apps_message.rb

@@ -8,19 +8,19 @@ class QuotasAppsMessage < BaseMessage
     validates_with NoAdditionalKeysValidator
 
     validates :total_memory_in_mb,
-      numericality: { only_integer: true, greater_than_or_equal_to: 0 },
+      numericality: { only_integer: true, greater_than_or_equal_to: 0, less_than_or_equal_to: MAX_DB_INT },
       allow_nil: true
 
     validates :per_process_memory_in_mb,
-      numericality: { only_integer: true, greater_than_or_equal_to: 0 },
+      numericality: { only_integer: true, greater_than_or_equal_to: 0, less_than_or_equal_to: MAX_DB_INT },
       allow_nil: true
 
     validates :total_instances,
-      numericality: { only_integer: true, greater_than_or_equal_to: 0 },
+      numericality: { only_integer: true, greater_than_or_equal_to: 0, less_than_or_equal_to: MAX_DB_INT },
       allow_nil: true
 
     validates :per_app_tasks,
-      numericality: { only_integer: true, greater_than_or_equal_to: 0 },
+      numericality: { only_integer: true, greater_than_or_equal_to: 0, less_than_or_equal_to: MAX_DB_INT },
       allow_nil: true
   end
 end

app/messages/quotas_routes_message.rb

@@ -8,11 +8,11 @@ class QuotasRoutesMessage < BaseMessage
     validates_with NoAdditionalKeysValidator
 
     validates :total_routes,
-      numericality: { only_integer: true, greater_than_or_equal_to: 0 },
+      numericality: { only_integer: true, greater_than_or_equal_to: 0, less_than_or_equal_to: MAX_DB_INT },
       allow_nil: true
 
     validates :total_reserved_ports,
-      numericality: { only_integer: true, greater_than_or_equal_to: 0 },
+      numericality: { only_integer: true, greater_than_or_equal_to: 0, less_than_or_equal_to: MAX_DB_INT },
       allow_nil: true
   end
 end

app/messages/quotas_services_message.rb

@@ -8,11 +8,11 @@ class QuotasServicesMessage < BaseMessage
     validates_with NoAdditionalKeysValidator
 
     validates :total_service_keys,
-      numericality: { only_integer: true, greater_than_or_equal_to: 0 },
+      numericality: { only_integer: true, greater_than_or_equal_to: 0, less_than_or_equal_to: MAX_DB_INT },
       allow_nil: true
 
     validates :total_service_instances,
-      numericality: { only_integer: true, greater_than_or_equal_to: 0 },
+      numericality: { only_integer: true, greater_than_or_equal_to: 0, less_than_or_equal_to: MAX_DB_INT },
       allow_nil: true
 
     validates :paid_services_allowed,

spec/unit/messages/quotas_apps_message_spec.rb

@@ -50,7 +50,18 @@ module VCAP::CloudController
           end
         end
 
-        context 'when the type is zero' do
+        context 'when the value is greater than the maximum allowed value in the DB' do
+          let(:params) do
+            { total_memory_in_mb: 1000000000000000000000000 }
+          end
+
+          it 'is not valid' do
+            expect(subject).to be_invalid
+            expect(subject.errors).to contain_exactly('Total memory in mb must be less than or equal to 2147483647')
+          end
+        end
+
+        context 'when the value is zero' do
           let(:params) do
             { total_memory_in_mb: 0 }
           end
@@ -112,6 +123,17 @@ module VCAP::CloudController
 
           it { is_expected.to be_valid }
         end
+
+        context 'when the value is greater than the maximum allowed value in the DB' do
+          let(:params) do
+            { per_process_memory_in_mb: 1000000000000000000000000 }
+          end
+
+          it 'is not valid' do
+            expect(subject).to be_invalid
+            expect(subject.errors).to contain_exactly('Per process memory in mb must be less than or equal to 2147483647')
+          end
+        end
       end
 
       describe 'total_instances' do
@@ -160,6 +182,17 @@ module VCAP::CloudController
 
           it { is_expected.to be_valid }
         end
+
+        context 'when the value is greater than the maximum allowed value in the DB' do
+          let(:params) do
+            { total_instances: 1000000000000000000000000 }
+          end
+
+          it 'is not valid' do
+            expect(subject).to be_invalid
+            expect(subject.errors).to contain_exactly('Total instances must be less than or equal to 2147483647')
+          end
+        end
       end
 
       describe 'per_app_tasks' do
@@ -211,6 +244,17 @@ module VCAP::CloudController
 
           it { is_expected.to be_valid }
         end
+
+        context 'when the value is greater than the maximum allowed value in the DB' do
+          let(:params) do
+            { per_app_tasks: 1000000000000000000000000 }
+          end
+
+          it 'is not valid' do
+            expect(subject).to be_invalid
+            expect(subject.errors).to contain_exactly('Per app tasks must be less than or equal to 2147483647')
+          end
+        end
       end
     end
   end

spec/unit/messages/quotas_routes_message_spec.rb

@@ -65,6 +65,17 @@ module VCAP::CloudController
 
           it { is_expected.to be_valid }
         end
+
+        context 'when the value is greater than the maximum allowed value in the DB' do
+          let(:params) do
+            { total_routes: 1000000000000000000000000 }
+          end
+
+          it 'is not valid' do
+            expect(subject).to be_invalid
+            expect(subject.errors).to contain_exactly('Total routes must be less than or equal to 2147483647')
+          end
+        end
       end
 
       describe 'total_reserved_ports' do
@@ -116,6 +127,16 @@ module VCAP::CloudController
 
           it { is_expected.to be_valid }
         end
+        context 'when the value is greater than the maximum allowed value in the DB' do
+          let(:params) do
+            { total_reserved_ports: 1000000000000000000000000 }
+          end
+
+          it 'is not valid' do
+            expect(subject).to be_invalid
+            expect(subject.errors).to contain_exactly('Total reserved ports must be less than or equal to 2147483647')
+          end
+        end
       end
     end
   end

spec/unit/messages/quotas_services_message_spec.rb

@@ -62,6 +62,16 @@ module VCAP::CloudController
 
           it { is_expected.to be_valid }
         end
+        context 'when the value is greater than the maximum allowed value in the DB' do
+          let(:params) do
+            { total_service_instances: 1000000000000000000000000 }
+          end
+
+          it 'is not valid' do
+            expect(subject).to be_invalid
+            expect(subject.errors).to contain_exactly('Total service instances must be less than or equal to 2147483647')
+          end
+        end
       end
 
       describe 'total_service_keys' do
@@ -110,6 +120,16 @@ module VCAP::CloudController
 
           it { is_expected.to be_valid }
         end
+        context 'when the value is greater than the maximum allowed value in the DB' do
+          let(:params) do
+            { total_service_keys: 1000000000000000000000000 }
+          end
+
+          it 'is not valid' do
+            expect(subject).to be_invalid
+            expect(subject.errors).to contain_exactly('Total service keys must be less than or equal to 2147483647')
+          end
+        end
       end
 
       describe 'paid_services_allowed' do