v3(services): delete route binding fixes (cloudfoundry#1878)

- docs were missing
- failure was not reported on last_operation

[#174191028](https://www.pivotaltracker.com/story/show/174191028)

Author: blgm

app/actions/service_route_binding_delete.rb

@@ -24,6 +24,14 @@ def delete(binding, async_allowed:)
         binding.notify_diego
 
         DeleteComplete
+      rescue => e
+        binding.save_with_new_operation({}, {
+          type: 'delete',
+          state: 'failed',
+          description: e.message,
+        })
+
+        raise e
       end
 
       private

…s/service_credential_bindings/_delete.md …rvice_credential_bindings/_delete.md.erbdocs/v3/source/includes/experimental_resources/service_credential_bindings/_delete.md renamed to docs/v3/source/includes/experimental_resources/service_credential_bindings/_delete.md.erb docs/v3/source/includes/experimental_resources/service_credential_bindings/_delete.md renamed to docs/v3/source/includes/experimental_resources/service_credential_bindings/_delete.md.erb

@@ -0,0 +1,43 @@
+### Delete a service route binding
+
+```
+Example Request
+```
+
+```shell
+curl "https://api.example.org/v3/service_route_bindings/[guid]" \
+  -X DELETE \
+  -H "Authorization: bearer [token]"
+```
+
+```
+Example Response for User-provided Service Instances
+```
+
+```http
+HTTP/1.1 204 No Content
+```
+
+```
+Example Response for Managed Service Instance
+```
+
+```http
+HTTP/1.1 202 Accepted
+Content-Type: application/json
+Location: https://api.example.org/v3/jobs/af5c57f6-8769-41fa-a499-2c84ed896788
+```
+
+This endpoint deletes a service route binding. When deleting route bindings originating from user provided
+service instances, the delete operation does not require interactions with service brokers, therefore the API will 
+respond synchronously to the delete request. Consequently, deleting route bindings from managed service instances
+responds with a job which can be used to track the progress of the delete operation.
+
+#### Definition
+`DELETE /v3/service_route_bindings/:guid`
+
+#### Permitted Roles
+ |
+--- | ---
+Admin |
+Space Developer |

docs/v3/source/includes/experimental_resources/service_route_bindings/_delete.md.erb

@@ -368,6 +368,7 @@ includes:
   - experimental_resources/service_route_bindings/create
   - experimental_resources/service_route_bindings/list
   - experimental_resources/service_route_bindings/get
+  - experimental_resources/service_route_bindings/delete
   - experimental_resources/service_instances/header
   - experimental_resources/service_instances/create
   - experimental_resources/service_instances/get

docs/v3/source/index.md

@@ -122,13 +122,17 @@ module V3
                 dbl
               end
 
-              it 'fails with an appropriate error' do
+              it 'fails with an appropriate error and stores the message in the binding' do
                 expect {
                   action.delete(route_binding, async_allowed: async_allowed)
                 }.to raise_error(
                   described_class::UnprocessableDelete,
                   "Service broker failed to delete service binding for instance #{service_instance.name}: awful thing",
                 )
+
+                expect(route_binding.last_operation.type).to eq('delete')
+                expect(route_binding.last_operation.state).to eq('failed')
+                expect(route_binding.last_operation.description).to eq("Service broker failed to delete service binding for instance #{service_instance.name}: awful thing")
               end
             end
           end