Update rubocop to 0.93.1

Authored-by: Greg Cobb <gcobb@pivotal.io>

Author: Gerg

.rubocop.yml

@@ -448,3 +448,11 @@ Lint/IdentityComparison:
 Lint/UselessTimes:
   Enabled: true
 
+Lint/HashCompareByIdentity:
+  Enabled: true
+
+Lint/RedundantSafeNavigation:
+  Enabled: true
+
+Style/ClassEqualityComparison:
+  Enabled: true

Gemfile

@@ -88,7 +88,7 @@ group :test do
   gem 'rspec-rails', '~> 3.9.1'
   gem 'rspec-wait'
   gem 'rspec_api_documentation', '>= 6.1.0'
-  gem 'rubocop', '~> 0.92.0'
+  gem 'rubocop', '~> 0.93.1'
   gem 'timecop'
   gem 'webmock', '> 2.3.1'
 end

Gemfile.lock

@@ -395,13 +395,13 @@ GEM
       activesupport (>= 3.0.0)
       mustache (~> 1.0, >= 0.99.4)
       rspec (~> 3.0)
-    rubocop (0.92.0)
+    rubocop (0.93.1)
       parallel (~> 1.10)
       parser (>= 2.7.1.5)
       rainbow (>= 2.2.2, < 4.0)
-      regexp_parser (>= 1.7)
+      regexp_parser (>= 1.8)
       rexml
-      rubocop-ast (>= 0.5.0)
+      rubocop-ast (>= 0.6.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 1.4.0, < 2.0)
     rubocop-ast (1.0.1)
@@ -567,7 +567,7 @@ DEPENDENCIES
   rspec-rails (~> 3.9.1)
   rspec-wait
   rspec_api_documentation (>= 6.1.0)
-  rubocop (~> 0.92.0)
+  rubocop (~> 0.93.1)
   ruby-debug-ide (>= 0.7.0.beta4)
   rubyzip (>= 1.3.0)
   scientist (~> 1.1.0)

app/controllers/services/service_instances_controller.rb

@@ -300,7 +300,7 @@ def route_binding_parameters(service_instance_guid, route_guid)
     end
 
     def self.url_for_guid(guid, object=nil)
-      if object.class == UserProvidedServiceInstance
+      if object.instance_of?(UserProvidedServiceInstance)
         user_provided_path = VCAP::CloudController::UserProvidedServiceInstancesController.path
         "#{user_provided_path}/#{guid}"
       else

app/messages/validators/security_group_rule_validator.rb

@@ -47,7 +47,7 @@ def boolean?(value)
   end
 
   def valid_protocol(protocol)
-    protocol&.is_a?(String) && %w(tcp udp icmp all).include?(protocol)
+    protocol.is_a?(String) && %w(tcp udp icmp all).include?(protocol)
   end
 
   def validate_allowed_keys(rule, record, index)
@@ -83,9 +83,8 @@ def valid_icmp_format(field)
     field.is_a?(Integer) && field >= -1 && field <= 255
   end
 
-  # rubocop:todo Metrics/CyclomaticComplexity
   def valid_ports(ports)
-    return false unless ports&.is_a?(String)
+    return false unless ports.is_a?(String)
     return false if /[^\d\s\-,]/.match?(ports)
 
     port_range = /\A\s*(\d+)\s*-\s*(\d+)\s*\z/.match(ports)
@@ -109,7 +108,6 @@ def valid_ports(ports)
 
     false
   end
-  # rubocop:enable Metrics/CyclomaticComplexity
 
   def port_in_range(port)
     port > 0 && port < 65536

app/presenters/v2/process_model_presenter.rb

@@ -68,9 +68,9 @@ def logger
         end
 
         def buildpack_name_or_url(buildpack)
-          if buildpack.class == VCAP::CloudController::CustomBuildpack
+          if buildpack.instance_of?(VCAP::CloudController::CustomBuildpack)
             CloudController::UrlSecretObfuscator.obfuscate(buildpack.url)
-          elsif buildpack.class == VCAP::CloudController::Buildpack
+          elsif buildpack.instance_of?(VCAP::CloudController::Buildpack)
             buildpack.name
           end
         end

app/presenters/v3/service_instance_presenter.rb

@@ -10,7 +10,7 @@ class ServiceInstancePresenter < BasePresenter
         def to_hash
           hash = correct_order(
             hash_common.deep_merge(
-              if service_instance.class == ManagedServiceInstance
+              if service_instance.instance_of?(ManagedServiceInstance)
                 hash_additions_managed
               else
                 hash_additions_user_provided

lib/diego/action_builder.rb

@@ -58,7 +58,7 @@ def codependent(actions)
       private
 
       def action_already_wrapped?(action)
-        action.class == Bbs::Models::Action
+        action.instance_of?(Bbs::Models::Action)
       end
     end
 

lib/services/service_brokers/v2/client.rb

@@ -139,7 +139,7 @@ def bind(binding, arbitrary_parameters: {}, accepts_incomplete: false)
            Errors::ServiceBrokerInvalidVolumeMounts,
            Errors::ServiceBrokerInvalidSyslogDrainUrl,
            Errors::ServiceBrokerResponseMalformed => e
-      unless e.class == Errors::ServiceBrokerResponseMalformed && e.status == 200
+      unless e.instance_of?(Errors::ServiceBrokerResponseMalformed) && e.status == 200
         @orphan_mitigator.cleanup_failed_bind(@attrs, binding)
       end