Implement get and list methods for tasks in OPI (cloudfoundry#1892)

* Implement get and list methods for tasks in OPI

[#174335347]

Co-authored-by: Danail Branekov <danailster@gmail.com>
Co-authored-by: Giuseppe Capizzi <gcapizzi@pivotal.io>
Co-authored-by: Danail Branekov <danailster@gmail.com>

Author: 3 people

lib/cloud_controller/opi/task_client.rb

@@ -21,12 +21,33 @@ def desire_task(task, domain)
       end
     end
 
-    def fetch_task(_)
-      Diego::Bbs::Models::Task.new
+    def fetch_task(guid)
+      resp = client.get("/tasks/#{guid}")
+
+      return if resp.status_code == 404
+
+      if resp.status_code != 200
+        raise CloudController::Errors::ApiError.new_from_details('TaskError', "response status code: #{resp.status_code}")
+      end
+
+      task = JSON.parse(resp.body)
+      task[:task_guid] = task.delete('guid')
+      OPI.recursive_ostruct(task)
     end
 
     def fetch_tasks
-      []
+      resp = client.get('/tasks')
+
+      if resp.status_code != 200
+        raise CloudController::Errors::ApiError.new_from_details('TaskError', "response status code: #{resp.status_code}")
+      end
+
+      tasks = JSON.parse(resp.body)
+      tasks.each do |task|
+        task['task_guid'] = task.delete('guid')
+      end
+
+      tasks.map { |t| OPI.recursive_ostruct(t) }
     end
 
     def cancel_task(guid)

spec/unit/lib/cloud_controller/opi/task_client_spec.rb

@@ -138,24 +138,80 @@
   end
 
   describe 'can fetch a task' do
-    it 'should return a empty dummy task' do
-      task = client.fetch_task('some-guid')
-      expect(task).to eq(Diego::Bbs::Models::Task.new)
+    let(:expected_body) {
+      { 'guid': 'foo' }.to_json
+    }
+
+    before(:each) do
+      stub_request(:get, "#{opi_url}/tasks/some-task-guid").
+        to_return(status: 200, body: expected_body)
     end
 
-    it 'should not send any request to opi' do
-      expect(a_request(:any, opi_url)).not_to have_been_made
+    it 'should return a parsed task' do
+      task = client.fetch_task('some-task-guid')
+
+      expect(WebMock).to have_requested(:get, "#{opi_url}/tasks/some-task-guid")
+
+      expect(task).to eq(OpenStruct.new(task_guid: 'foo'))
+    end
+
+    context 'when the task is not found' do
+      before(:each) do
+        stub_request(:get, "#{opi_url}/tasks/some-task-guid").
+          to_return(status: 404)
+      end
+
+      it 'should return nil' do
+        expect(client.fetch_task('some-task-guid')).to be_nil
+      end
+    end
+
+    context 'when fetching the task fails' do
+      before(:each) do
+        stub_request(:get, "#{opi_url}/tasks/some-task-guid").
+          to_return(status: 500)
+      end
+
+      it 'should raise an ApiError' do
+        expect { client.fetch_task('some-task-guid') }.to raise_error(CloudController::Errors::ApiError, /response status code: 500/) do |e|
+          expect(e.name).to eq('TaskError')
+        end
+      end
     end
   end
 
   describe 'can fetch all tasks' do
-    it 'should return an empty list' do
+    let(:expected_body) {
+      [{ 'guid': 'foo' }, { 'guid': 'bar' }].to_json
+    }
+
+    before(:each) do
+      stub_request(:get, "#{opi_url}/tasks").
+        to_return(status: 200, body: expected_body)
+    end
+
+    it 'should return a parsed list of tasks' do
       tasks = client.fetch_tasks
-      expect(tasks).to be_empty
+
+      expect(WebMock).to have_requested(:get, "#{opi_url}/tasks")
+
+      expect(tasks).to match_array([
+        OpenStruct.new(task_guid: 'foo'),
+        OpenStruct.new(task_guid: 'bar'),
+      ])
     end
 
-    it 'should not send any request to opi' do
-      expect(a_request(:any, opi_url)).not_to have_been_made
+    context 'when fetching the tasks fails' do
+      before(:each) do
+        stub_request(:get, "#{opi_url}/tasks").
+          to_return(status: 500)
+      end
+
+      it 'should raise an ApiError' do
+        expect { client.fetch_tasks }.to raise_error(CloudController::Errors::ApiError, /response status code: 500/) do |e|
+          expect(e.name).to eq('TaskError')
+        end
+      end
     end
   end