Fix usernames sometimes not appearing when listing users

* Previously, this endpoint would fetch all of the usernames for the users
specified by the request regardless of pagination
* Changed pagination limit in internal UAA client to be able to view all
resources requested on a single page

[#172806463]

Co-authored-by: Reid Mitchell <rmitchell@pivotal.io>
Co-authored-by: Mona Mohebbi <mmohebbi@pivotal.io>

Author: reidmit

app/controllers/v3/users_controller.rb

@@ -13,11 +13,13 @@ def index
     unprocessable!(message.errors.full_messages) unless message.valid?
 
     users = fetch_readable_users(message)
-    user_guids = users.map(&:guid)
+
+    paginated_result = SequelPaginator.new.get_page(users, message.try(:pagination_options))
+    user_guids = paginated_result.records.map(&:guid)
 
     render status: :ok, json: Presenters::V3::PaginatedListPresenter.new(
       presenter: Presenters::V3::UserPresenter,
-      paginated_result: SequelPaginator.new.get_page(users, message.try(:pagination_options)),
+      paginated_result: paginated_result,
       path: '/v3/users',
       message: message,
       extra_presenter_args: { uaa_users: User.uaa_users_info(user_guids) },

lib/cloud_controller/uaa/uaa_client.rb

@@ -118,7 +118,7 @@ def fetch_users(user_ids)
       return {} unless user_ids.present?
 
       filter_string = user_ids.map { |user_id| %(id eq "#{user_id}") }.join(' or ')
-      results = query(:user_id, filter: filter_string)
+      results = query(:user_id, filter: filter_string, count: user_ids.length)
 
       results['resources'].each_with_object({}) do |resource, results_hash|
         results_hash[resource['id']] = resource

spec/unit/lib/uaa/uaa_client_spec.rb

@@ -168,7 +168,7 @@ module VCAP::CloudController
           'totalresults' => 2 }
 
         WebMock::API.stub_request(:get, "#{url}/ids/Users").
-          with(query: { 'filter' => 'id eq "111" or id eq "222"' }).
+          with(query: { 'filter' => 'id eq "111" or id eq "222"', 'count' => 2 }).
           to_return(
             status: 200,
             headers: { 'content-type' => 'application/json' },
@@ -229,14 +229,14 @@ module VCAP::CloudController
             'totalresults' => 2 }
 
           WebMock::API.stub_request(:get, "#{url}/ids/Users").
-            with(query: { 'filter' => 'id eq "111" or id eq "222"' }, headers: { 'Authorization' => 'bearer STUFF' }).
+            with(query: { 'filter' => 'id eq "111" or id eq "222"', 'count' => 2 }, headers: { 'Authorization' => 'bearer STUFF' }).
             to_return(
               status: 200,
               headers: { 'content-type' => 'application/json' },
               body: response_body.to_json)
 
           WebMock::API.stub_request(:get, "#{url}/ids/Users").
-            with(query: { 'filter' => 'id eq "111" or id eq "222"' }, headers: { 'Authorization' => 'bearer invalid' }).
+            with(query: { 'filter' => 'id eq "111" or id eq "222"', 'count' => 2 }, headers: { 'Authorization' => 'bearer invalid' }).
             to_return(
               status: 403,
               headers: { 'content-type' => 'application/json' },
@@ -277,7 +277,7 @@ module VCAP::CloudController
           'totalresults' => 2 }
 
         WebMock::API.stub_request(:get, "#{url}/ids/Users").
-          with(query: { 'filter' => 'id eq "111" or id eq "222"' }).
+          with(query: { 'filter' => 'id eq "111" or id eq "222"', 'count' => 2 }).
           to_return(
             status: 200,
             headers: { 'content-type' => 'application/json' },
@@ -338,14 +338,14 @@ module VCAP::CloudController
             'totalresults' => 2 }
 
           WebMock::API.stub_request(:get, "#{url}/ids/Users").
-            with(query: { 'filter' => 'id eq "111" or id eq "222"' }, headers: { 'Authorization' => 'bearer STUFF' }).
+            with(query: { 'filter' => 'id eq "111" or id eq "222"', 'count' => 2 }, headers: { 'Authorization' => 'bearer STUFF' }).
             to_return(
               status: 200,
               headers: { 'content-type' => 'application/json' },
               body: response_body.to_json)
 
           WebMock::API.stub_request(:get, "#{url}/ids/Users").
-            with(query: { 'filter' => 'id eq "111" or id eq "222"' }, headers: { 'Authorization' => 'bearer invalid' }).
+            with(query: { 'filter' => 'id eq "111" or id eq "222"', 'count' => 2 }, headers: { 'Authorization' => 'bearer invalid' }).
             to_return(
               status: 403,
               headers: { 'content-type' => 'application/json' },