v3(style): Fix rubocop issues

[#174398272](https://www.pivotaltracker.com/story/show/174398272)

Author: pivotal-marcela-campo

app/jobs/reoccurring_job.rb

@@ -31,7 +31,6 @@ def maximum_duration_seconds=(duration)
 
       def polling_interval_seconds
         [@polling_interval || 0, default_polling_interval_seconds].max
-
       end
 
       def polling_interval_seconds=(interval)

spec/unit/jobs/reoccurring_job_spec.rb

@@ -80,11 +80,11 @@ def perform
         Jobs::Enqueuer.new(job, queue: Jobs::Queues.generic).enqueue_pollable
         execute_all_jobs(expected_successes: 1, expected_failures: 0)
 
-        Timecop.freeze(94.seconds.after enqueued_time) do
+        Timecop.freeze(94.seconds.after(enqueued_time)) do
           execute_all_jobs(expected_successes: 0, expected_failures: 0)
         end
 
-        Timecop.freeze(96.seconds.after enqueued_time) do
+        Timecop.freeze(96.seconds.after(enqueued_time)) do
           execute_all_jobs(expected_successes: 1, expected_failures: 0)
         end
       end
@@ -99,89 +99,88 @@ def perform
       end
 
       context 'updates the polling interval if config changes' do
-          it 'when changed from the job only' do
-            job = FakeJob.new(retry_after: [20, 30])
-            TestConfig.config[:broker_client_default_async_poll_interval_seconds] = 10
+        it 'when changed from the job only' do
+          job = FakeJob.new(retry_after: [20, 30])
+          TestConfig.config[:broker_client_default_async_poll_interval_seconds] = 10
 
-            enqueued_time = Time.now
+          enqueued_time = Time.now
+
+          Jobs::Enqueuer.new(job, queue: Jobs::Queues.generic).enqueue_pollable
+          execute_all_jobs(expected_successes: 1, expected_failures: 0)
+
+          Timecop.freeze(19.seconds.after(enqueued_time)) do
+            execute_all_jobs(expected_successes: 0, expected_failures: 0)
+          end
 
-            Jobs::Enqueuer.new(job, queue: Jobs::Queues.generic).enqueue_pollable
+          Timecop.freeze(22.seconds.after(enqueued_time)) do
+            enqueued_time = Time.now
             execute_all_jobs(expected_successes: 1, expected_failures: 0)
+          end
 
-            Timecop.freeze(19.seconds.after enqueued_time) do
-              execute_all_jobs(expected_successes: 0, expected_failures: 0)
-            end
+          Timecop.freeze(29.seconds.after(enqueued_time)) do
+            execute_all_jobs(expected_successes: 0, expected_failures: 0)
+          end
 
-            Timecop.freeze(22.seconds.after enqueued_time) do
-              enqueued_time = Time.now
-              execute_all_jobs(expected_successes: 1, expected_failures: 0)
-            end
+          Timecop.freeze(32.seconds.after(enqueued_time)) do
+            execute_all_jobs(expected_successes: 1, expected_failures: 0)
+          end
+        end
 
-            Timecop.freeze(29.seconds.after enqueued_time) do
-              execute_all_jobs(expected_successes: 0, expected_failures: 0)
-            end
+        it 'when default changed after changing from the job' do
+          job = FakeJob.new(retry_after: [20])
+          TestConfig.config[:broker_client_default_async_poll_interval_seconds] = 10
 
-            Timecop.freeze(32.seconds.after enqueued_time) do
-              execute_all_jobs(expected_successes: 1, expected_failures: 0)
-            end
+          enqueued_time = Time.now
 
-          end
+          Jobs::Enqueuer.new(job, queue: Jobs::Queues.generic).enqueue_pollable
+          execute_all_jobs(expected_successes: 1, expected_failures: 0)
 
-          it 'when default changed after changing from the job' do
-            job = FakeJob.new(retry_after: [20])
-            TestConfig.config[:broker_client_default_async_poll_interval_seconds] = 10
+          Timecop.freeze(19.seconds.after(enqueued_time)) do
+            execute_all_jobs(expected_successes: 0, expected_failures: 0)
+          end
 
+          Timecop.freeze(21.seconds.after(enqueued_time)) do
+            TestConfig.config[:broker_client_default_async_poll_interval_seconds] = 30
             enqueued_time = Time.now
+            execute_all_jobs(expected_successes: 1, expected_failures: 0)
+          end
 
-            Jobs::Enqueuer.new(job, queue: Jobs::Queues.generic).enqueue_pollable
+          Timecop.freeze(29.seconds.after(enqueued_time)) do
+            execute_all_jobs(expected_successes: 0, expected_failures: 0)
+          end
+
+          Timecop.freeze(31.seconds.after(enqueued_time)) do
             execute_all_jobs(expected_successes: 1, expected_failures: 0)
+          end
+        end
 
-            Timecop.freeze(19.seconds.after enqueued_time) do
-              execute_all_jobs(expected_successes: 0, expected_failures: 0)
-            end
+        it 'when changing default only' do
+          job = FakeJob.new
+          TestConfig.config[:broker_client_default_async_poll_interval_seconds] = 10
 
-            Timecop.freeze(21.seconds.after enqueued_time) do
-              TestConfig.config[:broker_client_default_async_poll_interval_seconds] = 30
-              enqueued_time = Time.now
-              execute_all_jobs(expected_successes: 1, expected_failures: 0)
-            end
+          enqueued_time = Time.now
 
-            Timecop.freeze(29.seconds.after enqueued_time) do
-              execute_all_jobs(expected_successes: 0, expected_failures: 0)
-            end
+          Jobs::Enqueuer.new(job, queue: Jobs::Queues.generic).enqueue_pollable
+          execute_all_jobs(expected_successes: 1, expected_failures: 0)
 
-            Timecop.freeze(31.seconds.after enqueued_time) do
-              execute_all_jobs(expected_successes: 1, expected_failures: 0)
-            end
+          Timecop.freeze(9.seconds.after(enqueued_time)) do
+            execute_all_jobs(expected_successes: 0, expected_failures: 0)
           end
 
-          it 'when changing default only' do
-            job = FakeJob.new
-            TestConfig.config[:broker_client_default_async_poll_interval_seconds] = 10
-
+          Timecop.freeze(11.seconds.after(enqueued_time)) do
+            TestConfig.config[:broker_client_default_async_poll_interval_seconds] = 30
             enqueued_time = Time.now
-
-            Jobs::Enqueuer.new(job, queue: Jobs::Queues.generic).enqueue_pollable
             execute_all_jobs(expected_successes: 1, expected_failures: 0)
+          end
 
-            Timecop.freeze(9.seconds.after enqueued_time) do
-              execute_all_jobs(expected_successes: 0, expected_failures: 0)
-            end
-
-            Timecop.freeze(11.seconds.after enqueued_time) do
-              TestConfig.config[:broker_client_default_async_poll_interval_seconds] = 30
-              enqueued_time = Time.now
-              execute_all_jobs(expected_successes: 1, expected_failures: 0)
-            end
-
-            Timecop.freeze(29.seconds.after enqueued_time) do
-              execute_all_jobs(expected_successes: 0, expected_failures: 0)
-            end
+          Timecop.freeze(29.seconds.after(enqueued_time)) do
+            execute_all_jobs(expected_successes: 0, expected_failures: 0)
+          end
 
-            Timecop.freeze(31.seconds.after enqueued_time) do
-              execute_all_jobs(expected_successes: 1, expected_failures: 0)
-            end
+          Timecop.freeze(31.seconds.after(enqueued_time)) do
+            execute_all_jobs(expected_successes: 1, expected_failures: 0)
           end
+        end
       end
 
       it 'continues to run until finished' do
@@ -208,7 +207,7 @@ def perform
           execute_all_jobs(expected_successes: 0, expected_failures: 1)
           expect(PollableJobModel.first.state).to eq('FAILED')
 
-          Timecop.freeze(61.seconds.after Time.now) do
+          Timecop.freeze(61.seconds.after(Time.now)) do
             execute_all_jobs(expected_successes: 0, expected_failures: 0)
           end
         end
@@ -251,7 +250,7 @@ def handle_timeout
 
           Jobs::Enqueuer.new(job, queue: Jobs::Queues.generic).enqueue_pollable
 
-          Timecop.freeze(61.seconds.after Time.now) do
+          Timecop.freeze(61.seconds.after(Time.now)) do
             execute_all_jobs(expected_successes: 0, expected_failures: 1, jobs_to_execute: 1)
             expect(PollableJobModel.first.state).to eq('FAILED')
           end