Skip to content

Commit e1b50d7

Browse files
authored
chore(deps): Update dependency golangci/golangci-lint to v1.64.5 (#631)
This PR contains the following updates: | Package | Update | Change | Pending | |---|---|---|---| | [golangci/golangci-lint](https://redirect.github.com/golangci/golangci-lint) | minor | `v1.63.4` -> `v1.64.5` | `v1.64.6` | --- ### Release Notes <details> <summary>golangci/golangci-lint (golangci/golangci-lint)</summary> ### [`v1.64.5`](https://redirect.github.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v1645) [Compare Source](https://redirect.github.com/golangci/golangci-lint/compare/v1.64.4...v1.64.5) 1. Bug fixes - Add missing flag `new-from-merge-base-flag` 2. Linters bug fixes - `asciicheck`: from 0.3.0 to 0.4.0 - `forcetypeassert`: from 0.1.0 to 0.2.0 - `gosec`: from 2.22.0 to 2.22.1 ### [`v1.64.4`](https://redirect.github.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v1644) [Compare Source](https://redirect.github.com/golangci/golangci-lint/compare/v1.64.3...v1.64.4) 1. Linters bug fixes - `gci`: fix standard packages list for go1.24 ### [`v1.64.3`](https://redirect.github.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v1643) [Compare Source](https://redirect.github.com/golangci/golangci-lint/compare/v1.64.2...v1.64.3) 1. Linters bug fixes - `ginkgolinter`: from 0.18.4 to 0.19.0 - `go-critic`: from 0.11.5 to 0.12.0 - `revive`: from 1.6.0 to 1.6.1 - `gci`: fix standard packages list for go1.24 2. Misc. - Build Docker images with go1.24 ### [`v1.64.2`](https://redirect.github.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v1642) [Compare Source](https://redirect.github.com/golangci/golangci-lint/compare/v1.63.4...v1.64.2) This is the last minor release of golangci-lint v1. The next release will be golangci-lint [v2](https://redirect.github.com/golangci/golangci-lint/issues/5300). 1. Enhancements - 🎉 go1.24 support - New `issues.new-from-merge-base` option - New `run.relative-path-mode` option 2. Linters new features - `copyloopvar`: from 1.1.0 to 1.2.1 (support suggested fixes) - `exptostd`: from 0.3.1 to 0.4.1 (handles `golang.org/x/exp/constraints.Ordered`) - `fatcontext`: from 0.5.3 to 0.7.1 (new option: `check-struct-pointers`) - `perfsprint`: from 0.7.1 to 0.8.1 (new options: `integer-format`, `error-format`, `string-format`, `bool-format`, and `hex-format`) - `revive`: from 1.5.1 to 1.6.0 (new rules: `redundant-build-tag`, `use-errors-new`. New option `early-return.early-return`) 3. Linters bug fixes - `go-errorlint`: from 1.7.0 to 1.7.1 - `gochecknoglobals`: from 0.2.1 to 0.2.2 - `godox`: from [`006bad1`](https://redirect.github.com/golangci/golangci-lint/commit/006bad1f9d26) to 1.1.0 - `gosec`: from 2.21.4 to 2.22.0 - `iface`: from 1.3.0 to 1.3.1 - `nilnesserr`: from 0.1.1 to 0.1.2 - `protogetter`: from 0.3.8 to 0.3.9 - `sloglint`: from 0.7.2 to 0.9.0 - `spancheck`: fix default `StartSpanMatchersSlice` values - `staticcheck`: from 0.5.1 to 0.6.0 4. Deprecations - ⚠️ `tenv` is deprecated and replaced by `usetesting.os-setenv: true`. - ⚠️ `exportloopref` deprecation step 2 5. Misc. - Sanitize severities by output format - Avoid panic with plugin without description 6. Documentation - Clarify `depguard` configuration </details> --- ### Configuration 📅 **Schedule**: Branch creation - "* 0-3 1 * *" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xODUuMCIsInVwZGF0ZWRJblZlciI6IjM5LjE4NS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJhdXRvbWVyZ2UiXX0=-->
1 parent 7dc7d67 commit e1b50d7

5 files changed

Lines changed: 11 additions & 9 deletions

File tree

.github/workflows/lint_golang.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,5 +19,5 @@ jobs:
1919
- name: golangci-lint
2020
uses: golangci/golangci-lint-action@v6
2121
with:
22-
version: v1.63.4
22+
version: v1.64.5
2323
args: --verbose

.golangci.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,11 @@ run:
44
issues:
55
exclude-dirs:
66
- internal/pb
7+
max-issues-per-linter: 0
8+
max-same-issues: 0
79
linters-settings:
810
errcheck:
911
check-blank: false
10-
ignore: fmt:.*,[rR]ead|[wW]rite|[cC]lose,io:Copy
1112
gocritic:
1213
disabled-checks:
1314
- commentFormatting

csv/spec.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package csv
22

33
import (
4-
"fmt"
4+
"errors"
55

66
"github.com/invopop/jsonschema"
77
)
@@ -41,7 +41,7 @@ func (s *CSVSpec) SetDefaults() {
4141

4242
func (s *CSVSpec) Validate() error {
4343
if len(s.Delimiter) != 1 {
44-
return fmt.Errorf("delimiter must be a single character")
44+
return errors.New("delimiter must be a single character")
4545
}
4646
return nil
4747
}

spec.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ package filetypes
33
import (
44
"bytes"
55
"encoding/json"
6+
"errors"
67
"fmt"
78

89
"github.com/cloudquery/filetypes/v4/csv"
@@ -58,7 +59,7 @@ func (s *FileSpec) Validate() error {
5859
return fmt.Errorf("`compression` must be either empty or `%s`", CompressionTypeGZip)
5960
}
6061
if s.Format == "" {
61-
return fmt.Errorf("format is required")
62+
return errors.New("format is required")
6263
}
6364
switch s.Format {
6465
case FormatTypeCSV:
@@ -67,7 +68,7 @@ func (s *FileSpec) Validate() error {
6768
return s.jsonSpec.Validate()
6869
case FormatTypeParquet:
6970
if s.Compression != CompressionTypeNone {
70-
return fmt.Errorf("compression is not supported for parquet format") // This won't work even if we wanted to, because parquet writer prematurely closes the file handle
71+
return errors.New("compression is not supported for parquet format") // This won't work even if we wanted to, because parquet writer prematurely closes the file handle
7172
}
7273

7374
return s.parquetSpec.Validate()

stream_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ package filetypes_test
22

33
import (
44
"bufio"
5-
"fmt"
5+
"errors"
66
"io"
77
"testing"
88

@@ -22,7 +22,7 @@ type uploadHelper struct {
2222
expectAt int
2323
}
2424

25-
var errTest = fmt.Errorf("test error")
25+
var errTest = errors.New("test error")
2626

2727
func (u *uploadHelper) Upload(r io.Reader) error {
2828
s := bufio.NewScanner(r)
@@ -33,7 +33,7 @@ func (u *uploadHelper) Upload(r io.Reader) error {
3333
}
3434
if u.expect != nil && i == u.expectAt {
3535
if !assert.Equal(u.t, u.expect, s.Bytes()) {
36-
return fmt.Errorf("assertion failed")
36+
return errors.New("assertion failed")
3737
}
3838
}
3939
i++

0 commit comments

Comments
 (0)