Fixing string-ref bug in other langs.

Author: dvanhorn

langs/iniquity/compile-ops.rkt

@@ -240,6 +240,8 @@
      (seq (Pop r8)
           (assert-string r8)
           (assert-integer rax)
+          (Cmp r8 type-str)
+          (Je 'raise_error_align) ; special case for empty string
           (Cmp rax 0)
           (Jl 'raise_error_align)
           (Xor r8 type-str)       ; r8 = ptr

langs/iniquity/test/test-runner.rkt

@@ -138,6 +138,8 @@
   (check-equal? (run '(make-string 3 #\g)) "ggg")
   (check-equal? (run '(string-length "")) 0)
   (check-equal? (run '(string-length "fred")) 4)
+  (check-equal? (run '(string-ref "" 0)) 'err)
+  (check-equal? (run '(string-ref (make-string 0 #\a) 0)) 'err)
   (check-equal? (run '(string-ref "fred" 0)) #\f)
   (check-equal? (run '(string-ref "fred" 1)) #\r)
   (check-equal? (run '(string-ref "fred" 2)) #\e)

langs/jig/compile-ops.rkt

@@ -240,6 +240,8 @@
      (seq (Pop r8)
           (assert-string r8)
           (assert-integer rax)
+          (Cmp r8 type-str)
+          (Je 'raise_error_align) ; special case for empty string
           (Cmp rax 0)
           (Jl 'raise_error_align)
           (Xor r8 type-str)       ; r8 = ptr

langs/jig/test/test-runner.rkt

@@ -138,6 +138,8 @@
   (check-equal? (run '(make-string 3 #\g)) "ggg")
   (check-equal? (run '(string-length "")) 0)
   (check-equal? (run '(string-length "fred")) 4)
+  (check-equal? (run '(string-ref "" 0)) 'err)
+  (check-equal? (run '(string-ref (make-string 0 #\a) 0)) 'err)
   (check-equal? (run '(string-ref "fred" 0)) #\f)
   (check-equal? (run '(string-ref "fred" 1)) #\r)
   (check-equal? (run '(string-ref "fred" 2)) #\e)

langs/knock/compile-ops.rkt

@@ -240,6 +240,8 @@
      (seq (Pop r8)
           (assert-string r8)
           (assert-integer rax)
+          (Cmp r8 type-str)
+          (Je 'raise_error_align) ; special case for empty string
           (Cmp rax 0)
           (Jl 'raise_error_align)
           (Xor r8 type-str)       ; r8 = ptr

langs/knock/test/test-runner.rkt

@@ -138,6 +138,8 @@
   (check-equal? (run '(make-string 3 #\g)) "ggg")
   (check-equal? (run '(string-length "")) 0)
   (check-equal? (run '(string-length "fred")) 4)
+  (check-equal? (run '(string-ref "" 0)) 'err)
+  (check-equal? (run '(string-ref (make-string 0 #\a) 0)) 'err)
   (check-equal? (run '(string-ref "fred" 0)) #\f)
   (check-equal? (run '(string-ref "fred" 1)) #\r)
   (check-equal? (run '(string-ref "fred" 2)) #\e)

langs/loot/compile-ops.rkt

@@ -240,6 +240,8 @@
      (seq (Pop r8)
           (assert-string r8)
           (assert-integer rax)
+          (Cmp r8 type-str)
+          (Je 'raise_error_align) ; special case for empty string
           (Cmp rax 0)
           (Jl 'raise_error_align)
           (Xor r8 type-str)       ; r8 = ptr

langs/loot/test/test-runner.rkt

@@ -138,6 +138,8 @@
   (check-equal? (run '(make-string 3 #\g)) "ggg")
   (check-equal? (run '(string-length "")) 0)
   (check-equal? (run '(string-length "fred")) 4)
+  (check-equal? (run '(string-ref "" 0)) 'err)
+  (check-equal? (run '(string-ref (make-string 0 #\a) 0)) 'err)
   (check-equal? (run '(string-ref "fred" 0)) #\f)
   (check-equal? (run '(string-ref "fred" 1)) #\r)
   (check-equal? (run '(string-ref "fred" 2)) #\e)

langs/mountebank/compile-ops.rkt

@@ -281,6 +281,8 @@
      (seq (Pop r8)
           (assert-string r8)
           (assert-integer rax)
+          (Cmp r8 type-str)
+          (Je 'raise_error_align) ; special case for empty string
           (Cmp rax 0)
           (Jl 'raise_error_align)
           (Xor r8 type-str)       ; r8 = ptr

langs/mountebank/test/test-runner.rkt

@@ -138,6 +138,8 @@
   (check-equal? (run '(make-string 3 #\g)) "ggg")
   (check-equal? (run '(string-length "")) 0)
   (check-equal? (run '(string-length "fred")) 4)
+  (check-equal? (run '(string-ref "" 0)) 'err)
+  (check-equal? (run '(string-ref (make-string 0 #\a) 0)) 'err)
   (check-equal? (run '(string-ref "fred" 0)) #\f)
   (check-equal? (run '(string-ref "fred" 1)) #\r)
   (check-equal? (run '(string-ref "fred" 2)) #\e)