From c24e873402226c6eeea85e93eb601f9480e43ced Mon Sep 17 00:00:00 2001 From: Milinda Dias Date: Mon, 24 Nov 2025 19:35:00 +0530 Subject: [PATCH 01/40] step0: add python dependencies --- api/requirements.txt | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) create mode 100644 api/requirements.txt diff --git a/api/requirements.txt b/api/requirements.txt new file mode 100644 index 000000000..850f370e8 --- /dev/null +++ b/api/requirements.txt @@ -0,0 +1,22 @@ +blinker==1.9.0 +click==8.3.1 +coverage==7.12.0 +Flask==3.1.2 +googleapis-common-protos==1.70.0 +grpcio==1.75.1 +grpcio-health-checking==1.75.1 +grpcio-tools==1.75.1 +iniconfig==2.3.0 +itsdangerous==2.2.0 +Jinja2==3.1.6 +MarkupSafe==3.0.3 +packaging==25.0 +pluggy==1.6.0 +protobuf==6.32.1 +Pygments==2.19.2 +pytest==9.0.1 +pytest-cov==7.0.0 +setuptools==80.9.0 +typing_extensions==4.15.0 +Werkzeug==3.1.3 +wheel==0.45.1 From ce33ee6e322a3fe5c7fff77ebf028eb3de637ce3 Mon Sep 17 00:00:00 2001 From: Milinda Dias Date: Mon, 24 Nov 2025 19:41:07 +0530 Subject: [PATCH 02/40] step1: add calculator backend and tests --- api/app.py | 35 +++++++++++++++++++++++++++++++ api/calculator/__init__.py | 0 api/calculator/calculator.py | 14 +++++++++++++ api/calculator/test_calculator.py | 30 ++++++++++++++++++++++++++ 4 files changed, 79 insertions(+) create mode 100644 api/app.py create mode 100644 api/calculator/__init__.py create mode 100644 api/calculator/calculator.py create mode 100644 api/calculator/test_calculator.py diff --git a/api/app.py b/api/app.py new file mode 100644 index 000000000..11f35a759 --- /dev/null +++ b/api/app.py @@ -0,0 +1,35 @@ +from flask import ( + Flask, + request, +) + +from calculator.calculator import Calculator + +app = Flask(__name__) + +@app.route('/api/add', methods=['POST']) +def add(): + return operation('add', 2) + +@app.route('/api/subtract', methods=['POST']) +def subtract(): + return operation('subtract', 2) + +@app.route('/api/multiply', methods=['POST']) +def multiply(): + return operation('multiply', 2) + +@app.route('/api/divide', methods=['POST']) +def divide(): + return operation('divide', 2) + +def operation(method, num_factors): + factors = [] + if num_factors == 2: + factors.append(float(request.json.get('x'))) + factors.append(float(request.json.get('y'))) + + return str(getattr(Calculator, method)(*factors)) + + +app.run(host='0.0.0.0', port=8086) \ No newline at end of file diff --git a/api/calculator/__init__.py b/api/calculator/__init__.py new file mode 100644 index 000000000..e69de29bb diff --git a/api/calculator/calculator.py b/api/calculator/calculator.py new file mode 100644 index 000000000..eac4e7acb --- /dev/null +++ b/api/calculator/calculator.py @@ -0,0 +1,14 @@ +class Calculator: + def add(x, y): + return x + y + + def subtract(x, y): + return x - y + + def multiply(x, y): + return x * y + + def divide(x, y): + if y == 0: + return 'Cannot divide by 0' + return x * 1.0 / y \ No newline at end of file diff --git a/api/calculator/test_calculator.py b/api/calculator/test_calculator.py new file mode 100644 index 000000000..69fa778f1 --- /dev/null +++ b/api/calculator/test_calculator.py @@ -0,0 +1,30 @@ +from .calculator import Calculator + + +def test_add(): + assert Calculator.add(1, 2) == 3.0 + assert Calculator.add(1.0, 2.0) == 3.0 + assert Calculator.add(0, 2.0) == 2.0 + assert Calculator.add(2.0, 0) == 2.0 + assert Calculator.add(-4, 2.0) == -2.0 + +def test_subtract(): + assert Calculator.subtract(1, 2) == -1.0 + assert Calculator.subtract(2, 1) == 1.0 + assert Calculator.subtract(1.0, 2.0) == -1.0 + assert Calculator.subtract(0, 2.0) == -2.0 + assert Calculator.subtract(2.0, 0.0) == 2.0 + assert Calculator.subtract(-4, 2.0) == -6.0 + +def test_multiply(): + assert Calculator.multiply(1, 2) == 2.0 + assert Calculator.multiply(1.0, 2.0) == 2.0 + assert Calculator.multiply(0, 2.0) == 0.0 + assert Calculator.multiply(2.0, 0.0) == 0.0 + assert Calculator.multiply(-4, 2.0) == -8.0 + +def test_divide(): + assert Calculator.divide(1, 2) == 0.5 + assert Calculator.divide(1.0, 2.0) == 0.5 + assert Calculator.divide(0, 2.0) == 0 + assert Calculator.divide(-4, 2.0) == -2.0 \ No newline at end of file From 48d545af9134c15dd494e085d7338e503304f4df Mon Sep 17 00:00:00 2001 From: Milinda Dias Date: Mon, 24 Nov 2025 19:54:36 +0530 Subject: [PATCH 03/40] step2: upload coverage reports to Codecov --- .github/.workflows/api.yml | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) create mode 100644 .github/.workflows/api.yml diff --git a/.github/.workflows/api.yml b/.github/.workflows/api.yml new file mode 100644 index 000000000..9fd271126 --- /dev/null +++ b/.github/.workflows/api.yml @@ -0,0 +1,21 @@ +name: API workflow + +on: [push, pull_request] + +jobs: + build: + runs-on: ubuntu-latest + name: Test python API + steps: + - uses: actions/checkout@v4 + - uses: actions/setup-python@v2 + with: + python-version: '3.10' + - name: Install requirements + run: pip install -r api/requirements.txt + - name: Run tests and collect coverage + run: pytest --cov=api.calculator --cov-report=xml + - name: Upload coverage reports to Codecov with GitHub Action + uses: codecov/codecov-action@v5 + env: + CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} \ No newline at end of file From ad2a31f2d21e3af9a653b4c87a5486c7b352ee25 Mon Sep 17 00:00:00 2001 From: Milinda Dias Date: Mon, 24 Nov 2025 20:04:36 +0530 Subject: [PATCH 04/40] fix: updates --- .github/.workflows/api.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/.workflows/api.yml b/.github/.workflows/api.yml index 9fd271126..565c13eb7 100644 --- a/.github/.workflows/api.yml +++ b/.github/.workflows/api.yml @@ -18,4 +18,4 @@ jobs: - name: Upload coverage reports to Codecov with GitHub Action uses: codecov/codecov-action@v5 env: - CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} \ No newline at end of file + CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} From 54d2248a10ec18a6b35f94260370971cd759cf13 Mon Sep 17 00:00:00 2001 From: Milinda Dias Date: Mon, 24 Nov 2025 20:05:59 +0530 Subject: [PATCH 05/40] fix: updates --- .github/{.workflows => workflows}/api.yml | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename .github/{.workflows => workflows}/api.yml (100%) diff --git a/.github/.workflows/api.yml b/.github/workflows/api.yml similarity index 100% rename from .github/.workflows/api.yml rename to .github/workflows/api.yml From e39d383b34e574619a76778b3af91e09e7ad6caa Mon Sep 17 00:00:00 2001 From: Milinda Dias Date: Mon, 24 Nov 2025 20:08:45 +0530 Subject: [PATCH 06/40] fix: updates --- .github/workflows/api.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/api.yml b/.github/workflows/api.yml index 565c13eb7..fadd5697f 100644 --- a/.github/workflows/api.yml +++ b/.github/workflows/api.yml @@ -19,3 +19,4 @@ jobs: uses: codecov/codecov-action@v5 env: CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} + From edd922f111354504966c048c9a8ef7781763b7f1 Mon Sep 17 00:00:00 2001 From: Milinda Dias Date: Mon, 24 Nov 2025 20:24:15 +0530 Subject: [PATCH 07/40] step3: add project status check target --- codecov.yml | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 codecov.yml diff --git a/codecov.yml b/codecov.yml new file mode 100644 index 000000000..b6ac064fd --- /dev/null +++ b/codecov.yml @@ -0,0 +1,6 @@ +coverage: + status: + project: + default: + target: 100% + threshold: 1% \ No newline at end of file From 948a6fdc79b3167146c25b7cbf3f5f1ccf2695d9 Mon Sep 17 00:00:00 2001 From: Milinda Dias Date: Mon, 24 Nov 2025 20:27:03 +0530 Subject: [PATCH 08/40] added --- api/calculator/test_calculator.py | 36 +++++++++++++++---------------- codecov.yml | 2 +- 2 files changed, 19 insertions(+), 19 deletions(-) diff --git a/api/calculator/test_calculator.py b/api/calculator/test_calculator.py index 69fa778f1..deabbae31 100644 --- a/api/calculator/test_calculator.py +++ b/api/calculator/test_calculator.py @@ -8,23 +8,23 @@ def test_add(): assert Calculator.add(2.0, 0) == 2.0 assert Calculator.add(-4, 2.0) == -2.0 -def test_subtract(): - assert Calculator.subtract(1, 2) == -1.0 - assert Calculator.subtract(2, 1) == 1.0 - assert Calculator.subtract(1.0, 2.0) == -1.0 - assert Calculator.subtract(0, 2.0) == -2.0 - assert Calculator.subtract(2.0, 0.0) == 2.0 - assert Calculator.subtract(-4, 2.0) == -6.0 +# def test_subtract(): +# assert Calculator.subtract(1, 2) == -1.0 +# assert Calculator.subtract(2, 1) == 1.0 +# assert Calculator.subtract(1.0, 2.0) == -1.0 +# assert Calculator.subtract(0, 2.0) == -2.0 +# assert Calculator.subtract(2.0, 0.0) == 2.0 +# assert Calculator.subtract(-4, 2.0) == -6.0 -def test_multiply(): - assert Calculator.multiply(1, 2) == 2.0 - assert Calculator.multiply(1.0, 2.0) == 2.0 - assert Calculator.multiply(0, 2.0) == 0.0 - assert Calculator.multiply(2.0, 0.0) == 0.0 - assert Calculator.multiply(-4, 2.0) == -8.0 +# def test_multiply(): +# assert Calculator.multiply(1, 2) == 2.0 +# assert Calculator.multiply(1.0, 2.0) == 2.0 +# assert Calculator.multiply(0, 2.0) == 0.0 +# assert Calculator.multiply(2.0, 0.0) == 0.0 +# assert Calculator.multiply(-4, 2.0) == -8.0 -def test_divide(): - assert Calculator.divide(1, 2) == 0.5 - assert Calculator.divide(1.0, 2.0) == 0.5 - assert Calculator.divide(0, 2.0) == 0 - assert Calculator.divide(-4, 2.0) == -2.0 \ No newline at end of file +# def test_divide(): +# assert Calculator.divide(1, 2) == 0.5 +# assert Calculator.divide(1.0, 2.0) == 0.5 +# assert Calculator.divide(0, 2.0) == 0 +# assert Calculator.divide(-4, 2.0) == -2.0 \ No newline at end of file diff --git a/codecov.yml b/codecov.yml index b6ac064fd..045842d23 100644 --- a/codecov.yml +++ b/codecov.yml @@ -3,4 +3,4 @@ coverage: project: default: target: 100% - threshold: 1% \ No newline at end of file + threshold: 1% From 979d81a0d600166b2fc181a3a73a7137c614af63 Mon Sep 17 00:00:00 2001 From: Milinda Dias Date: Mon, 24 Nov 2025 20:29:48 +0530 Subject: [PATCH 09/40] fix: updates --- codecov.yml | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/codecov.yml b/codecov.yml index 045842d23..75b61963b 100644 --- a/codecov.yml +++ b/codecov.yml @@ -1,6 +1,10 @@ coverage: + precision: 2 + round: down + range: "95...100" + notify: + # notification blocks. See: https://docs.codecov.io/docs/codecovyml-reference#section-coverage-notify status: project: - default: - target: 100% - threshold: 1% + patch: + changes: \ No newline at end of file From 5fe8158773ea83756c6c4e7947167c062c764a73 Mon Sep 17 00:00:00 2001 From: Milinda Dias Date: Mon, 24 Nov 2025 20:30:44 +0530 Subject: [PATCH 10/40] fix: updates --- codecov.yml | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/codecov.yml b/codecov.yml index 75b61963b..4e265f88a 100644 --- a/codecov.yml +++ b/codecov.yml @@ -1,10 +1,8 @@ coverage: - precision: 2 - round: down - range: "95...100" - notify: - # notification blocks. See: https://docs.codecov.io/docs/codecovyml-reference#section-coverage-notify - status: + status:we rwer werwer project: - patch: - changes: \ No newline at end of file + ewr + werdqwerqwerwer + default: + target: 100% + threshold: 1% From 383d7b60874af13808cbf677c1cb9d511ebae382 Mon Sep 17 00:00:00 2001 From: Milinda Dias Date: Mon, 24 Nov 2025 20:37:25 +0530 Subject: [PATCH 11/40] there --- codecov.yml => codecov.yaml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) rename codecov.yml => codecov.yaml (62%) diff --git a/codecov.yml b/codecov.yaml similarity index 62% rename from codecov.yml rename to codecov.yaml index 4e265f88a..045842d23 100644 --- a/codecov.yml +++ b/codecov.yaml @@ -1,8 +1,6 @@ coverage: - status:we rwer werwer + status: project: - ewr - werdqwerqwerwer default: target: 100% threshold: 1% From 9665f016cf7da1cc103daa977a6cd6408bb6aaf8 Mon Sep 17 00:00:00 2001 From: Milinda Dias Date: Mon, 24 Nov 2025 20:41:36 +0530 Subject: [PATCH 12/40] updates --- codecov.yaml | 6 ------ 1 file changed, 6 deletions(-) delete mode 100644 codecov.yaml diff --git a/codecov.yaml b/codecov.yaml deleted file mode 100644 index 045842d23..000000000 --- a/codecov.yaml +++ /dev/null @@ -1,6 +0,0 @@ -coverage: - status: - project: - default: - target: 100% - threshold: 1% From f10be6322058bc200163321c914d1d2a5e75a87f Mon Sep 17 00:00:00 2001 From: Milinda Dias Date: Mon, 24 Nov 2025 20:42:52 +0530 Subject: [PATCH 13/40] updates --- api/calculator/test_calculator.py | 21 --------------------- codecov.yaml | 6 ++++++ 2 files changed, 6 insertions(+), 21 deletions(-) create mode 100644 codecov.yaml diff --git a/api/calculator/test_calculator.py b/api/calculator/test_calculator.py index deabbae31..c02c2da1a 100644 --- a/api/calculator/test_calculator.py +++ b/api/calculator/test_calculator.py @@ -7,24 +7,3 @@ def test_add(): assert Calculator.add(0, 2.0) == 2.0 assert Calculator.add(2.0, 0) == 2.0 assert Calculator.add(-4, 2.0) == -2.0 - -# def test_subtract(): -# assert Calculator.subtract(1, 2) == -1.0 -# assert Calculator.subtract(2, 1) == 1.0 -# assert Calculator.subtract(1.0, 2.0) == -1.0 -# assert Calculator.subtract(0, 2.0) == -2.0 -# assert Calculator.subtract(2.0, 0.0) == 2.0 -# assert Calculator.subtract(-4, 2.0) == -6.0 - -# def test_multiply(): -# assert Calculator.multiply(1, 2) == 2.0 -# assert Calculator.multiply(1.0, 2.0) == 2.0 -# assert Calculator.multiply(0, 2.0) == 0.0 -# assert Calculator.multiply(2.0, 0.0) == 0.0 -# assert Calculator.multiply(-4, 2.0) == -8.0 - -# def test_divide(): -# assert Calculator.divide(1, 2) == 0.5 -# assert Calculator.divide(1.0, 2.0) == 0.5 -# assert Calculator.divide(0, 2.0) == 0 -# assert Calculator.divide(-4, 2.0) == -2.0 \ No newline at end of file diff --git a/codecov.yaml b/codecov.yaml new file mode 100644 index 000000000..97ec17297 --- /dev/null +++ b/codecov.yaml @@ -0,0 +1,6 @@ +coverage: + status: + project: + default: + target: 100% + threshold: 0% \ No newline at end of file From 52759a81f63f654a5e9e998642a131217a1eb76c Mon Sep 17 00:00:00 2001 From: Milinda Dias Date: Mon, 24 Nov 2025 20:45:32 +0530 Subject: [PATCH 14/40] fix: updates --- api/calculator/test_calculator.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/api/calculator/test_calculator.py b/api/calculator/test_calculator.py index c02c2da1a..467e1d357 100644 --- a/api/calculator/test_calculator.py +++ b/api/calculator/test_calculator.py @@ -1,9 +1,9 @@ from .calculator import Calculator -def test_add(): - assert Calculator.add(1, 2) == 3.0 - assert Calculator.add(1.0, 2.0) == 3.0 - assert Calculator.add(0, 2.0) == 2.0 - assert Calculator.add(2.0, 0) == 2.0 - assert Calculator.add(-4, 2.0) == -2.0 +# def test_add(): +# assert Calculator.add(1, 2) == 3.0 +# assert Calculator.add(1.0, 2.0) == 3.0 +# assert Calculator.add(0, 2.0) == 2.0 +# assert Calculator.add(2.0, 0) == 2.0 +# assert Calculator.add(-4, 2.0) == -2.0 From 73ca5d6e95c9edd0d5433a556058e6eb134baf5d Mon Sep 17 00:00:00 2001 From: Milinda Dias Date: Mon, 24 Nov 2025 20:46:27 +0530 Subject: [PATCH 15/40] updates --- api/calculator/test_calculator.py | 33 +++++++++++++++++++++++++------ 1 file changed, 27 insertions(+), 6 deletions(-) diff --git a/api/calculator/test_calculator.py b/api/calculator/test_calculator.py index 467e1d357..85b612aab 100644 --- a/api/calculator/test_calculator.py +++ b/api/calculator/test_calculator.py @@ -1,9 +1,30 @@ from .calculator import Calculator -# def test_add(): -# assert Calculator.add(1, 2) == 3.0 -# assert Calculator.add(1.0, 2.0) == 3.0 -# assert Calculator.add(0, 2.0) == 2.0 -# assert Calculator.add(2.0, 0) == 2.0 -# assert Calculator.add(-4, 2.0) == -2.0 +def test_add(): + assert Calculator.add(1, 2) == 3.0 + assert Calculator.add(1.0, 2.0) == 3.0 + assert Calculator.add(0, 2.0) == 2.0 + assert Calculator.add(2.0, 0) == 2.0 + assert Calculator.add(-4, 2.0) == -2.0 + +def test_subtract(): + assert Calculator.subtract(1, 2) == -1.0 + assert Calculator.subtract(2, 1) == 1.0 + assert Calculator.subtract(1.0, 2.0) == -1.0 + assert Calculator.subtract(0, 2.0) == -2.0 + assert Calculator.subtract(2.0, 0.0) == 2.0 + assert Calculator.subtract(-4, 2.0) == -6.0 + +# def test_multiply(): +# assert Calculator.multiply(1, 2) == 2.0 +# assert Calculator.multiply(1.0, 2.0) == 2.0 +# assert Calculator.multiply(0, 2.0) == 0.0 +# assert Calculator.multiply(2.0, 0.0) == 0.0 +# assert Calculator.multiply(-4, 2.0) == -8.0 + +# def test_divide(): +# assert Calculator.divide(1, 2) == 0.5 +# assert Calculator.divide(1.0, 2.0) == 0.5 +# assert Calculator.divide(0, 2.0) == 0 +# assert Calculator.divide(-4, 2.0) == -2.0 \ No newline at end of file From 8e20eb0b48e17415d7e150a68855555ea65243db Mon Sep 17 00:00:00 2001 From: Milinda Dias Date: Mon, 24 Nov 2025 20:49:18 +0530 Subject: [PATCH 16/40] fix: updates --- api/calculator/calculator.py | 88 +++++++++++++++++++++++++++++++++++- 1 file changed, 87 insertions(+), 1 deletion(-) diff --git a/api/calculator/calculator.py b/api/calculator/calculator.py index eac4e7acb..b9420afb9 100644 --- a/api/calculator/calculator.py +++ b/api/calculator/calculator.py @@ -11,4 +11,90 @@ def multiply(x, y): def divide(x, y): if y == 0: return 'Cannot divide by 0' - return x * 1.0 / y \ No newline at end of file + return x * 1.0 / y + + def divide1(x, y): + if y == 0: + return 'Cannot divide by 0' + return x * 1.0 / y + + def divide2(x, y): + if y == 0: + return 'Cannot divide by 0' + return x * 1.0 / y + + def divide3(x, y): + if y == 0: + return 'Cannot divide by 0' + return x * 1.0 / y + + def divide4(x, y): + if y == 0: + return 'Cannot divide by 0' + return x * 1.0 / y + + def divide5(x, y): + if y == 0: + return 'Cannot divide by 0' + return x * 1.0 / y + + def divide6(x, y): + if y == 0: + return 'Cannot divide by 0' + return x * 1.0 / y + + def divide7(x, y): + if y == 0: + return 'Cannot divide by 0' + return x * 1.0 / y + + def divide8(x, y): + if y == 0: + return 'Cannot divide by 0' + return x * 1.0 / y + + def divide9(x, y): + if y == 0: + return 'Cannot divide by 0' + return x * 1.0 / y + + def divide10(x, y): + if y == 0: + return 'Cannot divide by 0' + return x * 1.0 / y + + def divide11(x, y): + if y == 0: + return 'Cannot divide by 0' + return x * 1.0 / y + + def divide12(x, y): + if y == 0: + return 'Cannot divide by 0' + return x * 1.0 / y + + def divide13(x, y): + if y == 0: + return 'Cannot divide by 0' + return x * 1.0 / y + + def divide14(x, y): + if y == 0: + return 'Cannot divide by 0' + return x * 1.0 / y + + def divide15(x, y): + if y == 0: + return 'Cannot divide by 0' + return x * 1.0 / y + + def divide16(x, y): + if y == 0: + return 'Cannot divide by 0' + return x * 1.0 / y + + def divide17(x, y): + if y == 0: + return 'Cannot divide by 0' + return x * 1.0 / y + \ No newline at end of file From 0432aa4145c9122cd5c204886996fa965453c1ea Mon Sep 17 00:00:00 2001 From: Milinda Dias Date: Mon, 24 Nov 2025 20:50:34 +0530 Subject: [PATCH 17/40] fix: updates --- codecov.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/codecov.yaml b/codecov.yaml index 97ec17297..a29bd9775 100644 --- a/codecov.yaml +++ b/codecov.yaml @@ -2,5 +2,5 @@ coverage: status: project: default: - target: 100% - threshold: 0% \ No newline at end of file + target: 20% + threshold: 1% \ No newline at end of file From f5a1c5948d6798a6f76eddbffefb7443be51aa10 Mon Sep 17 00:00:00 2001 From: Milinda Dias Date: Mon, 24 Nov 2025 21:18:25 +0530 Subject: [PATCH 18/40] update --- api/calculator/calculator.py | 158 +++++++++++++++++------------------ 1 file changed, 79 insertions(+), 79 deletions(-) diff --git a/api/calculator/calculator.py b/api/calculator/calculator.py index b9420afb9..d72fc3acc 100644 --- a/api/calculator/calculator.py +++ b/api/calculator/calculator.py @@ -18,83 +18,83 @@ def divide1(x, y): return 'Cannot divide by 0' return x * 1.0 / y - def divide2(x, y): - if y == 0: - return 'Cannot divide by 0' - return x * 1.0 / y - - def divide3(x, y): - if y == 0: - return 'Cannot divide by 0' - return x * 1.0 / y - - def divide4(x, y): - if y == 0: - return 'Cannot divide by 0' - return x * 1.0 / y - - def divide5(x, y): - if y == 0: - return 'Cannot divide by 0' - return x * 1.0 / y - - def divide6(x, y): - if y == 0: - return 'Cannot divide by 0' - return x * 1.0 / y - - def divide7(x, y): - if y == 0: - return 'Cannot divide by 0' - return x * 1.0 / y - - def divide8(x, y): - if y == 0: - return 'Cannot divide by 0' - return x * 1.0 / y - - def divide9(x, y): - if y == 0: - return 'Cannot divide by 0' - return x * 1.0 / y - - def divide10(x, y): - if y == 0: - return 'Cannot divide by 0' - return x * 1.0 / y - - def divide11(x, y): - if y == 0: - return 'Cannot divide by 0' - return x * 1.0 / y - - def divide12(x, y): - if y == 0: - return 'Cannot divide by 0' - return x * 1.0 / y - - def divide13(x, y): - if y == 0: - return 'Cannot divide by 0' - return x * 1.0 / y - - def divide14(x, y): - if y == 0: - return 'Cannot divide by 0' - return x * 1.0 / y - - def divide15(x, y): - if y == 0: - return 'Cannot divide by 0' - return x * 1.0 / y - - def divide16(x, y): - if y == 0: - return 'Cannot divide by 0' - return x * 1.0 / y - - def divide17(x, y): - if y == 0: - return 'Cannot divide by 0' - return x * 1.0 / y + # def divide2(x, y): + # if y == 0: + # return 'Cannot divide by 0' + # return x * 1.0 / y + + # def divide3(x, y): + # if y == 0: + # return 'Cannot divide by 0' + # return x * 1.0 / y + + # def divide4(x, y): + # if y == 0: + # return 'Cannot divide by 0' + # return x * 1.0 / y + + # def divide5(x, y): + # if y == 0: + # return 'Cannot divide by 0' + # return x * 1.0 / y + + # def divide6(x, y): + # if y == 0: + # return 'Cannot divide by 0' + # return x * 1.0 / y + + # def divide7(x, y): + # if y == 0: + # return 'Cannot divide by 0' + # return x * 1.0 / y + + # def divide8(x, y): + # if y == 0: + # return 'Cannot divide by 0' + # return x * 1.0 / y + + # def divide9(x, y): + # if y == 0: + # return 'Cannot divide by 0' + # return x * 1.0 / y + + # def divide10(x, y): + # if y == 0: + # return 'Cannot divide by 0' + # return x * 1.0 / y + + # def divide11(x, y): + # if y == 0: + # return 'Cannot divide by 0' + # return x * 1.0 / y + + # def divide12(x, y): + # if y == 0: + # return 'Cannot divide by 0' + # return x * 1.0 / y + + # def divide13(x, y): + # if y == 0: + # return 'Cannot divide by 0' + # return x * 1.0 / y + + # def divide14(x, y): + # if y == 0: + # return 'Cannot divide by 0' + # return x * 1.0 / y + + # def divide15(x, y): + # if y == 0: + # return 'Cannot divide by 0' + # return x * 1.0 / y + + # def divide16(x, y): + # if y == 0: + # return 'Cannot divide by 0' + # return x * 1.0 / y + + # def divide17(x, y): + # if y == 0: + # return 'Cannot divide by 0' + # return x * 1.0 / y \ No newline at end of file From 869b3800d102bb07a0ad539dfd3b0e528c9b0296 Mon Sep 17 00:00:00 2001 From: Milinda Dias Date: Mon, 24 Nov 2025 21:21:18 +0530 Subject: [PATCH 19/40] fix: updates --- api/calculator/calculator.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/api/calculator/calculator.py b/api/calculator/calculator.py index d72fc3acc..d4a7b9c37 100644 --- a/api/calculator/calculator.py +++ b/api/calculator/calculator.py @@ -9,14 +9,14 @@ def multiply(x, y): return x * y def divide(x, y): - if y == 0: - return 'Cannot divide by 0' + # if y == 0: + # return 'Cannot divide by 0' return x * 1.0 / y - def divide1(x, y): - if y == 0: - return 'Cannot divide by 0' - return x * 1.0 / y + # def divide1(x, y): + # if y == 0: + # return 'Cannot divide by 0' + # return x * 1.0 / y # def divide2(x, y): # if y == 0: From 1d1a1d0f131f40a316aaf8fb62f768ee1c9e97a5 Mon Sep 17 00:00:00 2001 From: Milinda Dias Date: Tue, 25 Nov 2025 17:39:35 +0530 Subject: [PATCH 20/40] a --- api/calculator/calculator.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/api/calculator/calculator.py b/api/calculator/calculator.py index d4a7b9c37..a46e06751 100644 --- a/api/calculator/calculator.py +++ b/api/calculator/calculator.py @@ -8,10 +8,10 @@ def subtract(x, y): def multiply(x, y): return x * y - def divide(x, y): - # if y == 0: - # return 'Cannot divide by 0' - return x * 1.0 / y + # def divide(x, y): + # # if y == 0: + # # return 'Cannot divide by 0' + # return x * 1.0 / y # def divide1(x, y): # if y == 0: From a2e432c45384ec53d65b2b3e0bc4775cbb6e11f0 Mon Sep 17 00:00:00 2001 From: Milinda Dias Date: Tue, 25 Nov 2025 17:41:39 +0530 Subject: [PATCH 21/40] added --- api/calculator/calculator.py | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/api/calculator/calculator.py b/api/calculator/calculator.py index a46e06751..d30062874 100644 --- a/api/calculator/calculator.py +++ b/api/calculator/calculator.py @@ -3,14 +3,27 @@ def add(x, y): return x + y def subtract(x, y): + if y == 0: + return 'Cannot divide by 0' + if y == 1: + return 'Cannot subtract 1 from x' + if y == -1: + return 'Cannot subtract -1 from x' + if y == 2: + return 'Cannot subtract 2 from x' + if y == -2: + return 'Cannot subtract -2 from x' + if y == 3: + return 'Cannot subtract 3 from x' + if y == -3: + return 'Cannot subtract -3 from x' return x - y def multiply(x, y): return x * y # def divide(x, y): - # # if y == 0: - # # return 'Cannot divide by 0' + # return x * 1.0 / y # def divide1(x, y): From 90696cdf764bd81a42dd29be14070062e3a5e486 Mon Sep 17 00:00:00 2001 From: Milinda Dias Date: Tue, 25 Nov 2025 17:50:29 +0530 Subject: [PATCH 22/40] updates --- api/calculator/calculator.py | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/api/calculator/calculator.py b/api/calculator/calculator.py index d30062874..a3f31b888 100644 --- a/api/calculator/calculator.py +++ b/api/calculator/calculator.py @@ -3,19 +3,19 @@ def add(x, y): return x + y def subtract(x, y): - if y == 0: + if y == 11110: return 'Cannot divide by 0' - if y == 1: + if y == 11111: return 'Cannot subtract 1 from x' - if y == -1: + if y == -11111: return 'Cannot subtract -1 from x' - if y == 2: + if y == 21111: return 'Cannot subtract 2 from x' - if y == -2: + if y == -11112: return 'Cannot subtract -2 from x' - if y == 3: + if y == 11113: return 'Cannot subtract 3 from x' - if y == -3: + if y == -31111: return 'Cannot subtract -3 from x' return x - y From 1c345e7b85ee545cbb3b5128fac15e68e2fa6d04 Mon Sep 17 00:00:00 2001 From: Milinda Dias Date: Tue, 25 Nov 2025 18:01:58 +0530 Subject: [PATCH 23/40] fix: updates --- codecov.yaml | 6 ------ codecov.yml | 8 ++++++++ 2 files changed, 8 insertions(+), 6 deletions(-) delete mode 100644 codecov.yaml create mode 100644 codecov.yml diff --git a/codecov.yaml b/codecov.yaml deleted file mode 100644 index a29bd9775..000000000 --- a/codecov.yaml +++ /dev/null @@ -1,6 +0,0 @@ -coverage: - status: - project: - default: - target: 20% - threshold: 1% \ No newline at end of file diff --git a/codecov.yml b/codecov.yml new file mode 100644 index 000000000..b6167662f --- /dev/null +++ b/codecov.yml @@ -0,0 +1,8 @@ +coverage: + status: + project: + default: # default is the status check's name, not default settings + target: 2 + threshold: 5 + if_ci_failed: ignore + informational: true \ No newline at end of file From 4205831a45b69e1b8721f89a1b2dbcdf7a980a4e Mon Sep 17 00:00:00 2001 From: Milinda Dias Date: Tue, 25 Nov 2025 18:03:47 +0530 Subject: [PATCH 24/40] updates --- codecov.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/codecov.yml b/codecov.yml index b6167662f..663cdfdf0 100644 --- a/codecov.yml +++ b/codecov.yml @@ -4,5 +4,5 @@ coverage: default: # default is the status check's name, not default settings target: 2 threshold: 5 - if_ci_failed: ignore + if_ci_failed: error informational: true \ No newline at end of file From 9dbe308ad7967608408f3c83b279e38d8d844782 Mon Sep 17 00:00:00 2001 From: Milinda Dias Date: Tue, 25 Nov 2025 18:05:36 +0530 Subject: [PATCH 25/40] updates --- codecov.yaml | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/codecov.yaml b/codecov.yaml index a29bd9775..663cdfdf0 100644 --- a/codecov.yaml +++ b/codecov.yaml @@ -1,6 +1,8 @@ coverage: status: project: - default: - target: 20% - threshold: 1% \ No newline at end of file + default: # default is the status check's name, not default settings + target: 2 + threshold: 5 + if_ci_failed: error + informational: true \ No newline at end of file From 800830d5d379580af53d7660c8ceec32b7ba5c81 Mon Sep 17 00:00:00 2001 From: Milinda Dias Date: Tue, 25 Nov 2025 18:08:56 +0530 Subject: [PATCH 26/40] fix: updates --- api/calculator/test_calculator.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/api/calculator/test_calculator.py b/api/calculator/test_calculator.py index 85b612aab..a3deccccb 100644 --- a/api/calculator/test_calculator.py +++ b/api/calculator/test_calculator.py @@ -1,12 +1,12 @@ from .calculator import Calculator -def test_add(): - assert Calculator.add(1, 2) == 3.0 - assert Calculator.add(1.0, 2.0) == 3.0 - assert Calculator.add(0, 2.0) == 2.0 - assert Calculator.add(2.0, 0) == 2.0 - assert Calculator.add(-4, 2.0) == -2.0 +# def test_add(): +# assert Calculator.add(1, 2) == 3.0 +# assert Calculator.add(1.0, 2.0) == 3.0 +# assert Calculator.add(0, 2.0) == 2.0 +# assert Calculator.add(2.0, 0) == 2.0 +# assert Calculator.add(-4, 2.0) == -2.0 def test_subtract(): assert Calculator.subtract(1, 2) == -1.0 From f5e360e31ba771b44d7aacf6e7222564bcd2df96 Mon Sep 17 00:00:00 2001 From: Milinda Dias Date: Tue, 25 Nov 2025 18:12:17 +0530 Subject: [PATCH 27/40] aaa --- codecov.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/codecov.yaml b/codecov.yaml index 663cdfdf0..b6167662f 100644 --- a/codecov.yaml +++ b/codecov.yaml @@ -4,5 +4,5 @@ coverage: default: # default is the status check's name, not default settings target: 2 threshold: 5 - if_ci_failed: error + if_ci_failed: ignore informational: true \ No newline at end of file From 89984e3a73a81d72e38ad26cecbc71cafa60d338 Mon Sep 17 00:00:00 2001 From: Milinda Dias Date: Tue, 25 Nov 2025 18:12:56 +0530 Subject: [PATCH 28/40] aa --- api/calculator/test_calculator.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/api/calculator/test_calculator.py b/api/calculator/test_calculator.py index a3deccccb..9f6930d59 100644 --- a/api/calculator/test_calculator.py +++ b/api/calculator/test_calculator.py @@ -9,11 +9,11 @@ # assert Calculator.add(-4, 2.0) == -2.0 def test_subtract(): - assert Calculator.subtract(1, 2) == -1.0 - assert Calculator.subtract(2, 1) == 1.0 - assert Calculator.subtract(1.0, 2.0) == -1.0 - assert Calculator.subtract(0, 2.0) == -2.0 - assert Calculator.subtract(2.0, 0.0) == 2.0 + # assert Calculator.subtract(1, 2) == -1.0 + # assert Calculator.subtract(2, 1) == 1.0 + # assert Calculator.subtract(1.0, 2.0) == -1.0 + # assert Calculator.subtract(0, 2.0) == -2.0 + # assert Calculator.subtract(2.0, 0.0) == 2.0 assert Calculator.subtract(-4, 2.0) == -6.0 # def test_multiply(): From 62ee5e18c125904f29026f84544d547ad519e4ce Mon Sep 17 00:00:00 2001 From: Milinda Dias Date: Tue, 25 Nov 2025 18:15:04 +0530 Subject: [PATCH 29/40] aa --- codecov.yaml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/codecov.yaml b/codecov.yaml index b6167662f..d1c44353a 100644 --- a/codecov.yaml +++ b/codecov.yaml @@ -1,8 +1,9 @@ coverage: status: - project: + patch: default: # default is the status check's name, not default settings target: 2 threshold: 5 if_ci_failed: ignore - informational: true \ No newline at end of file + informational: true + From ff666b16ac802ab5a28f9cb8b8927967c946683e Mon Sep 17 00:00:00 2001 From: Milinda Dias Date: Tue, 25 Nov 2025 18:16:45 +0530 Subject: [PATCH 30/40] updates --- codecov.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/codecov.yaml b/codecov.yaml index d1c44353a..9da35c101 100644 --- a/codecov.yaml +++ b/codecov.yaml @@ -2,8 +2,8 @@ coverage: status: patch: default: # default is the status check's name, not default settings - target: 2 + target: 90 threshold: 5 - if_ci_failed: ignore + if_ci_failed: success informational: true From 71a58c206d8854e75a96a4ac4ed26307023ac15f Mon Sep 17 00:00:00 2001 From: Milinda Dias Date: Tue, 25 Nov 2025 18:17:32 +0530 Subject: [PATCH 31/40] updates --- codecov.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/codecov.yaml b/codecov.yaml index 9da35c101..4692619a5 100644 --- a/codecov.yaml +++ b/codecov.yaml @@ -4,6 +4,6 @@ coverage: default: # default is the status check's name, not default settings target: 90 threshold: 5 - if_ci_failed: success + if_ci_failed: error informational: true From 9402d651a0af1c98a0510db125b926f1082a7432 Mon Sep 17 00:00:00 2001 From: Milinda Dias Date: Tue, 25 Nov 2025 18:18:44 +0530 Subject: [PATCH 32/40] aa --- api/calculator/test_calculator.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/api/calculator/test_calculator.py b/api/calculator/test_calculator.py index 9f6930d59..8fc6ef351 100644 --- a/api/calculator/test_calculator.py +++ b/api/calculator/test_calculator.py @@ -3,7 +3,7 @@ # def test_add(): # assert Calculator.add(1, 2) == 3.0 -# assert Calculator.add(1.0, 2.0) == 3.0 + assert Calculator.add(1.0, 2.0) == 3.0 # assert Calculator.add(0, 2.0) == 2.0 # assert Calculator.add(2.0, 0) == 2.0 # assert Calculator.add(-4, 2.0) == -2.0 From 11a0d4dea3af88e3fabc44e59ccf262d46585a79 Mon Sep 17 00:00:00 2001 From: Milinda Dias Date: Tue, 25 Nov 2025 18:19:24 +0530 Subject: [PATCH 33/40] a --- api/calculator/test_calculator.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/api/calculator/test_calculator.py b/api/calculator/test_calculator.py index 8fc6ef351..09fafa584 100644 --- a/api/calculator/test_calculator.py +++ b/api/calculator/test_calculator.py @@ -1,7 +1,7 @@ from .calculator import Calculator -# def test_add(): +def test_add(): # assert Calculator.add(1, 2) == 3.0 assert Calculator.add(1.0, 2.0) == 3.0 # assert Calculator.add(0, 2.0) == 2.0 From 165b8bf26d9b22a4f62289d9f923ff55e62678d5 Mon Sep 17 00:00:00 2001 From: Milinda Dias Date: Tue, 25 Nov 2025 18:21:05 +0530 Subject: [PATCH 34/40] aa --- codecov.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/codecov.yaml b/codecov.yaml index 4692619a5..64841988e 100644 --- a/codecov.yaml +++ b/codecov.yaml @@ -5,5 +5,5 @@ coverage: target: 90 threshold: 5 if_ci_failed: error - informational: true + informational: false From 36c4133656f307da477f4f6cf31aa5a8c869323d Mon Sep 17 00:00:00 2001 From: Milinda Dias Date: Tue, 25 Nov 2025 18:22:08 +0530 Subject: [PATCH 35/40] aa --- codecov.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/codecov.yaml b/codecov.yaml index 64841988e..c9d28d44c 100644 --- a/codecov.yaml +++ b/codecov.yaml @@ -4,6 +4,6 @@ coverage: default: # default is the status check's name, not default settings target: 90 threshold: 5 - if_ci_failed: error + if_ci_failed: success informational: false From fa43e8ce16ee4607621297faf7d612e9076b5634 Mon Sep 17 00:00:00 2001 From: Milinda Dias Date: Tue, 25 Nov 2025 18:23:40 +0530 Subject: [PATCH 36/40] aeaeae --- codecov.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/codecov.yaml b/codecov.yaml index c9d28d44c..a86a0d738 100644 --- a/codecov.yaml +++ b/codecov.yaml @@ -4,6 +4,6 @@ coverage: default: # default is the status check's name, not default settings target: 90 threshold: 5 - if_ci_failed: success + if_ci_failed: ignore informational: false From 72576e8280c454d17711097d6c461d4e3dca0f18 Mon Sep 17 00:00:00 2001 From: Milinda Dias Date: Tue, 25 Nov 2025 18:25:00 +0530 Subject: [PATCH 37/40] updates --- codecov.yaml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/codecov.yaml b/codecov.yaml index a86a0d738..88a7de1ae 100644 --- a/codecov.yaml +++ b/codecov.yaml @@ -4,6 +4,5 @@ coverage: default: # default is the status check's name, not default settings target: 90 threshold: 5 - if_ci_failed: ignore - informational: false + informational: true From bed4495cfe75ff677045ef229144e2d1eba53f4c Mon Sep 17 00:00:00 2001 From: Milinda Dias Date: Tue, 25 Nov 2025 18:25:56 +0530 Subject: [PATCH 38/40] fix: updates --- api/calculator/test_calculator.py | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/api/calculator/test_calculator.py b/api/calculator/test_calculator.py index 09fafa584..e06379b4a 100644 --- a/api/calculator/test_calculator.py +++ b/api/calculator/test_calculator.py @@ -2,26 +2,26 @@ def test_add(): -# assert Calculator.add(1, 2) == 3.0 + assert Calculator.add(1, 2) == 3.0 assert Calculator.add(1.0, 2.0) == 3.0 -# assert Calculator.add(0, 2.0) == 2.0 -# assert Calculator.add(2.0, 0) == 2.0 -# assert Calculator.add(-4, 2.0) == -2.0 + assert Calculator.add(0, 2.0) == 2.0 + assert Calculator.add(2.0, 0) == 2.0 + assert Calculator.add(-4, 2.0) == -2.0 def test_subtract(): - # assert Calculator.subtract(1, 2) == -1.0 - # assert Calculator.subtract(2, 1) == 1.0 - # assert Calculator.subtract(1.0, 2.0) == -1.0 - # assert Calculator.subtract(0, 2.0) == -2.0 - # assert Calculator.subtract(2.0, 0.0) == 2.0 + assert Calculator.subtract(1, 2) == -1.0 + assert Calculator.subtract(2, 1) == 1.0 + assert Calculator.subtract(1.0, 2.0) == -1.0 + assert Calculator.subtract(0, 2.0) == -2.0 + assert Calculator.subtract(2.0, 0.0) == 2.0 assert Calculator.subtract(-4, 2.0) == -6.0 -# def test_multiply(): -# assert Calculator.multiply(1, 2) == 2.0 -# assert Calculator.multiply(1.0, 2.0) == 2.0 -# assert Calculator.multiply(0, 2.0) == 0.0 -# assert Calculator.multiply(2.0, 0.0) == 0.0 -# assert Calculator.multiply(-4, 2.0) == -8.0 +def test_multiply(): + assert Calculator.multiply(1, 2) == 2.0 + assert Calculator.multiply(1.0, 2.0) == 2.0 + assert Calculator.multiply(0, 2.0) == 0.0 + assert Calculator.multiply(2.0, 0.0) == 0.0 + assert Calculator.multiply(-4, 2.0) == -8.0 # def test_divide(): # assert Calculator.divide(1, 2) == 0.5 From cde5a8e15d1e5e009a5054ce182a84ae706c5894 Mon Sep 17 00:00:00 2001 From: Milinda Dias Date: Tue, 25 Nov 2025 18:27:46 +0530 Subject: [PATCH 39/40] updates --- api/calculator/test_calculator.py | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/api/calculator/test_calculator.py b/api/calculator/test_calculator.py index e06379b4a..512b83c57 100644 --- a/api/calculator/test_calculator.py +++ b/api/calculator/test_calculator.py @@ -9,12 +9,22 @@ def test_add(): assert Calculator.add(-4, 2.0) == -2.0 def test_subtract(): + # Test normal subtraction cases assert Calculator.subtract(1, 2) == -1.0 assert Calculator.subtract(2, 1) == 1.0 assert Calculator.subtract(1.0, 2.0) == -1.0 assert Calculator.subtract(0, 2.0) == -2.0 assert Calculator.subtract(2.0, 0.0) == 2.0 assert Calculator.subtract(-4, 2.0) == -6.0 + + # Test special error cases + assert Calculator.subtract(10, 11110) == 'Cannot divide by 0' + assert Calculator.subtract(5, 11111) == 'Cannot subtract 1 from x' + assert Calculator.subtract(5, -11111) == 'Cannot subtract -1 from x' + assert Calculator.subtract(5, 21111) == 'Cannot subtract 2 from x' + assert Calculator.subtract(5, -11112) == 'Cannot subtract -2 from x' + assert Calculator.subtract(5, 11113) == 'Cannot subtract 3 from x' + assert Calculator.subtract(5, -31111) == 'Cannot subtract -3 from x' def test_multiply(): assert Calculator.multiply(1, 2) == 2.0 From 9f2863e99b92faa62d933f1d595e37e1815da5c0 Mon Sep 17 00:00:00 2001 From: Milinda Dias Date: Tue, 25 Nov 2025 18:36:05 +0530 Subject: [PATCH 40/40] aaeaweawe --- api/calculator/calculator.py | 1 + api/calculator/test_calculator.py | 1 + 2 files changed, 2 insertions(+) diff --git a/api/calculator/calculator.py b/api/calculator/calculator.py index a3f31b888..76cd1b720 100644 --- a/api/calculator/calculator.py +++ b/api/calculator/calculator.py @@ -22,6 +22,7 @@ def subtract(x, y): def multiply(x, y): return x * y +# There # def divide(x, y): # return x * 1.0 / y diff --git a/api/calculator/test_calculator.py b/api/calculator/test_calculator.py index 512b83c57..7a5e4ba2c 100644 --- a/api/calculator/test_calculator.py +++ b/api/calculator/test_calculator.py @@ -33,6 +33,7 @@ def test_multiply(): assert Calculator.multiply(2.0, 0.0) == 0.0 assert Calculator.multiply(-4, 2.0) == -8.0 +#There # def test_divide(): # assert Calculator.divide(1, 2) == 0.5 # assert Calculator.divide(1.0, 2.0) == 0.5