Better exception

lyrixx · lyrixx · commit 5a7db86471b1 · 2025-06-11T14:20:24.000+02:00
diff --git a/src/SPC/store/Downloader.php b/src/SPC/store/Downloader.php
@@ -537,10 +537,10 @@ public static function curlExec(string $url, string $method = 'GET', array $head
             }
             f_exec($cmd, $output, $ret);
             if ($ret === 2 || $ret === -1073741510) {
-                throw new RuntimeException('failed http fetch');
+                throw new RuntimeException(sprintf('Failed to fetch "%s"', $url));
             }
             if ($ret !== 0) {
-                throw new DownloaderException('failed http fetch');
+                throw new DownloaderException(sprintf('Failed to fetch "%s"', $url));
             }
             $cache[$cmd]['cache'] = implode("\n", $output);
             $cache[$cmd]['expire'] = time() + 3600;
@@ -549,10 +549,10 @@ public static function curlExec(string $url, string $method = 'GET', array $head
         }
         f_exec($cmd, $output, $ret);
         if ($ret === 2 || $ret === -1073741510) {
-            throw new RuntimeException('failed http fetch');
+            throw new RuntimeException(sprintf('Failed to fetch "%s"', $url));
         }
         if ($ret !== 0) {
-            throw new DownloaderException('failed http fetch');
+            throw new DownloaderException(sprintf('Failed to fetch "%s"', $url));
         }
         return implode("\n", $output);
     }

Original file line number	Diff line number	Diff line change
`@@ -537,10 +537,10 @@ public static function curlExec(string $url, string $method = 'GET', array $head`
`537`	`537`	`}`
`538`	`538`	`f_exec($cmd, $output, $ret);`
`539`	`539`	`if ($ret === 2 \|\| $ret === -1073741510) {`
`540`		`- throw new RuntimeException('failed http fetch');`
	`540`	`+ throw new RuntimeException(sprintf('Failed to fetch "%s"', $url));`
`541`	`541`	`}`
`542`	`542`	`if ($ret !== 0) {`
`543`		`- throw new DownloaderException('failed http fetch');`
	`543`	`+ throw new DownloaderException(sprintf('Failed to fetch "%s"', $url));`
`544`	`544`	`}`
`545`	`545`	`$cache[$cmd]['cache'] = implode("\n", $output);`
`546`	`546`	`$cache[$cmd]['expire'] = time() + 3600;`
`@@ -549,10 +549,10 @@ public static function curlExec(string $url, string $method = 'GET', array $head`
`549`	`549`	`}`
`550`	`550`	`f_exec($cmd, $output, $ret);`
`551`	`551`	`if ($ret === 2 \|\| $ret === -1073741510) {`
`552`		`- throw new RuntimeException('failed http fetch');`
	`552`	`+ throw new RuntimeException(sprintf('Failed to fetch "%s"', $url));`
`553`	`553`	`}`
`554`	`554`	`if ($ret !== 0) {`
`555`		`- throw new DownloaderException('failed http fetch');`
	`555`	`+ throw new DownloaderException(sprintf('Failed to fetch "%s"', $url));`
`556`	`556`	`}`
`557`	`557`	`return implode("\n", $output);`
`558`	`558`	`}`