Skip to content
This repository was archived by the owner on Oct 13, 2023. It is now read-only.

Commit 5c084b5

Browse files
committed
integration-cli: Skip TestAPIImagesSaveAndLoad on RS3 and older
I've seen this test fail a number of times recently on RS1 Looking at failures, the test is taking a long time ro run (491.77s, which is more than 8 minutes), so perhaps it's just too slow on RS1, which may be because we switch to a different base image, or because we're now running on different machines. Compared to RS5 (still slow, but a lot faster); ``` --- PASS: Test/DockerSuite/TestAPIImagesSaveAndLoad (146.25s) ``` ``` --- FAIL: Test/DockerSuite/TestAPIImagesSaveAndLoad (491.77s) cli.go:45: assertion failed: Command: d:\CI-5\CI-93d2cf881\binary\docker.exe inspect --format {{.Id}} sha256:69e7c1ff23be5648c494294a3808c0ea3f78616fad67bfe3b10d3a7e2be5ff02 ExitCode: 1 Error: exit status 1 Stdout: Stderr: Error: No such object: sha256:69e7c1ff23be5648c494294a3808c0ea3f78616fad67bfe3b10d3a7e2be5ff02 Failures: ExitCode was 1 expected 0 Expected no error ``` Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 5adaf52953476bf0ff612c8d78500e35821035bb) Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Upstream-commit: 35e9ee82a6a62b755941a8236856eec84c8b5ea3 Component: engine
1 parent ce32ecd commit 5c084b5

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

components/engine/integration-cli/docker_api_images_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,8 @@ func (s *DockerSuite) TestAPIImagesSaveAndLoad(c *check.C) {
6262
v, err := kernel.GetKernelVersion()
6363
assert.NilError(c, err)
6464
build, _ := strconv.Atoi(strings.Split(strings.SplitN(v.String(), " ", 3)[2][1:], ".")[0])
65-
if build == 16299 {
66-
c.Skip("Temporarily disabled on RS3 builds")
65+
if build <= 16299 {
66+
c.Skip("Temporarily disabled on RS3 and older because they are too slow. See #39909")
6767
}
6868
}
6969

0 commit comments

Comments
 (0)