Skip to content
This repository was archived by the owner on Oct 13, 2023. It is now read-only.

Commit 8c2fe36

Browse files
committed
Windows: skip flaky TestLogBlocking
This test frequently fails on Windows RS1 (mainly), so skipping it for now on Windows; ``` ok github.com/docker/docker/daemon/logger 0.525s coverage: 43.0% of statements time="2019-09-09T20:37:35Z" level=info msg="Trying to get region from EC2 Metadata" time="2019-09-09T20:37:36Z" level=info msg="Log stream already exists" errorCode=ResourceAlreadyExistsException logGroupName= logStreamName= message= origError="<nil>" --- FAIL: TestLogBlocking (0.02s) cloudwatchlogs_test.go:313: Expected to be able to read from stream.messages but was unable to time="2019-09-09T20:37:36Z" level=error msg=Error time="2019-09-09T20:37:36Z" level=error msg="Failed to put log events" errorCode=InvalidSequenceTokenException logGroupName=groupName logStreamName=streamName message="use token token" origError="<nil>" time="2019-09-09T20:37:36Z" level=error msg="Failed to put log events" errorCode=DataAlreadyAcceptedException logGroupName=groupName logStreamName=streamName message="use token token" origError="<nil>" time="2019-09-09T20:37:36Z" level=info msg="Data already accepted, ignoring error" errorCode=DataAlreadyAcceptedException logGroupName=groupName logStreamName=streamName message="use token token" FAIL coverage: 78.2% of statements FAIL github.com/docker/docker/daemon/logger/awslogs 0.630s ``` Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 6c75c862403c98138ab0f7811f6ba9113f9e5d61) Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Upstream-commit: de3a04a65d64c31f275452c604b3a2d02a39c76d Component: engine
1 parent d8cf492 commit 8c2fe36

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

components/engine/daemon/logger/awslogs/cloudwatchlogs_test.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ import (
2424
"github.com/docker/docker/dockerversion"
2525
"gotest.tools/assert"
2626
is "gotest.tools/assert/cmp"
27+
"gotest.tools/skip"
2728
)
2829

2930
const (
@@ -286,6 +287,7 @@ func TestLogClosed(t *testing.T) {
286287
}
287288

288289
func TestLogBlocking(t *testing.T) {
290+
skip.If(t, runtime.GOOS == "windows", "FIXME: test is flaky on Windows. See #39857")
289291
mockClient := newMockClient()
290292
stream := &logStream{
291293
client: mockClient,

0 commit comments

Comments
 (0)