plugin: fix a double RLock bug

lzhfromustc · thaJeztah · commit 9f4029e6dc40 · 2020-07-28T09:28:25.000+02:00
Signed-off-by: Ziheng Liu &lt;lzhfromustc@gmail.com&gt;
(cherry picked from commit 34837febc42859f7e8804a3417db133c963e38b3)
Signed-off-by: Sebastiaan van Stijn &lt;github@gone.nl&gt;
Upstream-commit: 32366de5f982b85ff8fc8e32d3afadbcc540cf13
Component: engine
diff --git a/components/engine/plugin/store.go b/components/engine/plugin/store.go
@@ -188,9 +188,7 @@ func (ps *Store) GetAllByCap(capability string) ([]plugingetter.CompatPlugin, er
 	 * bypassing the daemon. For such tests, this check is necessary.
 	 */
 	if ps != nil {
-		ps.RLock()
 		result = ps.getAllByCap(capability)
-		ps.RUnlock()
 	}
 
 	// Lookup with legacy model

Original file line number	Diff line number	Diff line change
`@@ -188,9 +188,7 @@ func (ps *Store) GetAllByCap(capability string) ([]plugingetter.CompatPlugin, er`
`188`	`188`	`* bypassing the daemon. For such tests, this check is necessary.`
`189`	`189`	`*/`
`190`	`190`	`if ps != nil {`
`191`		`- ps.RLock()`
`192`	`191`	`result = ps.getAllByCap(capability)`
`193`		`- ps.RUnlock()`
`194`	`192`	`}`
`195`	`193`
`196`	`194`	`// Lookup with legacy model`