Skip to content
This repository was archived by the owner on Oct 13, 2023. It is now read-only.

Commit 9ff792b

Browse files
Add a new Makefile variable to override DockerInDocker engine version we use to run e2e tests
Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com> (cherry picked from commit 15d6565e49f8bdfc589ff0e0884059a9d790cdc5) Upstream-commit: 95df3499bb11c092240d51df22b4bd69bae020ba Component: cli
1 parent ddc55e5 commit 9ff792b

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

components/cli/docker.Makefile

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,13 @@ LINTER_IMAGE_NAME = docker-cli-lint$(IMAGE_TAG)
1616
CROSS_IMAGE_NAME = docker-cli-cross$(IMAGE_TAG)
1717
VALIDATE_IMAGE_NAME = docker-cli-shell-validate$(IMAGE_TAG)
1818
E2E_IMAGE_NAME = docker-cli-e2e$(IMAGE_TAG)
19+
E2E_ENGINE_VERSION ?=
1920
CACHE_VOLUME_NAME := docker-cli-dev-cache
2021
ifeq ($(DOCKER_CLI_GO_BUILD_CACHE),y)
2122
DOCKER_CLI_MOUNTS += -v "$(CACHE_VOLUME_NAME):/root/.cache/go-build"
2223
endif
2324
VERSION = $(shell cat VERSION)
24-
ENVVARS = -e VERSION=$(VERSION) -e GITCOMMIT -e PLATFORM -e TESTFLAGS -e TESTDIRS -e GOOS -e GOARCH -e GOARM
25+
ENVVARS = -e VERSION=$(VERSION) -e GITCOMMIT -e PLATFORM -e TESTFLAGS -e TESTDIRS -e GOOS -e GOARCH -e GOARM -e TEST_ENGINE_VERSION=$(E2E_ENGINE_VERSION)
2526

2627
# build docker image (dockerfiles/Dockerfile.build)
2728
.PHONY: build_docker_image
@@ -145,7 +146,7 @@ test-e2e-experimental: build_e2e_image # run experimental e2e tests
145146

146147
.PHONY: test-e2e-non-experimental
147148
test-e2e-non-experimental: build_e2e_image # run non-experimental e2e tests
148-
docker run --rm -v /var/run/docker.sock:/var/run/docker.sock $(ENVVARS) $(E2E_IMAGE_NAME)
149+
docker run --rm -v /var/run/docker.sock:/var/run/docker.sock $(ENVVARS) -e TEST_ENGINE_VERSION=$(E2E_ENGINE_VERSION) $(E2E_IMAGE_NAME)
149150

150151
.PHONY: test-e2e-connhelper-ssh
151152
test-e2e-connhelper-ssh: build_e2e_image # run experimental SSH-connection helper e2e tests

0 commit comments

Comments
 (0)