Skip to content

Commit 6fe2178

Browse files
authored
Preserve filenames when importing items (#1332)
Preserving filenames when importing items by populting filename field for SimpleMediaItem
1 parent 8dc02fe commit 6fe2178

File tree

4 files changed

+9
-5
lines changed

4 files changed

+9
-5
lines changed

extensions/data-transfer/portability-data-transfer-google/src/main/java/org/datatransferproject/datatransfer/google/media/GoogleMediaImporter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,7 @@ private long importPhotoBatch(
222222
String uploadToken = getOrCreatePhotosInterface(jobId, authData).uploadMediaContent(s,
223223
photo.getSha1());
224224
String description = GooglePhotosImportUtils.cleanDescription(photo.getDescription());
225-
mediaItems.add(new NewMediaItem(description, uploadToken));
225+
mediaItems.add(new NewMediaItem(description, uploadToken, photo.getTitle()));
226226
uploadTokenToDataId.put(uploadToken, photo);
227227
size = streamWrapper.getBytes();
228228
uploadTokenToLength.put(uploadToken, size);

extensions/data-transfer/portability-data-transfer-google/src/main/java/org/datatransferproject/datatransfer/google/mediaModels/NewMediaItem.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,9 @@ public NewMediaItem(String description, SimpleMediaItem simpleMediaItem) {
4141
this.simpleMediaItem = simpleMediaItem;
4242
}
4343

44-
public NewMediaItem(String description, String uploadToken) {
44+
public NewMediaItem(String description, String uploadToken, String fileName) {
4545
this.description = description;
46-
this.simpleMediaItem = new SimpleMediaItem(uploadToken);
46+
this.simpleMediaItem = new SimpleMediaItem(uploadToken, fileName);
4747
}
4848

4949
public SimpleMediaItem getSimpleMediaItem() {

extensions/data-transfer/portability-data-transfer-google/src/main/java/org/datatransferproject/datatransfer/google/mediaModels/SimpleMediaItem.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,12 @@ public class SimpleMediaItem {
2626
@JsonProperty("uploadToken")
2727
private String uploadToken;
2828

29-
SimpleMediaItem(String uploadToken) {
29+
@JsonProperty("fileName")
30+
private String fileName;
31+
32+
SimpleMediaItem(String uploadToken, String fileName) {
3033
this.uploadToken = uploadToken;
34+
this.fileName = fileName;
3135
}
3236

3337
public String getUploadToken() {

extensions/data-transfer/portability-data-transfer-google/src/main/java/org/datatransferproject/datatransfer/google/photos/GooglePhotosImporter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -237,7 +237,7 @@ private long importPhotoBatch(
237237
String uploadToken = getOrCreatePhotosInterface(jobId, authData).uploadMediaContent(s,
238238
photo.getSha1());
239239
String description = GooglePhotosImportUtils.cleanDescription(photo.getDescription());
240-
mediaItems.add(new NewMediaItem(description, uploadToken));
240+
mediaItems.add(new NewMediaItem(description, uploadToken, photo.getTitle()));
241241
uploadTokenToDataId.put(uploadToken, photo);
242242
size = streamWrapper.getBytes();
243243
uploadTokenToLength.put(uploadToken, size);

0 commit comments

Comments
 (0)