Skip to content

Commit 119fc47

Browse files
committed
Submodule sanity is a requirement
1 parent a034652 commit 119fc47

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

.github/workflows/on_pr.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ jobs:
4141
4242
packaging_test:
4343
name: Build a minimal set of packages and run all tests on them
44+
needs: ensure_submodule_sanity
4445
# Skip packaging tests for draft PRs
4546
if: ${{ github.event_name != 'pull_request' || github.event.pull_request.draft == false }}
4647
uses: ./.github/workflows/packaging.yml
@@ -51,7 +52,9 @@ jobs:
5152

5253
coverage_test:
5354
name: Run coverage tests
54-
if: ${{ github.event_name != 'pull_request' || github.event.pull_request.draft == false }}
55+
needs: ensure_submodule_sanity
56+
# Only run coverage test for draft PRs
57+
if: ${{ github.event_name == 'pull_request' && github.event.pull_request.draft == true }}
5558
uses: ./.github/workflows/coverage.yml
5659
with:
5760
duckdb_git_ref: ${{ github.base_ref }}

0 commit comments

Comments
 (0)