Catch exceptions in OPTIONAL filters in Arrow scans

evertlammerts · evertlammerts · commit 1f54f8c9a81a · 2026-03-18T14:47:41.000+01:00
diff --git a/src/duckdb_py/arrow/pyarrow_filter_pushdown.cpp b/src/duckdb_py/arrow/pyarrow_filter_pushdown.cpp
@@ -287,7 +287,11 @@ py::object TransformFilterRecursive(TableFilter &filter, vector<string> column_r
 		if (!optional_filter.child_filter) {
 			return py::none();
 		}
-		return TransformFilterRecursive(*optional_filter.child_filter, column_ref, timezone_config, type);
+		try {
+			return TransformFilterRecursive(*optional_filter.child_filter, column_ref, timezone_config, type);
+		} catch (const NotImplementedException &) {
+			return py::none();
+		}
 	}
 	case TableFilterType::IN_FILTER: {
 		auto &in_filter = filter.Cast<InFilter>();

Original file line number	Diff line number	Diff line change
`@@ -287,7 +287,11 @@ py::object TransformFilterRecursive(TableFilter &filter, vector<string> column_r`
`287`	`287`	`if (!optional_filter.child_filter) {`
`288`	`288`	`return py::none();`
`289`	`289`	`}`
`290`		`- return TransformFilterRecursive(*optional_filter.child_filter, column_ref, timezone_config, type);`
	`290`	`+ try {`
	`291`	`+ return TransformFilterRecursive(*optional_filter.child_filter, column_ref, timezone_config, type);`
	`292`	`+ } catch (const NotImplementedException &) {`
	`293`	`+ return py::none();`
	`294`	`+ }`
`291`	`295`	`}`
`292`	`296`	`case TableFilterType::IN_FILTER: {`
`293`	`297`	`auto &in_filter = filter.Cast<InFilter>();`