Skip to content

Commit 2eaced6

Browse files
Merge branch 'main' into fix/python-udf-refcount-leak
2 parents dbb9c15 + 45fb522 commit 2eaced6

4 files changed

Lines changed: 22 additions & 28 deletions

File tree

CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ project(duckdb_py LANGUAGES CXX)
66
set(CMAKE_CXX_STANDARD 11)
77
set(CMAKE_CXX_STANDARD_REQUIRED ON)
88
set(CMAKE_CXX_EXTENSIONS OFF)
9+
set(CMAKE_MSVC_RUNTIME_LIBRARY "MultiThreaded$<$<CONFIG:Debug>:Debug>")
910

1011
# Set the library name
1112
set(DUCKDB_PYTHON_LIB_NAME "_duckdb")

_duckdb-stubs/__init__.pyi

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -461,7 +461,9 @@ class DuckDBPyRelation:
461461
def __getattr__(self, name: str) -> DuckDBPyRelation: ...
462462
def __getitem__(self, name: str) -> DuckDBPyRelation: ...
463463
def __len__(self) -> int: ...
464-
def aggregate(self, aggr_expr: Expression | str, group_expr: Expression | str = "") -> DuckDBPyRelation: ...
464+
def aggregate(
465+
self, aggr_expr: Expression | str | list[Expression], group_expr: Expression | str = ""
466+
) -> DuckDBPyRelation: ...
465467
def any_value(
466468
self, column: str, groups: str = "", window_spec: str = "", projected_columns: str = ""
467469
) -> DuckDBPyRelation: ...

cmake/duckdb_loader.cmake

Lines changed: 17 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -114,25 +114,18 @@ function(_duckdb_validate_jemalloc_config)
114114
return()
115115
endif()
116116

117-
# jemalloc is only allowed in linux and osx debug builds
118-
if(CMAKE_SYSTEM_NAME STREQUAL "Darwin" OR CMAKE_SYSTEM_NAME STREQUAL "Linux")
119-
set(supported_os TRUE)
120-
else()
121-
set(supported_os FALSE)
122-
endif()
123-
124-
# jemalloc is only allowed in debug builds
125-
if(CMAKE_BUILD_TYPE STREQUAL "Debug" AND supported_os)
117+
# jemalloc is only enabled on 64bit x86 linux builds
118+
if(CMAKE_SIZEOF_VOID_P EQUAL 8
119+
AND CMAKE_SYSTEM_NAME STREQUAL "Linux"
120+
AND NOT BSD)
126121
set(jemalloc_allowed TRUE)
127122
else()
128123
set(jemalloc_allowed FALSE)
129124
endif()
130125

131126
if(NOT jemalloc_allowed)
132-
message(
133-
WARNING
134-
"jemalloc extension is only supported on Linux and OSX in Debug builds.\n"
135-
"Removing jemalloc from extension list.")
127+
message(WARNING "jemalloc extension is only supported on Linux.\n"
128+
"Removing jemalloc from extension list.")
136129
# Remove jemalloc from the extension list
137130
string(REPLACE "jemalloc" "" BUILD_EXTENSIONS_FILTERED
138131
"${BUILD_EXTENSIONS}")
@@ -187,19 +180,17 @@ function(_duckdb_create_interface_target target_name)
187180
if(CMAKE_SYSTEM_NAME STREQUAL "Windows")
188181
target_compile_options(
189182
${target_name}
190-
INTERFACE
191-
/wd4244 # suppress Conversion from 'type1' to 'type2', possible loss of
192-
# data
193-
/wd4267 # suppress Conversion from ‘size_t’ to ‘type’, possible loss of
194-
# data
195-
/wd4200 # suppress Nonstandard extension used: zero-sized array in
196-
# struct/union
197-
/wd26451
198-
/wd26495 # suppress Code Analysis
199-
/D_CRT_SECURE_NO_WARNINGS # suppress warnings about unsafe functions
200-
/D_DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR # see
201-
# https://github.com/duckdblabs/duckdb-internal/issues/5151
202-
/utf-8 # treat source files as UTF-8 encoded
183+
INTERFACE /wd4244 # suppress Conversion from 'type1' to 'type2', possible
184+
# loss of data
185+
/wd4267 # suppress Conversion from ‘size_t’ to ‘type’, possible
186+
# loss of data
187+
/wd4200 # suppress Nonstandard extension used: zero-sized array
188+
# in struct/union
189+
/wd26451
190+
/wd26495 # suppress Code Analysis
191+
/D_CRT_SECURE_NO_WARNINGS # suppress warnings about unsafe
192+
# functions
193+
/utf-8 # treat source files as UTF-8 encoded
203194
)
204195
elseif(CMAKE_SYSTEM_NAME STREQUAL "Darwin")
205196
target_compile_options(

external/duckdb

Submodule duckdb updated 114 files

0 commit comments

Comments
 (0)