fix(fetch): ensure scratch orgs fetched are

displayed as scratch orgs while doing
a org list

fixes #1246

Author: azlam-abdulsalam

packages/core/package-lock.json

@@ -26,7 +26,7 @@
         "@newrelic/telemetry-sdk": "^0.6.0",
         "@salesforce/apex-node": "1.1.0",
         "@salesforce/command": "5.2.43",
-        "@salesforce/core": "3.33.1",
+        "@salesforce/core": "3.34.1",
         "@salesforce/packaging": "1.2.2",
         "@salesforce/source-deploy-retrieve": "7.7.6",
         "@salesforce/source-tracking": "2.2.17",

packages/core/package.json

@@ -218,7 +218,7 @@ export default class PoolFetchImpl extends PoolBaseImpl {
 
                 const oauth2Options = AuthInfo.parseSfdxAuthUrl(soDetail.sfdxAuthUrl);
                 const authInfo = await AuthInfo.create({ oauth2Options });
-                await authInfo.save();
+                await authInfo.save({...authInfo.getFields(),isScratch:true,devHubUsername:this.hubOrg.getUsername(),expirationDate:soDetail.expiryDate});
 
                 await authInfo.handleAliasAndDefaultSettings({
                     alias: this.alias?this.alias:soDetail.alias,

packages/core/src/scratchorg/pool/PoolFetchImpl.ts

@@ -19,7 +19,7 @@
         "@oclif/plugin-plugins": "^2.2.2",
         "@oclif/plugin-update": "^1.5.0",
         "@oclif/plugin-warn-if-update-available": "^1.7.0",
-        "@salesforce/core": "3.33.1",
+        "@salesforce/core": "3.34.1",
         "@salesforce/source-deploy-retrieve": "7.7.6",
         "@salesforce/source-tracking": "2.2.17",
         "adm-zip": "^0.5.9",