feat(validate): ⚗️ add installDeps to validate in fast feedback mode

This is an experimental addition to check whether installDeps make sense to be reintroduced to fast feedback.  If this flag is activated, the external dependencies get installed

Author: azlam-abdulsalam

packages/sfpowerscripts-cli/messages/validate.json

@@ -19,6 +19,7 @@
     "disableArtifactUpdateFlagDescription": "Do not update information about deployed artifacts to the org",
     "fastfeedbackFlagDescription": "Enable validation in fast feedback mode, In fast feedback mode, validation will only do selective deployment of and selective tests",
     "orgInfoFlagDescription": "Display info about the org that is used for validation",
+    "installDepsFlagDescription":"Install dependencies during fast feedback",
     "disableSourcePackageOverride": "Disables overriding unlocked package installation as source package installation during validate",
     "disableParallelTestingFlagDescription": "Disable test execution in parallel, this will execute apex tests in serial"
 

packages/sfpowerscripts-cli/messages/validateAgainstOrg.json

@@ -11,5 +11,6 @@
     "devhubAliasFlagDescription": "Provide the alias of the devhub previously authenticated, used for installing or updating dependency in individual/thorough modes",
     "disableSourcePackageOverride": "Disables overriding unlocked package installation as source package installation during validate",
     "disableParallelTestingFlagDescription": "Disable test execution in parallel, this will execute apex tests in serial",
+    "installDepsFlagDescription":"Install dependencies during fast feedback",
     "orgInfoFlagDescription": "Display info about the org that is used for validation"
 }

packages/sfpowerscripts-cli/src/commands/orchestrator/validate.ts

@@ -36,6 +36,10 @@ export default class Validate extends SfpowerscriptsCommand {
             required: true,
             options: ['individual', 'fastfeedback', 'thorough', 'ff-release-config', 'thorough-release-config'],
         }),
+        installdeps: flags.boolean({
+            description: messages.getMessage('installDepsFlagDescription'),
+            default: false,
+        }),
         releaseconfig: flags.string({
             description: messages.getMessage('configFileFlagDescription'),
         }),
@@ -174,7 +178,8 @@ export default class Validate extends SfpowerscriptsCommand {
                 disableArtifactCommit: this.flags.disableartifactupdate,
                 orgInfo: this.flags.orginfo,
                 disableSourcePackageOverride : this.flags.disablesourcepkgoverride,
-                disableParallelTestExecution: this.flags.disableparalleltesting
+                disableParallelTestExecution: this.flags.disableparalleltesting,
+                installExternalDependencies: this.flags.installdeps,
             };
 
             setReleaseConfigForReleaseBasedModes(this.flags.releaseconfig,validateProps);

packages/sfpowerscripts-cli/src/commands/orchestrator/validateAgainstOrg.ts

@@ -55,6 +55,10 @@ export default class ValidateAgainstOrg extends SfpowerscriptsCommand {
             description: messages.getMessage('orgInfoFlagDescription'),
             default: false,
         }),
+        installdeps: flags.boolean({
+            description: messages.getMessage('installDepsFlagDescription'),
+            default: false,
+        }),
         devhubalias: flags.string({
             char: 'v',
             description: messages.getMessage('devhubAliasFlagDescription')
@@ -142,6 +146,7 @@ export default class ValidateAgainstOrg extends SfpowerscriptsCommand {
                 disableSourcePackageOverride: this.flags.disablesourcepkgoverride,
                 disableParallelTestExecution: this.flags.disableparalleltesting,
                 orgInfo: this.flags.orginfo,
+                installExternalDependencies: this.flags.installdeps,
             };
 
 

packages/sfpowerscripts-cli/src/impl/release/ReleaseConfig.ts

@@ -3,7 +3,7 @@ import ProjectConfig from '@dxatscale/sfpowerscripts.core/lib/project/ProjectCon
 import Ajv, { _ } from 'ajv';
 import ReleaseDefinitionGeneratorConfigSchema from './ReleaseDefinitionGeneratorConfigSchema';
 import lodash = require('lodash');
-import yaml from 'js-yaml';
+const yaml = require('js-yaml');
 import { Logger } from '@dxatscale/sfp-logger';
 const path = require('path');
 

packages/sfpowerscripts-cli/src/impl/validate/ValidateImpl.ts

@@ -76,6 +76,7 @@ export enum ValidationMode {
 }
 
 export interface ValidateProps {
+	installExternalDependencies?: boolean;
 	validateAgainst: ValidateAgainst;
 	validationMode: ValidationMode;
 	releaseConfigPath?: string;
@@ -715,6 +716,19 @@ export default class ValidateImpl implements PostDeployHook, PreDeployHook {
 						deployedPackages,
 					);
 				}
+				else if (this.props.validationMode == ValidationMode.FASTFEEDBACK_LIMITED_BY_RELEASE_CONFIG 
+					|| this.props.validationMode == ValidationMode.FAST_FEEDBACK) {
+					if(this.props.installExternalDependencies)
+					await this.installPackageDependencies(
+						ProjectConfig.cleanupMPDFromProjectDirectory(
+							null,
+							sfpPackage.package_name,
+						),
+						this.orgAsSFPOrg,
+						sfpPackage,
+						deployedPackages,
+					);
+				}
 				break;
 			case ValidateAgainst.PROVIDED_ORG:
 				if (this.props.validationMode == ValidationMode.INDIVIDUAL) {
@@ -736,6 +750,19 @@ export default class ValidateImpl implements PostDeployHook, PreDeployHook {
 							LoggerLevel.INFO,
 						);
 				}
+				else if (this.props.validationMode == ValidationMode.FASTFEEDBACK_LIMITED_BY_RELEASE_CONFIG 
+					|| this.props.validationMode == ValidationMode.FAST_FEEDBACK) {
+					if(this.props.installExternalDependencies)
+					await this.installPackageDependencies(
+						ProjectConfig.cleanupMPDFromProjectDirectory(
+							null,
+							sfpPackage.package_name,
+						),
+						this.orgAsSFPOrg,
+						sfpPackage,
+						deployedPackages,
+					);
+				}
 		}
 
 		return { isToFailDeployment: false };