Refactor StorageCombobox and ComponentAliasIndex to improve selection logic and initialize classes

Author: marioserrano09

extensions/entity-files/sources/ui/src/main/java/tools/dynamia/modules/entityfile/ui/components/StorageCombobox.java

@@ -18,6 +18,7 @@
 package tools.dynamia.modules.entityfile.ui.components;
 
 import java.io.Serial;
+import java.util.Objects;
 import java.util.Optional;
 
 import org.zkoss.zul.Combobox;
@@ -29,6 +30,10 @@
 import tools.dynamia.zk.ComponentAliasIndex;
 import tools.dynamia.zk.util.ZKUtil;
 
+/**
+ * Custom Combobox for EntityFileStorage selection
+ * @author Mario A. Serrano Leones
+ */
 public class StorageCombobox extends Combobox {
 
 	/**
@@ -65,7 +70,7 @@ public String getSelected() {
 	}
 
 	public void setSelected(String selected) {
-		if (selected != this.selected) {
+		if (!Objects.equals(selected, this.selected)) {
 			this.selected = selected;
 			try {
 				Optional<EntityFileStorage> selectedStorage = Containers.get().findObjects(EntityFileStorage.class)

platform/ui/zk/src/main/java/tools/dynamia/zk/ComponentAliasIndex.java

@@ -16,6 +16,7 @@
  */
 package tools.dynamia.zk;
 
+import org.springframework.util.ClassUtils;
 import org.zkoss.zk.ui.Component;
 import org.zkoss.zul.*;
 import tools.dynamia.commons.ObjectOperations;
@@ -105,6 +106,7 @@ public class ComponentAliasIndex extends HashMap<String, Class<? extends Compone
                         Class clazz = ObjectOperations.findClass(aliases.getProperty(alias));
                         if (clazz != null) {
                             getInstance().add(alias, clazz);
+                            initClass(clazz);
                         }
                     } catch (Exception ex) {
                         logger.error(
@@ -120,6 +122,13 @@ public class ComponentAliasIndex extends HashMap<String, Class<? extends Compone
 
     }
 
+    private static void initClass(Class clazz) {
+        try {
+            ObjectOperations.newInstance(clazz);
+        } catch (Exception ex) {
+        }
+    }
+
     public static ComponentAliasIndex getInstance() {
         return INDEX;
     }

platform/ui/zk/src/main/java/tools/dynamia/zk/util/ZKUtil.java

@@ -206,7 +206,7 @@ public static void fillCombobox(Combobox combo, Collection data, boolean live) {
      * @param live     if true, the model reflects changes in the underlying collection
      */
     public static void fillCombobox(Combobox combo, Collection data, Object selected, boolean live) {
-        if (combo != null) {
+        if (combo != null && ZKUtil.isInEventListener()) {
             ListModelList model = new ListModelList<>(data);
             if (selected != null) {
                 model.addToSelection(selected);