Skip to content

Commit aae1d7f

Browse files
committed
Enhance some checks
1 parent d5fbf84 commit aae1d7f

3 files changed

Lines changed: 3 additions & 2 deletions

File tree

easybuild/framework/easyblock.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4725,6 +4725,7 @@ def test_cases_step(self):
47254725
else:
47264726
original_perms = None
47274727
try:
4728+
self.log.debug(f"Running test {test_cmd}")
47284729
run_shell_cmd(test_cmd)
47294730
except RunShellCmdError:
47304731
raise # Let that propagate which will report more information

easybuild/tools/variables.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ def get_class(name, default_class, map_class=None):
5454
if name is not None:
5555
try:
5656
klass = map_class[name]
57-
except BaseException:
57+
except KeyError:
5858
for k, v in map_class.items():
5959
if type(k) in (type,) and name in v:
6060
klass = k

test/framework/run.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -639,7 +639,7 @@ def handler(signum, _):
639639
# check error reporting output when stdout/stderr are collected separately
640640
try:
641641
run_shell_cmd(cmd, split_stderr=True)
642-
self.assertFalse("This should never be reached, RunShellCmdError should occur!")
642+
self.fail("This should never be reached, RunShellCmdError should occur!")
643643
except RunShellCmdError as err:
644644
self.assertEqual(str(err), "Shell command 'kill' failed!")
645645
self.assertEqual(err.cmd, "kill -9 $$")

0 commit comments

Comments
 (0)