Merge pull request #1443 from danielpeintner/issue-1430-typescript-eslint-no-require-imports

refactor: activate eslint @typescript-eslint/no-require-imports

Author: relu91

eslint.config.mjs

@@ -121,7 +121,7 @@ export default defineConfig([
             "@typescript-eslint/no-use-before-define": "error",
             "@typescript-eslint/no-unused-vars": "off",
             "@typescript-eslint/no-unused-expressions": "off",
-            "@typescript-eslint/no-require-imports": "off", // https://github.com/eclipse-thingweb/node-wot/issues/1430
+            "@typescript-eslint/no-require-imports": "error",
             "@typescript-eslint/prefer-nullish-coalescing": "error",
             "@typescript-eslint/no-empty-object-type": "error",
             "@typescript-eslint/no-floating-promises": "off", // https://github.com/eclipse-thingweb/node-wot/issues/1430

packages/binding-coap/src/mdns-introducer.ts

@@ -13,6 +13,7 @@
  * SPDX-License-Identifier: EPL-2.0 OR W3C-20150513
  ********************************************************************************/
 
+// eslint-disable-next-line @typescript-eslint/no-require-imports
 import makeMdns = require("multicast-dns");
 import { networkInterfaces } from "os";
 import { MulticastDNS } from "multicast-dns";

packages/binding-mbus/src/mbus-connection.ts

@@ -16,6 +16,7 @@
 import { MBusForm } from "./mbus";
 import { Content, createLoggers } from "@node-wot/core";
 import { Readable } from "stream";
+// eslint-disable-next-line @typescript-eslint/no-require-imports
 const MbusMaster = require("node-mbus");
 
 const { debug, warn, error } = createLoggers("binding-mbus", "mbus-connection");

packages/cli/src/executor.ts

@@ -30,6 +30,7 @@ export class Executor {
         global.WoT = wotContext.runtime;
 
         if (isTypeScriptScript === true) {
+            // eslint-disable-next-line @typescript-eslint/no-require-imports
             require("ts-node/register");
         }
 
@@ -40,6 +41,7 @@ export class Executor {
             if (file.endsWith(".mjs")) {
                 return await import(`file:///${file}`);
             } else {
+                // eslint-disable-next-line @typescript-eslint/no-require-imports
                 return require(file);
             }
         } catch (error) {

packages/core/src/consumed-thing.ts

@@ -39,7 +39,7 @@ import ContentType from "content-type";
 
 import ContentManager from "./content-serdes";
 
-import UriTemplate = require("uritemplate");
+import * as UriTemplate from "uritemplate";
 import { InteractionOutput, ActionInteractionOutput } from "./interaction-output";
 import {
     ActionElement,

packages/core/src/serdes.ts

@@ -17,8 +17,9 @@ import { Thing } from "./thing-description";
 import * as TD from "./thing-description";
 import { createLoggers } from "./logger";
 
+// eslint-disable-next-line @typescript-eslint/no-require-imports
 import isAbsoluteUrl = require("is-absolute-url");
-import URLToolkit = require("url-toolkit");
+import * as URLToolkit from "url-toolkit";
 import {
     ThingContext,
     PropertyElement,

packages/core/test/helpers-test.ts

@@ -27,7 +27,7 @@ import * as TDT from "wot-thing-description-types";
 
 import Helpers from "../src/helpers";
 
-import UriTemplate = require("uritemplate");
+import * as UriTemplate from "uritemplate";
 
 @suite("tests to verify the helpers")
 class HelperTest {