change error message for integer overflows

Author: derwehr

packages/core/src/codecs/octetstream-codec.ts

@@ -372,11 +372,11 @@ export default class OctetstreamCodec implements ContentCodec {
         // throw error on overflow
         if (signed) {
             if (value < -limit - 1 || value > limit) {
-                throw new Error("Integer overflow when representing signed " + value + " in " + length + " bit(s)");
+                throw new Error("Integer overflow when representing " + value + " as a signed integer using " + length + " bit(s)");
             }
         } else {
             if (value < 0 || value > limit) {
-                throw new Error("Integer overflow when representing unsigned " + value + " in " + length + " bit(s)");
+                throw new Error("Integer overflow when representing " + value + " as an unsigned integer using " + length + " bit(s)");
             }
         }
 

packages/core/test/ContentSerdesTest.ts

@@ -768,25 +768,25 @@ class SerdesOctetTests {
     @test "value to OctetStream should throw"() {
         expect(() => ContentSerdes.valueToContent(256, { type: "uint8" }, "application/octet-stream")).to.throw(
             Error,
-            "Integer overflow when representing unsigned 256 in 8 bit(s)"
+            "Integer overflow when representing 256 as an unsigned integer using 8 bit(s)"
         );
         expect(() => ContentSerdes.valueToContent(-1, { type: "uint8" }, "application/octet-stream")).to.throw(
             Error,
-            "Integer overflow when representing unsigned -1 in 8 bit(s)"
+            "Integer overflow when representing -1 as an unsigned integer using 8 bit(s)"
         );
         expect(() => ContentSerdes.valueToContent(128, { type: "int8" }, "application/octet-stream")).to.throw(
             Error,
-            "Integer overflow when representing signed 128 in 8 bit(s)"
+            "Integer overflow when representing 128 as a signed integer using 8 bit(s)"
         );
         expect(() => ContentSerdes.valueToContent(-129, { type: "int8" }, "application/octet-stream")).to.throw(
             Error,
-            "Integer overflow when representing signed -129 in 8 bit(s)"
+            "Integer overflow when representing -129 as a signed integer using 8 bit(s)"
         );
 
         // @ts-ignore new dataschema types are not yet supported in the td type definitions
         expect(() => ContentSerdes.valueToContent(23450000, { type: "int16" }, "application/octet-stream")).to.throw(
             Error,
-            "Integer overflow when representing signed 23450000 in 16 bit(s)"
+            "Integer overflow when representing 23450000 as a signed integer using 16 bit(s)"
         );
         expect(() => ContentSerdes.valueToContent(2345, { type: "foo" }, "application/octet-stream")).to.throw(
             Error,
@@ -804,14 +804,14 @@ class SerdesOctetTests {
                 { type: "integer", "ex:bitOffset": 0, "ex:bitLength": 10 },
                 "application/octet-stream"
             )
-        ).to.throw(Error, "Integer overflow when representing signed -2345 in 10 bit(s)");
+        ).to.throw(Error, "Integer overflow when representing -2345 as a signed integer using 10 bit(s)");
         expect(() =>
             ContentSerdes.valueToContent(
                 -32769,
                 { type: "integer", "ex:bitOffset": 0, "ex:bitLength": 16 },
                 "application/octet-stream"
             )
-        ).to.throw(Error, "Integer overflow when representing signed -32769 in 16 bit(s)");
+        ).to.throw(Error, "Integer overflow when representing -32769 as a signed integer using 16 bit(s)");
         expect(() =>
             ContentSerdes.valueToContent(
                 { flag1: true, flag2: false, numberProperty: 99, stringProperty: "Web" },