Address CodeRabbit review comments

CsvReader: remove GetType().Name == "MockFileSystem" type check — the check
never matched after ScopedFileSystem wrapping was introduced, causing Sep to
read from the real filesystem via FromFile() instead of going through the
scoped IFileSystem. Always use IFileSystem.File.ReadAllText + Sep.FromText so
all filesystem access (real, scoped, or mock) goes through the abstraction.

ChangelogCommand: four ChangelogConfigurationLoader instantiations were still
passing new System.IO.Abstractions.FileSystem() directly, bypassing the
scoped _fileSystem field. Replace with _fileSystem.

ChangelogRenderingService: service writes output files (CreateDirectory,
WriteAllTextAsync) so its default should be FileSystemFactory.RealWrite not
RealRead. RealWrite has the same scope but correctly excludes .git write access.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

Author: Mpdreamz

src/Elastic.Markdown/Myst/Directives/CsvInclude/CsvReader.cs

@@ -22,35 +22,16 @@ private static IEnumerable<string[]> ReadWithSep(string filePath, string separat
 		var separatorChar = separator == "," ? ',' : separator[0];
 		var spec = Sep.New(separatorChar);
 
-		// Sep works with actual file paths, not virtual file systems
-		// For testing with MockFileSystem, we'll read content first
-		if (fileSystem.GetType().Name == "MockFileSystem")
-		{
-			var content = fileSystem.File.ReadAllText(filePath);
-			using var reader = spec.Reader(o => o with { HasHeader = false, Unescape = true }).FromText(content);
+		// Always read via IFileSystem so that scoped and mock file systems are respected.
+		var content = fileSystem.File.ReadAllText(filePath);
+		using var reader = spec.Reader(o => o with { HasHeader = false, Unescape = true }).FromText(content);
 
-			foreach (var row in reader)
-			{
-				var rowData = new string[row.ColCount];
-				for (var i = 0; i < row.ColCount; i++)
-					rowData[i] = row[i].ToString();
-				yield return rowData;
-			}
-		}
-		else
+		foreach (var row in reader)
 		{
-			using var reader = spec.Reader(o => o with { HasHeader = false, Unescape = true }).FromFile(filePath);
-
-			foreach (var row in reader)
-			{
-				var rowData = new string[row.ColCount];
-				for (var i = 0; i < row.ColCount; i++)
-				{
-					rowData[i] = row[i].ToString();
-				}
-				yield return rowData;
-			}
+			var rowData = new string[row.ColCount];
+			for (var i = 0; i < row.ColCount; i++)
+				rowData[i] = row[i].ToString();
+			yield return rowData;
 		}
 	}
-
 }

src/services/Elastic.Changelog/Rendering/ChangelogRenderingService.cs

@@ -70,7 +70,7 @@ public class ChangelogRenderingService(
 ) : IService
 {
 	private readonly ILogger _logger = logFactory.CreateLogger<ChangelogRenderingService>();
-	private readonly ScopedFileSystem _fileSystem = fileSystem ?? FileSystemFactory.RealRead;
+	private readonly ScopedFileSystem _fileSystem = fileSystem ?? FileSystemFactory.RealWrite;
 
 	public async Task<bool> RenderChangelogs(
 		IDiagnosticsCollector collector,

src/tooling/docs-builder/Commands/ChangelogCommand.cs

@@ -288,7 +288,7 @@ public async Task<int> Create(
 		// Load changelog config and apply fallbacks for all modes.
 		// Precedence: CLI option > bundle section in changelog.yml > built-in default.
 		// This applies to --prs, --issues, and --release-version alike.
-		var bundleConfig = await new ChangelogConfigurationLoader(logFactory, configurationContext, new System.IO.Abstractions.FileSystem())
+		var bundleConfig = await new ChangelogConfigurationLoader(logFactory, configurationContext, _fileSystem)
 			.LoadChangelogConfiguration(collector, config, ctx);
 		var resolvedRepo = !string.IsNullOrWhiteSpace(repo) ? repo : bundleConfig?.Bundle?.Repo;
 		var resolvedOwner = owner ?? bundleConfig?.Bundle?.Owner ?? "elastic";
@@ -542,7 +542,7 @@ public async Task<int> Bundle(
 			}
 
 			// Precedence: --repo CLI > bundle.repo config; --owner CLI > bundle.owner config > "elastic"
-			var bundleConfig = await new ChangelogConfigurationLoader(logFactory, configurationContext, new System.IO.Abstractions.FileSystem())
+			var bundleConfig = await new ChangelogConfigurationLoader(logFactory, configurationContext, _fileSystem)
 				.LoadChangelogConfiguration(collector, config, ctx);
 			var resolvedRepo = !string.IsNullOrWhiteSpace(repo) ? repo : bundleConfig?.Bundle?.Repo;
 			var resolvedOwner = owner ?? bundleConfig?.Bundle?.Owner ?? "elastic";
@@ -845,7 +845,7 @@ public async Task<int> Remove(
 			}
 
 			// Precedence: --repo CLI > bundle.repo config; --owner CLI > bundle.owner config > "elastic"
-			var bundleConfig = await new ChangelogConfigurationLoader(logFactory, configurationContext, new System.IO.Abstractions.FileSystem())
+			var bundleConfig = await new ChangelogConfigurationLoader(logFactory, configurationContext, _fileSystem)
 				.LoadChangelogConfiguration(collector, config, ctx);
 			var resolvedRepo = !string.IsNullOrWhiteSpace(repo) ? repo : bundleConfig?.Bundle?.Repo;
 			var resolvedOwner = owner ?? bundleConfig?.Bundle?.Owner ?? "elastic";
@@ -1104,7 +1104,7 @@ public async Task<int> GitHubRelease(
 		await using var serviceInvoker = new ServiceInvoker(collector);
 
 		// --output CLI > bundle.directory config > ./changelogs (service default)
-		var bundleConfig = await new ChangelogConfigurationLoader(logFactory, configurationContext, new System.IO.Abstractions.FileSystem())
+		var bundleConfig = await new ChangelogConfigurationLoader(logFactory, configurationContext, _fileSystem)
 			.LoadChangelogConfiguration(collector, config, ctx);
 		var resolvedOutput = !string.IsNullOrWhiteSpace(output) ? output : bundleConfig?.Bundle?.Directory;