Skip to content

Commit db59cf1

Browse files
Mpdreamzclaude
andcommitted
Fix CI failures: restore Temp in WriteOptions, fix import ordering
WriteOptions had AllowedSpecialFolders.Temp removed on the assumption that only ConfigurationFileProvider used it. AwsS3SyncApplyStrategy also uses temp to stage files before S3 upload — restore Temp to WriteOptions to fix the DocsSyncTests.TestApply integration failure. Fix IMPORTS lint errors across all files that gained new Nullean.ScopedFileSystem using directives during the ScopedFileSystem migration; dotnet format reorders them into the expected alphabetical/grouped order. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
1 parent 8b868d5 commit db59cf1

38 files changed

Lines changed: 42 additions & 44 deletions

File tree

src/Elastic.Codex/Building/CodexBuildService.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
using System.Collections.Frozen;
66
using System.IO.Abstractions;
77
using System.Text.Json;
8-
using Nullean.ScopedFileSystem;
98
using Elastic.Codex.Navigation;
109
using Elastic.Codex.Page;
1110
using Elastic.Codex.Sourcing;
@@ -26,6 +25,7 @@
2625
using Elastic.Markdown.Exporters;
2726
using Elastic.Markdown.IO;
2827
using Microsoft.Extensions.Logging;
28+
using Nullean.ScopedFileSystem;
2929

3030
namespace Elastic.Codex.Building;
3131

src/Elastic.Codex/CodexContext.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,10 @@
33
// See the LICENSE file in the project root for more information
44

55
using System.IO.Abstractions;
6-
using Nullean.ScopedFileSystem;
76
using Elastic.Documentation.Configuration;
87
using Elastic.Documentation.Configuration.Codex;
98
using Elastic.Documentation.Diagnostics;
9+
using Nullean.ScopedFileSystem;
1010

1111
namespace Elastic.Codex;
1212

src/Elastic.Codex/Indexing/CodexIndexService.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,14 @@
33
// See the LICENSE file in the project root for more information
44

55
using System.IO.Abstractions;
6-
using Nullean.ScopedFileSystem;
76
using Elastic.Codex.Building;
87
using Elastic.Codex.Sourcing;
98
using Elastic.Documentation;
109
using Elastic.Documentation.Configuration;
1110
using Elastic.Documentation.Isolated;
1211
using Elastic.Documentation.Services;
1312
using Microsoft.Extensions.Logging;
13+
using Nullean.ScopedFileSystem;
1414

1515
namespace Elastic.Codex.Indexing;
1616

src/Elastic.Documentation.Configuration/BuildContext.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44

55
using System.IO.Abstractions;
66
using System.Reflection;
7-
using Nullean.ScopedFileSystem;
87
using Elastic.Documentation;
98
using Elastic.Documentation.Configuration.Assembler;
109
using Elastic.Documentation.Configuration.Builder;
@@ -14,6 +13,7 @@
1413
using Elastic.Documentation.Configuration.Toc;
1514
using Elastic.Documentation.Configuration.Versions;
1615
using Elastic.Documentation.Diagnostics;
16+
using Nullean.ScopedFileSystem;
1717

1818
namespace Elastic.Documentation.Configuration;
1919

src/Elastic.Documentation.Configuration/FileSystemFactory.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,13 @@ public static class FileSystemFactory
2222

2323
// Write options: same scope roots but no .git — nothing in the build output
2424
// pipeline should ever write into the git repository metadata.
25+
// Temp is allowed because deploy operations (e.g. S3 sync) stage files there.
2526
private static readonly ScopedFileSystemOptions WriteOptions = new(
2627
[Paths.WorkingDirectoryRoot.FullName, Paths.ApplicationData.FullName])
2728
{
2829
AllowedHiddenFolderNames = new HashSet<string>(StringComparer.OrdinalIgnoreCase) { ".artifacts" },
29-
AllowedHiddenFileNames = new HashSet<string>(StringComparer.OrdinalIgnoreCase) { ".doc.state" }
30+
AllowedHiddenFileNames = new HashSet<string>(StringComparer.OrdinalIgnoreCase) { ".doc.state" },
31+
AllowedSpecialFolders = AllowedSpecialFolder.Temp
3032
};
3133

3234
// AppData-only options: for components that only access caches/state files.

src/Elastic.Documentation.Configuration/Toc/DocumentationSetFile.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,11 @@
33
// See the LICENSE file in the project root for more information
44

55
using System.IO.Abstractions;
6-
using Nullean.ScopedFileSystem;
76
using Elastic.Documentation.Configuration.Products;
87
using Elastic.Documentation.Configuration.Toc.DetectionRules;
98
using Elastic.Documentation.Diagnostics;
109
using Elastic.Documentation.Extensions;
10+
using Nullean.ScopedFileSystem;
1111
using YamlDotNet.Serialization;
1212
using static Elastic.Documentation.Configuration.SymlinkValidator;
1313

src/Elastic.Documentation.LinkIndex/GitLinkIndexReader.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
using System.Diagnostics;
66
using System.IO.Abstractions;
77
using Elastic.Documentation.Configuration;
8-
using Nullean.ScopedFileSystem;
98
using Elastic.Documentation.Links;
9+
using Nullean.ScopedFileSystem;
1010

1111
namespace Elastic.Documentation.LinkIndex;
1212

src/Elastic.Documentation.Links/CrossLinks/CrossLinkFetcher.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,10 @@
77
using System.IO.Abstractions;
88
using System.Text.Json;
99
using Elastic.Documentation.Configuration;
10-
using Nullean.ScopedFileSystem;
1110
using Elastic.Documentation.LinkIndex;
1211
using Elastic.Documentation.Serialization;
1312
using Microsoft.Extensions.Logging;
13+
using Nullean.ScopedFileSystem;
1414

1515
namespace Elastic.Documentation.Links.CrossLinks;
1616

src/Elastic.Markdown/Myst/Directives/CsvInclude/CsvReader.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44

55
using System.IO.Abstractions;
66
using Elastic.Documentation.Configuration;
7-
using Nullean.ScopedFileSystem;
87
using nietras.SeparatedValues;
8+
using Nullean.ScopedFileSystem;
99

1010
namespace Elastic.Markdown.Myst.Directives.CsvInclude;
1111

src/authoring/Elastic.Documentation.Refactor/FormatService.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,14 @@
33
// See the LICENSE file in the project root for more information
44

55
using System.IO.Abstractions;
6-
using Nullean.ScopedFileSystem;
76
using Elastic.Documentation.Configuration;
87
using Elastic.Documentation.Diagnostics;
98
using Elastic.Documentation.Links.CrossLinks;
109
using Elastic.Documentation.Refactor.Formatters;
1110
using Elastic.Documentation.Services;
1211
using Elastic.Markdown.IO;
1312
using Microsoft.Extensions.Logging;
13+
using Nullean.ScopedFileSystem;
1414

1515
namespace Elastic.Documentation.Refactor;
1616

0 commit comments

Comments
 (0)