Improve Errors kind parsing (#6)

This change expands the `ErrorTracker.Error.new/2` API to allow receiving exceptions in three ways:

1. `{kind, reason}`
2. `{kind, exception}`
3. `exception`

If a exception is received (either with a kind or not): 
- the `kind` field is set to the struct of the exception.
- the `reason` field is set to the message of the exception.

If a `{kind, reason}` is received: 
- the `kind` field is set to the `kind` value converted to string.
- the `reason` field is set to the `reason` value converted to string.

Aside from that, the dev server now includes another route to generate an `EXIT` signal to test this.

Author: odarriba

dev.exs

@@ -59,6 +59,7 @@ defmodule ErrorTrackerDevWeb.PageController do
     <div><a href="/404">Generate Router 404</a></div>
     <div><a href="/noroute">Raise NoRouteError from a controller</a></div>
     <div><a href="/exception">Generate Exception</a></div>
+    <div><a href="/exit">Generate Exit</a></div>
     """)
   end
 
@@ -70,6 +71,10 @@ defmodule ErrorTrackerDevWeb.PageController do
     raise "This is a controller exception"
   end
 
+  def call(_conn, :exit) do
+    exit(:timeout)
+  end
+
   defp content(conn, content) do
     conn
     |> put_resp_header("content-type", "text/html")
@@ -100,6 +105,7 @@ defmodule ErrorTrackerDevWeb.Router do
     get "/", ErrorTrackerDevWeb.PageController, :index
     get "/noroute", ErrorTrackerDevWeb.PageController, :noroute
     get "/exception", ErrorTrackerDevWeb.PageController, :exception
+    get "/exit", ErrorTrackerDevWeb.PageController, :exit
   end
 end
 

lib/error_tracker/integrations/phoenix.ex

@@ -27,15 +27,15 @@ defmodule ErrorTracker.Integrations.Phoenix do
   end
 
   def handle_event([:phoenix, :router_dispatch, :exception], _measurements, metadata, :no_config) do
-    {reason, stack} =
+    {reason, kind, stack} =
       case metadata do
-        %{reason: %Plug.Conn.WrapperError{reason: reason, stack: stack}} ->
-          {reason, stack}
+        %{reason: %Plug.Conn.WrapperError{reason: reason, kind: kind, stack: stack}} ->
+          {reason, kind, stack}
 
-        %{reason: reason, stacktrace: stack} ->
-          {reason, stack}
+        %{kind: kind, reason: reason, stacktrace: stack} ->
+          {reason, kind, stack}
       end
 
-    PlugIntegration.report_error(metadata.conn, reason, stack)
+    PlugIntegration.report_error(metadata.conn, {reason, kind}, stack)
   end
 end

lib/error_tracker/integrations/plug.ex

@@ -62,7 +62,7 @@ defmodule ErrorTracker.Integrations.Plug do
       catch
         kind, reason ->
           stack = __STACKTRACE__
-          unquote(__MODULE__).report_error(conn, reason, stack)
+          unquote(__MODULE__).report_error(conn, {kind, reason}, stack)
 
           :erlang.raise(kind, reason, stack)
       end

lib/error_tracker/schemas/error.ex

@@ -24,9 +24,21 @@ defmodule ErrorTracker.Error do
   def new(exception, stacktrace = %ErrorTracker.Stacktrace{}) do
     source = ErrorTracker.Stacktrace.source(stacktrace)
 
+    {kind, reason} =
+      case exception do
+        %struct{} = ex when is_exception(ex) ->
+          {to_string(struct), Exception.message(ex)}
+
+        {_kind, %struct{} = ex} when is_exception(ex) ->
+          {to_string(struct), Exception.message(ex)}
+
+        {kind, ex} ->
+          {to_string(kind), to_string(ex)}
+      end
+
     params = [
-      kind: "error",
-      reason: Exception.message(exception),
+      kind: to_string(kind),
+      reason: reason,
       source_line: "#{source.file}:#{source.line}",
       source_function: "#{source.module}.#{source.function}/#{source.arity}"
     ]