Remove support for javascript queries

Author: michalmuskala

lib/mongo_ecto/helpers.ex

@@ -4,25 +4,6 @@ defmodule Mongo.Ecto.Helpers do
   where you work with them. You'd probably want to import it.
   """
 
-  @doc """
-  Allows using inline JavaScript in queries in where clauses and inserting it
-  as a value to the database.
-
-  The second argument acts as a context for the function. All values will be
-  converted to valid BSON types.
-
-  Raises ArgumentError if any of the values cannot be converted.
-
-  ## Usage in queries
-
-      from p in Post,
-        where: ^javascript("this.value === value", value: 1)
-  """
-  @spec javascript(String.t, Keyword.t) :: Mongo.Ecto.JavaScript.t
-  def javascript(code, scope \\ []) do
-    %Mongo.Ecto.JavaScript{code: code, scope: scope}
-  end
-
   @doc """
   Creates proper regex object that can be passed to the database.
 

lib/mongo_ecto/java_script.ex

@@ -422,8 +422,6 @@ defmodule Mongo.Ecto.NormalizedQuery do
   end
   defp pair({:^, _, _} = expr, params, pk, query, place) do
     case value(expr, params, pk, query, place) do
-      %BSON.JavaScript{} = js ->
-        {:"$where", js}
       bool when is_boolean(bool) ->
         boolean_query_hack_pair(bool)
       _value ->

lib/mongo_ecto/normalized_query.ex

@@ -21,16 +21,6 @@ defmodule Mongo.EctoTest do
     assert [] == TestRepo.all(Post)
   end
 
-  # TODO: The ecto library requires that we pass a keyword list to the where
-  #       clause. Fix this once I understand more how this works.
-  test "javascript in query" do
-    TestRepo.insert!(%Post{visits: 1})
-
-    js = javascript("this.visits == count", count: 1)
-
-    assert [%Post{}] = TestRepo.all(from p in Post, where: ^js)
-  end
-
   test "regex in query" do
     p1 = TestRepo.insert!(%Post{title: "some text"})
     p2 = TestRepo.insert!(%Post{title: "other text"})