build: Remove extra build step and generate msotypes on build (#9)

* ci: remove extra build from gh action

* internal: Add generated msotypes to gitignore

* build: Generate msotypes on build

Author: buames

.eslintrc.js

@@ -1,9 +1,15 @@
-const extensions = ['.ts', '.js', '.jsx', '.json'];
+const extensions = ['.ts', '.tsx', '.js', '.jsx', '.json'];
 
 module.exports = {
   root: true,
-  extends: ['@postmates', 'prettier'],
-  plugins: ['import', 'prettier'],
+  extends: [
+    '@postmates',
+    'prettier',
+    'prettier/react',
+    'prettier/standard',
+    'prettier/@typescript-eslint',
+  ],
+  plugins: ['prettier'],
   env: { node: true },
   settings: {
     'import/extensions': extensions,
@@ -20,14 +26,14 @@ module.exports = {
 
     // typescript
     '@typescript-eslint/explicit-function-return-type': 0,
-    '@typescript-eslint/no-use-before-define': 0,
   },
   overrides: [
     {
       files: ['*.ts', '*.tsx'],
       rules: {
         // prefer consistency
         '@typescript-eslint/no-inferrable-types': 0,
+        '@typescript-eslint/no-use-before-define': 0,
         '@typescript-eslint/explicit-function-return-type': 2,
       },
     },

.github/workflows/pr.yml

@@ -10,8 +10,6 @@ jobs:
         uses: actions/setup-node@v1
       - name: Install dependencies
         run: yarn install --ignore-engines --frozen-lockfile
-      - name: Build all files
-        run: yarn run build
       - name: Validate conventional title
         uses: beemojs/conventional-pr-action@v1
         env:

.gitignore

@@ -5,6 +5,7 @@ node_modules
 # build
 dist
 tsconfig.tsbuildinfo
+packages/msotype/index.d.ts
 
 # test
 coverage

package.json

@@ -6,25 +6,24 @@
   ],
   "scripts": {
     "postinstall": "lerna bootstrap",
-    "clean": "lerna exec \"rm -rf ./{dist,*.tsbuildinfo}\"",
+    "clean": "rm -rf ./packages/*/{*.tsbuildinfo,dist}",
     "clean:prune": "rm -rf ./{,*/,**/*/}{node_modules,coverage,*.lock,*.log,*.tsbuildinfo,dist}",
-    "build": "yarn clean && lerna run build --ignore=@email-types/scripts && yarn types",
+    "build": "yarn clean && lerna run build --ignore=@email-types/scripts && yarn types && yarn run gen mso",
     "dev": "run-p dev:* ",
     "dev:all": "lerna run dev --parallel",
     "dev:types": "run-p \"types:* --watch\"",
+    "gen": "yarn workspace @email-types/scripts build",
     "test": "yarn build && yarn lint && yarn jest:coverage",
     "jest": "jest --colors --logHeapUsage",
     "jest:coverage": "yarn run jest --coverage",
-    "lint": "yarn run eslint .",
-    "eslint": "eslint --ext js,jsx,ts,tsx --max-warnings=0 --report-unused-disable-directives",
+    "lint": "eslint . --ext js,jsx,ts,tsx --max-warnings=0 --report-unused-disable-directives",
     "prettier": "prettier \"**/*.{js,jsx,ts,tsx,md,mdx,json}\" --write",
     "types": "tsc --build packages/*/tsconfig.json",
     "prepublishOnly": "NODE_ENV=production yarn run build",
     "release": "lerna publish",
     "release:publish": "lerna publish from-git",
     "release:version": "lerna version --conventional-commits --changelog-preset conventional-changelog-beemo --create-release github --push",
-    "canary:version": "lerna version prerelease --preid canary --conventional-commits --changelog-preset conventional-changelog-beemo --create-release github --push",
-    "emailtypes": "yarn workspace @email-types/scripts build"
+    "canary:version": "lerna version prerelease --preid canary --conventional-commits --changelog-preset conventional-changelog-beemo --create-release github --push"
   },
   "lint-staged": {
     "**/*.{js,jsx,ts,tsx,md,mdx,json}": [