Fix pairity with template-lint

Author: NullVoxPopuli

lib/rules/template-no-chained-this.js

@@ -23,30 +23,46 @@ module.exports = {
     return {
       GlimmerPathExpression(node) {
         const text = sourceCode.getText(node);
-        if (text.startsWith('this.this.')) {
-          // Don't autofix if this PathExpression is the path of a BlockStatement,
-          // because the closing tag wouldn't be updated and the template would break.
-          const isBlockPath =
-            node.parent?.type === 'GlimmerBlockStatement' && node.parent.path === node;
-
-          context.report({
-            node,
-            messageId: 'noChainedThis',
-            fix: isBlockPath
-              ? undefined
-              : (fixer) => {
-                  return fixer.replaceText(node, text.replace('this.this.', 'this.'));
-                },
-          });
+        if (!text.startsWith('this.this.')) {
+          return;
         }
+
+        const fixed = text.replace('this.this.', 'this.');
+
+        context.report({
+          node,
+          messageId: 'noChainedThis',
+          fix(fixer) {
+            const fixes = [fixer.replaceText(node, fixed)];
+
+            // Block statements have a closing tag path that must match
+            const parent = node.parent;
+            if (parent?.type === 'GlimmerBlockStatement' && parent.path === node) {
+              const closingPathEnd = parent.range[1] - 2; // before '}}'
+              const closingPathStart = closingPathEnd - text.length;
+              fixes.push(fixer.replaceTextRange([closingPathStart, closingPathEnd], fixed));
+            }
+
+            return fixes;
+          },
+        });
       },
       GlimmerElementNode(node) {
-        if (node.tag?.startsWith('this.this.')) {
-          context.report({
-            node,
-            messageId: 'noChainedThis',
-          });
+        if (!node.tag?.startsWith('this.this.')) {
+          return;
         }
+
+        const fixedTag = node.tag.replace('this.this.', 'this.');
+
+        context.report({
+          node,
+          messageId: 'noChainedThis',
+          fix(fixer) {
+            // Replace the tag name after '<'
+            const openStart = node.range[0] + 1;
+            return fixer.replaceTextRange([openStart, openStart + node.tag.length], fixedTag);
+          },
+        });
       },
     };
   },

tests/lib/rules/template-no-chained-this.js

@@ -34,14 +34,12 @@ ruleTester.run('template-no-chained-this', rule, {
     },
     {
       code: '<template><this.this.Component /></template>',
-      output: null,
+      output: '<template><this.Component /></template>',
       errors: [{ messageId: 'noChainedThis' }],
     },
-
-    // Test cases ported from ember-template-lint
     {
       code: '<template>{{#this.this.value}}woo{{/this.this.value}}</template>',
-      output: null,
+      output: '<template>{{#this.value}}woo{{/this.value}}</template>',
       errors: [{ messageId: 'noChainedThis' }],
     },
     {