Skip to content

Commit 66149d3

Browse files
CopilotNullVoxPopuli
authored andcommitted
Revert unnecessary quote and formatting changes
- Restore double quotes in lib/recommended-rules.js (as in master) - Restore trailing commas in lib/recommended-rules-gjs.js and lib/recommended-rules-gts.js - Remove quote replacement logic from scripts/update-rules.js These files should not have been changed as part of adding the template-no-log rule.
1 parent fd2a782 commit 66149d3

File tree

4 files changed

+74
-74
lines changed

4 files changed

+74
-74
lines changed

lib/recommended-rules-gjs.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,5 @@
55
* definitions, execute "npm run update"
66
*/
77
module.exports = {
8-
'ember/template-no-let-reference': 'error'
8+
'ember/template-no-let-reference': 'error',
99
};

lib/recommended-rules-gts.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,5 @@
55
* definitions, execute "npm run update"
66
*/
77
module.exports = {
8-
'ember/template-no-let-reference': 'error'
8+
'ember/template-no-let-reference': 'error',
99
};

lib/recommended-rules.js

Lines changed: 71 additions & 71 deletions
Original file line numberDiff line numberDiff line change
@@ -5,74 +5,74 @@
55
* definitions, execute "npm run update"
66
*/
77
module.exports = {
8-
'ember/avoid-leaking-state-in-ember-objects': 'error',
9-
'ember/avoid-using-needs-in-controllers': 'error',
10-
'ember/classic-decorator-hooks': 'error',
11-
'ember/classic-decorator-no-classic-methods': 'error',
12-
'ember/closure-actions': 'error',
13-
'ember/jquery-ember-run': 'error',
14-
'ember/new-module-imports': 'error',
15-
'ember/no-actions-hash': 'error',
16-
'ember/no-arrow-function-computed-properties': 'error',
17-
'ember/no-assignment-of-untracked-properties-used-in-tracking-contexts': 'error',
18-
'ember/no-at-ember-render-modifiers': 'error',
19-
'ember/no-attrs-in-components': 'error',
20-
'ember/no-attrs-snapshot': 'error',
21-
'ember/no-capital-letters-in-routes': 'error',
22-
'ember/no-classic-classes': 'error',
23-
'ember/no-classic-components': 'error',
24-
'ember/no-component-lifecycle-hooks': 'error',
25-
'ember/no-computed-properties-in-native-classes': 'error',
26-
'ember/no-controller-access-in-routes': 'error',
27-
'ember/no-deeply-nested-dependent-keys-with-each': 'error',
28-
'ember/no-deprecated-router-transition-methods': 'error',
29-
'ember/no-duplicate-dependent-keys': 'error',
30-
'ember/no-ember-super-in-es-classes': 'error',
31-
'ember/no-ember-testing-in-module-scope': 'error',
32-
'ember/no-empty-glimmer-component-classes': 'error',
33-
'ember/no-function-prototype-extensions': 'error',
34-
'ember/no-get-with-default': 'error',
35-
'ember/no-get': 'error',
36-
'ember/no-global-jquery': 'error',
37-
'ember/no-implicit-injections': 'error',
38-
'ember/no-incorrect-calls-with-inline-anonymous-functions': 'error',
39-
'ember/no-incorrect-computed-macros': 'error',
40-
'ember/no-invalid-debug-function-arguments': 'error',
41-
'ember/no-invalid-dependent-keys': 'error',
42-
'ember/no-invalid-test-waiters': 'error',
43-
'ember/no-jquery': 'error',
44-
'ember/no-legacy-test-waiters': 'error',
45-
'ember/no-mixins': 'error',
46-
'ember/no-new-mixins': 'error',
47-
'ember/no-noop-setup-on-error-in-before': 'error',
48-
'ember/no-observers': 'error',
49-
'ember/no-old-shims': 'error',
50-
'ember/no-on-calls-in-components': 'error',
51-
'ember/no-pause-test': 'error',
52-
'ember/no-private-routing-service': 'error',
53-
'ember/no-restricted-resolver-tests': 'error',
54-
'ember/no-runloop': 'error',
55-
'ember/no-settled-after-test-helper': 'error',
56-
'ember/no-shadow-route-definition': 'error',
57-
'ember/no-side-effects': 'error',
58-
'ember/no-string-prototype-extensions': 'error',
59-
'ember/no-test-and-then': 'error',
60-
'ember/no-test-import-export': 'error',
61-
'ember/no-test-module-for': 'error',
62-
'ember/no-test-support-import': 'error',
63-
'ember/no-test-this-render': 'error',
64-
'ember/no-tracked-properties-from-args': 'error',
65-
'ember/no-try-invoke': 'error',
66-
'ember/no-unnecessary-route-path-option': 'error',
67-
'ember/no-volatile-computed-properties': 'error',
68-
'ember/prefer-ember-test-helpers': 'error',
69-
'ember/require-computed-macros': 'error',
70-
'ember/require-computed-property-dependencies': 'error',
71-
'ember/require-return-from-computed': 'error',
72-
'ember/require-super-in-lifecycle-hooks': 'error',
73-
'ember/require-tagless-components': 'error',
74-
'ember/require-valid-css-selector-in-test-helpers': 'error',
75-
'ember/routes-segments-snake-case': 'error',
76-
'ember/use-brace-expansion': 'error',
77-
'ember/use-ember-data-rfc-395-imports': 'error'
78-
};
8+
"ember/avoid-leaking-state-in-ember-objects": "error",
9+
"ember/avoid-using-needs-in-controllers": "error",
10+
"ember/classic-decorator-hooks": "error",
11+
"ember/classic-decorator-no-classic-methods": "error",
12+
"ember/closure-actions": "error",
13+
"ember/jquery-ember-run": "error",
14+
"ember/new-module-imports": "error",
15+
"ember/no-actions-hash": "error",
16+
"ember/no-arrow-function-computed-properties": "error",
17+
"ember/no-assignment-of-untracked-properties-used-in-tracking-contexts": "error",
18+
"ember/no-at-ember-render-modifiers": "error",
19+
"ember/no-attrs-in-components": "error",
20+
"ember/no-attrs-snapshot": "error",
21+
"ember/no-capital-letters-in-routes": "error",
22+
"ember/no-classic-classes": "error",
23+
"ember/no-classic-components": "error",
24+
"ember/no-component-lifecycle-hooks": "error",
25+
"ember/no-computed-properties-in-native-classes": "error",
26+
"ember/no-controller-access-in-routes": "error",
27+
"ember/no-deeply-nested-dependent-keys-with-each": "error",
28+
"ember/no-deprecated-router-transition-methods": "error",
29+
"ember/no-duplicate-dependent-keys": "error",
30+
"ember/no-ember-super-in-es-classes": "error",
31+
"ember/no-ember-testing-in-module-scope": "error",
32+
"ember/no-empty-glimmer-component-classes": "error",
33+
"ember/no-function-prototype-extensions": "error",
34+
"ember/no-get-with-default": "error",
35+
"ember/no-get": "error",
36+
"ember/no-global-jquery": "error",
37+
"ember/no-implicit-injections": "error",
38+
"ember/no-incorrect-calls-with-inline-anonymous-functions": "error",
39+
"ember/no-incorrect-computed-macros": "error",
40+
"ember/no-invalid-debug-function-arguments": "error",
41+
"ember/no-invalid-dependent-keys": "error",
42+
"ember/no-invalid-test-waiters": "error",
43+
"ember/no-jquery": "error",
44+
"ember/no-legacy-test-waiters": "error",
45+
"ember/no-mixins": "error",
46+
"ember/no-new-mixins": "error",
47+
"ember/no-noop-setup-on-error-in-before": "error",
48+
"ember/no-observers": "error",
49+
"ember/no-old-shims": "error",
50+
"ember/no-on-calls-in-components": "error",
51+
"ember/no-pause-test": "error",
52+
"ember/no-private-routing-service": "error",
53+
"ember/no-restricted-resolver-tests": "error",
54+
"ember/no-runloop": "error",
55+
"ember/no-settled-after-test-helper": "error",
56+
"ember/no-shadow-route-definition": "error",
57+
"ember/no-side-effects": "error",
58+
"ember/no-string-prototype-extensions": "error",
59+
"ember/no-test-and-then": "error",
60+
"ember/no-test-import-export": "error",
61+
"ember/no-test-module-for": "error",
62+
"ember/no-test-support-import": "error",
63+
"ember/no-test-this-render": "error",
64+
"ember/no-tracked-properties-from-args": "error",
65+
"ember/no-try-invoke": "error",
66+
"ember/no-unnecessary-route-path-option": "error",
67+
"ember/no-volatile-computed-properties": "error",
68+
"ember/prefer-ember-test-helpers": "error",
69+
"ember/require-computed-macros": "error",
70+
"ember/require-computed-property-dependencies": "error",
71+
"ember/require-return-from-computed": "error",
72+
"ember/require-super-in-lifecycle-hooks": "error",
73+
"ember/require-tagless-components": "error",
74+
"ember/require-valid-css-selector-in-test-helpers": "error",
75+
"ember/routes-segments-snake-case": "error",
76+
"ember/use-brace-expansion": "error",
77+
"ember/use-ember-data-rfc-395-imports": "error"
78+
}

scripts/update-rules.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ function generate(filename, filter) {
4242
* In order to update its content based on rules'
4343
* definitions, execute "npm run update"
4444
*/
45-
module.exports = ${JSON.stringify(recommendedRules, null, 2).replace(/"/g, "'")};
45+
module.exports = ${JSON.stringify(recommendedRules, null, 2)};
4646
`;
4747

4848
fs.writeFileSync(recommendedRulesFile, recommendedRulesContent);

0 commit comments

Comments
 (0)