Merge pull request #2687 from johanrd/day_fix/template-no-arguments-for-html-elements

Post-merge-review: Fix template-no-arguments-for-html-elements: add svg and mathml elements

Author: NullVoxPopuli

lib/rules/template-no-arguments-for-html-elements.js

@@ -1,6 +1,10 @@
-/** @type {import('eslint').Rule.RuleModule} */
 const htmlTags = require('html-tags');
+const svgTags = require('svg-tags');
+const { mathmlTagNames } = require('mathml-tag-names');
+
+const ELEMENT_TAGS = new Set([...htmlTags, ...svgTags, ...mathmlTagNames]);
 
+/** @type {import('eslint').Rule.RuleModule} */
 module.exports = {
   meta: {
     type: 'problem',
@@ -26,23 +30,21 @@ module.exports = {
 
   create(context) {
     const sourceCode = context.sourceCode;
-    const HTML_ELEMENTS = new Set(htmlTags);
 
     return {
       GlimmerElementNode(node) {
-        // Check if this is an HTML element (lowercase)
-        if (!HTML_ELEMENTS.has(node.tag)) {
+        if (!ELEMENT_TAGS.has(node.tag)) {
           return;
         }
 
-        // If the tag name is a variable in scope, it's being used as a component, not an HTML element
+        // A known HTML/SVG tag can still be a component if it's bound in scope
+        // (block param, import, local).
         const scope = sourceCode.getScope(node.parent);
         const isVariable = scope.references.some((ref) => ref.identifier === node.parts[0]);
         if (isVariable) {
           return;
         }
 
-        // Check for @arguments
         for (const attr of node.attributes) {
           if (attr.type === 'GlimmerAttrNode' && attr.name.startsWith('@')) {
             context.report({

package.json

@@ -74,8 +74,10 @@
     "language-tags": "^1.0.9",
     "lodash.camelcase": "^4.3.0",
     "lodash.kebabcase": "^4.1.1",
+    "mathml-tag-names": "^4.0.0",
     "requireindex": "^1.2.0",
-    "snake-case": "^3.0.3"
+    "snake-case": "^3.0.3",
+    "svg-tags": "^1.0.0"
   },
   "devDependencies": {
     "@babel/core": "^7.25.9",

pnpm-lock.yaml

@@ -13,6 +13,13 @@ ruleTester.run('template-no-arguments-for-html-elements', rule, {
     '<template><MyComponent @title="Hello" @onClick={{this.handler}} /></template>',
     '<template><CustomButton @disabled={{true}} /></template>',
     '<template><input value={{this.value}} /></template>',
+    // Custom elements aren't in the html-tags/svg-tags allowlists, so they're
+    // not flagged. Accepted false negative — web component namespace is open.
+    '<template><my-element @foo="x" /></template>',
+    // Namespaced/path component invocations aren't in the allowlists either.
+    '<template><NS.Foo @bar="baz" /></template>',
+    // Named blocks (colon-prefixed) aren't in the allowlists either.
+    '<template><Thing><:slot @item="x">content</:slot></Thing></template>',
     `let div = <template>{{@greeting}}</template>
 
 <template>
@@ -54,5 +61,29 @@ ruleTester.run('template-no-arguments-for-html-elements', rule, {
         },
       ],
     },
+    {
+      // SVG element — in svg-tags allowlist.
+      code: '<template><circle @r="5" /></template>',
+      output: null,
+      errors: [
+        {
+          message:
+            '@arguments can only be used on components, not HTML elements. Use regular attributes instead.',
+          type: 'GlimmerAttrNode',
+        },
+      ],
+    },
+    {
+      // MathML element — in mathml-tag-names allowlist.
+      code: '<template><mfrac @numerator="x" /></template>',
+      output: null,
+      errors: [
+        {
+          message:
+            '@arguments can only be used on components, not HTML elements. Use regular attributes instead.',
+          type: 'GlimmerAttrNode',
+        },
+      ],
+    },
   ],
 });