Fix template-no-invalid-aria-attributes: add type-specific error messages

Author: johanrd

lib/rules/template-no-invalid-aria-attributes.js

@@ -62,6 +62,38 @@ function isValidAriaValue(attrName, value) {
   }
 }
 
+function getExpectedTypeDescription(attrName) {
+  const attrDef = aria.get(attrName);
+  if (!attrDef) {
+    return 'a valid value';
+  }
+  switch (attrDef.type) {
+    case 'boolean':
+      return 'a boolean (true or false)';
+    case 'tristate':
+      return "a boolean or the string 'mixed'";
+    case 'integer':
+      return 'an integer';
+    case 'number':
+      return 'a number';
+    case 'token': {
+      const vals = attrDef.values.map((v) => (typeof v === 'boolean' ? v.toString() : v));
+      return `a single token from: ${vals.join(', ')}`;
+    }
+    case 'tokenlist': {
+      return `a list of tokens from: ${attrDef.values.join(', ')}`;
+    }
+    case 'id':
+      return 'a non-boolean string ID';
+    case 'idlist':
+      return 'a space-separated list of string IDs';
+    case 'string':
+      return 'a string';
+    default:
+      return 'a valid value';
+  }
+}
+
 /** @type {import('eslint').Rule.RuleModule} */
 module.exports = {
   meta: {
@@ -75,7 +107,7 @@ module.exports = {
     schema: [],
     messages: {
       noInvalidAriaAttribute: 'Invalid ARIA attribute: {{attribute}}',
-      invalidAriaAttributeValue: 'Invalid value for ARIA attribute {{attribute}}.',
+      invalidAriaAttributeValue: 'The value for {{attribute}} must be {{expectedType}}.',
     },
     originallyFrom: {
       name: 'ember-template-lint',
@@ -118,7 +150,10 @@ module.exports = {
             context.report({
               node,
               messageId: 'invalidAriaAttributeValue',
-              data: { attribute: node.name },
+              data: {
+                attribute: node.name,
+                expectedType: getExpectedTypeDescription(node.name),
+              },
             });
           }
         }