Skip to content

Commit 8541cd3

Browse files
Merge pull request #2495 from johanrd/fix/2469
Post-merge review of #2469 (`template-no-implicit-this`)
2 parents 805e6a5 + 69a9158 commit 8541cd3

2 files changed

Lines changed: 7 additions & 1 deletion

File tree

lib/rules/template-no-element-event-actions.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,10 @@ module.exports = {
5858
}
5959
} else {
6060
// Flag any mustache value on event attributes
61-
if (attr.value?.type === 'GlimmerMustacheStatement') {
61+
if (
62+
attr.value?.type === 'GlimmerMustacheStatement' ||
63+
attr.value?.type === 'GlimmerConcatStatement'
64+
) {
6265
context.report({ node: attr, messageId: 'noElementEventActions' });
6366
}
6467
}

lib/rules/template-no-implicit-this.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,9 @@ const BUILT_INS = new Set([
2626
'textarea',
2727
'query-params',
2828
'unique-id',
29+
// arg-less components/helpers from the default ember-cli blueprint
30+
'welcome-page',
31+
'rootURL',
2932
]);
3033

3134
// Control-flow built-ins whose params should not be flagged

0 commit comments

Comments
 (0)