Merge pull request #2494 from johanrd/fix/2395

Post-merge review of #2395 (`template-link-href-attributes`)

Author: NullVoxPopuli

lib/rules/template-link-href-attributes.js

@@ -27,6 +27,13 @@ module.exports = {
         const hasHref = node.attributes?.some((attr) => attr.name === 'href');
 
         if (!hasHref) {
+          // Exception: <a> with both role and aria-disabled doesn't need href
+          const hasRole = node.attributes?.some((attr) => attr.name === 'role');
+          const hasAriaDisabled = node.attributes?.some((attr) => attr.name === 'aria-disabled');
+          if (hasRole && hasAriaDisabled) {
+            return;
+          }
+
           context.report({
             node,
             messageId: 'missingHref',

tests/lib/rules/template-link-href-attributes.js

@@ -11,6 +11,11 @@ ruleTester.run('template-link-href-attributes', rule, {
     '<template><a href="/about">About</a></template>',
     '<template><a href="https://example.com">External</a></template>',
     '<template><button>Click me</button></template>',
+    '<template><a role="link" aria-disabled="true">valid</a></template>',
+    '<template><a role="button" aria-disabled="true">valid</a></template>',
+    '<template><a href="">Empty href</a></template>',
+    '<template><a href="#">Hash href</a></template>',
+    '<template><a href={{this.link}}>Dynamic href</a></template>',
   ],
 
   invalid: [
@@ -29,5 +34,10 @@ ruleTester.run('template-link-href-attributes', rule, {
       output: null,
       errors: [{ messageId: 'missingHref' }],
     },
+    {
+      code: '<template><a aria-disabled="true">Disabled only</a></template>',
+      output: null,
+      errors: [{ messageId: 'missingHref' }],
+    },
   ],
 });