Skip to content

Commit 8cabd4b

Browse files
NullVoxPopuliclaude
andcommitted
Simplify shadow tests to use plain functions
Use regular functions instead of helper managers for the fn shadow tests, since only scope shadowing is being verified. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 2eca7f8 commit 8cabd4b

File tree

2 files changed

+7
-20
lines changed

2 files changed

+7
-20
lines changed

packages/@glimmer-workspace/integration-tests/test/keywords/fn-test.ts

Lines changed: 3 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import { castToBrowser } from '@glimmer/debug-util';
22
import { jitSuite, RenderTest, test } from '@glimmer-workspace/integration-tests';
3-
import { helperCapabilities, setHelperManager } from '@glimmer/manager';
43

54
import { template } from '@ember/template-compiler/runtime';
65
import { fn } from '@ember/helper';
@@ -60,19 +59,9 @@ class KeywordFn extends RenderTest {
6059

6160
@test
6261
'can be shadowed'(assert: Assert) {
63-
let fn = setHelperManager(
64-
() => ({
65-
capabilities: helperCapabilities('3.23', { hasValue: true }),
66-
createHelper() {
67-
assert.step('shadowed:success');
68-
return {};
69-
},
70-
getValue() {
71-
return () => {};
72-
},
73-
}),
74-
{}
75-
);
62+
let fn = () => {
63+
assert.step('shadowed:success');
64+
};
7665

7766
let greet = () => {};
7867

smoke-tests/scenarios/basic-test.ts

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -385,17 +385,15 @@ function basicTest(scenarios: Scenarios, appName: string) {
385385
386386
import Component from '@glimmer/component';
387387
import { tracked } from '@glimmer/tracking';
388-
import { helper } from '@ember/component/helper';
389388
390389
module('{{fn}} as keyword (but it is shadowed)', function(hooks) {
391390
setupRenderingTest(hooks);
392391
393392
test('it works', async function(assert) {
394393
// shadows keyword!
395-
const fn = helper(() => {
396-
assert.step('shadowed:fn:create');
397-
return () => {};
398-
});
394+
const fn = () => {
395+
assert.step('shadowed:fn:invoke');
396+
};
399397
400398
class Demo extends Component {
401399
@tracked message = 'hello';
@@ -407,7 +405,7 @@ function basicTest(scenarios: Scenarios, appName: string) {
407405
}
408406
409407
await render(Demo);
410-
assert.verifySteps(['shadowed:fn:create']);
408+
assert.verifySteps(['shadowed:fn:invoke']);
411409
412410
assert.dom('button').hasText('hello');
413411
await click('button');

0 commit comments

Comments
 (0)