Handle permission access errors (#216)

Author: willnode

css/frame.css

@@ -52,3 +52,13 @@ float: left;
 margin: 1em;
 }
 
+
+.exception {
+border: 1px solid #ff0000;
+background-color: rgba(255, 0, 0, 0.2);
+color: #880000;
+padding: 10px;
+border-radius: 5px;
+margin: 20px;
+}
+

edit.php

@@ -34,72 +34,83 @@
     die('ERROR: could not encode value');
   }
 
-  // String
-  if ($_POST['type'] == 'string') {
-    $redis->set($key, $value);
-  }
-
-  // Hash
-  else if (($_POST['type'] == 'hash') && isset($_POST['hkey'])) {
-    if (strlen($_POST['hkey']) > $config['maxkeylen']) {
-      die('ERROR: Your hash key is to long (max length is '.$config['maxkeylen'].')');
+  try {
+    // String
+    if ($_POST['type'] == 'string') {
+      $redis->set($key, $value);
     }
 
-    if ($edit && !$redis->hExists($key, input_convert($_POST['hkey']))) {
-      $redis->hDel($key, input_convert($_GET['hkey']));
+    // Hash
+    else if (($_POST['type'] == 'hash') && isset($_POST['hkey'])) {
+      if (strlen($_POST['hkey']) > $config['maxkeylen']) {
+        die('ERROR: Your hash key is to long (max length is '.$config['maxkeylen'].')');
+      }
+
+      if ($edit && !$redis->hExists($key, input_convert($_POST['hkey']))) {
+        $redis->hDel($key, input_convert($_GET['hkey']));
+      }
+
+      $redis->hSet($key, input_convert($_POST['hkey']), $value);
     }
 
-    $redis->hSet($key, input_convert($_POST['hkey']), $value);
-  }
+    // List
+    else if (($_POST['type'] == 'list') && isset($_POST['index'])) {
+      $size = $redis->lLen($key);
+
+      if (($_POST['index'] == '') ||
+          ($_POST['index'] == $size)) {
+        // Push it at the end
+        $redis->rPush($key, $value);
+      } else if ($_POST['index'] == -1) {
+        // Push it at the start
+        $redis->lPush($key, $value);
+      } else if (($_POST['index'] >= 0) &&
+                ($_POST['index'] < $size)) {
+        // Overwrite an index
+        $redis->lSet($key, input_convert($_POST['index']), $value);
+      } else {
+        die('ERROR: Out of bounds index');
+      }
+    }
 
-  // List
-  else if (($_POST['type'] == 'list') && isset($_POST['index'])) {
-    $size = $redis->lLen($key);
-
-    if (($_POST['index'] == '') ||
-        ($_POST['index'] == $size)) {
-      // Push it at the end
-      $redis->rPush($key, $value);
-    } else if ($_POST['index'] == -1) {
-      // Push it at the start
-      $redis->lPush($key, $value);
-    } else if (($_POST['index'] >= 0) &&
-               ($_POST['index'] < $size)) {
-      // Overwrite an index
-      $redis->lSet($key, input_convert($_POST['index']), $value);
-    } else {
-      die('ERROR: Out of bounds index');
+    // Set
+    else if ($_POST['type'] == 'set') {
+      if ($_POST['value'] != $_POST['oldvalue']) {
+        // The only way to edit a Set value is to add it and remove the old value.
+        $redis->sRem($key, encodeOrDecode('save', $key, input_convert($_POST['oldvalue'])));
+        $redis->sAdd($key, $value);
+      }
     }
-  }
 
-  // Set
-  else if ($_POST['type'] == 'set') {
-    if ($_POST['value'] != $_POST['oldvalue']) {
-      // The only way to edit a Set value is to add it and remove the old value.
-      $redis->sRem($key, encodeOrDecode('save', $key, input_convert($_POST['oldvalue'])));
-      $redis->sAdd($key, $value);
+    // ZSet
+    else if (($_POST['type'] == 'zset') && isset($_POST['score']) && is_numeric($_POST['score'])) {
+      // The only way to edit a ZSet value is to add it and remove the old value.
+      $redis->zRem($key, encodeOrDecode('save', $key, input_convert($_POST['oldvalue'])));
+      $redis->zAdd($key, input_convert($_POST['score']), $value);
     }
-  }
 
-  // ZSet
-  else if (($_POST['type'] == 'zset') && isset($_POST['score']) && is_numeric($_POST['score'])) {
-    // The only way to edit a ZSet value is to add it and remove the old value.
-    $redis->zRem($key, encodeOrDecode('save', $key, input_convert($_POST['oldvalue'])));
-    $redis->zAdd($key, input_convert($_POST['score']), $value);
-  }
 
 
+    // Refresh the top so the key tree is updated.
+    require 'includes/header.inc.php';
 
-  // Refresh the top so the key tree is updated.
-  require 'includes/header.inc.php';
+    ?>
+    <script>
+    top.location.href = top.location.pathname+'?view&s=<?php echo $server['id']?>&d=<?php echo $server['db']?>&key=<?php echo urlencode($_POST['key'])?>';
+    </script>
+    <?php
 
-  ?>
-  <script>
-  top.location.href = top.location.pathname+'?view&s=<?php echo $server['id']?>&d=<?php echo $server['db']?>&key=<?php echo urlencode($_POST['key'])?>';
-  </script>
-  <?php
+    require 'includes/footer.inc.php';
+  } catch (\Predis\Response\ServerException $th) {
+    require 'includes/header.inc.php';
+    ?>
+    <div class="exception">
+      <h3><?php echo $th->getMessage() ?></h3>
+    </div>
+    <?php
+    require 'includes/footer.inc.php';
+  }
 
-  require 'includes/footer.inc.php';
   die;
 }
 

index.php

@@ -82,7 +82,13 @@ function print_namespace($item, $name, $fullkey, $islast) {
 
         // Get the number of items in the key.
         if (!isset($config['faster']) || !$config['faster']) {
-          switch ($redis->type($fullkey)) {
+          $type = '';
+          try {
+            $type = $redis->type($fullkey);
+          } catch (\Predis\Response\ServerException $th) {
+            $class[] = 'empty';
+          }
+          switch ($type) {
             case 'hash':
               $len = $redis->hLen($fullkey);
               break;

view.php

@@ -17,8 +17,18 @@
   die;
 }
 
-$type   = $redis->type($_GET['key']);
-$exists = $redis->exists($_GET['key']);
+$type   = ''; 
+$exists = false;
+try {
+  $type   = $redis->type($_GET['key']);
+  $exists = $redis->exists($_GET['key']);
+} catch (\Predis\Response\ServerException $th) {
+  ?>
+  <div class="exception">
+    <h3><?php echo $th->getMessage() ?></h3>
+  </div>
+  <?php
+}
 
 $count_elements_page = isset($config['count_elements_page']) ? $config['count_elements_page'] : false;
 $page_num_request    = isset($_GET['page']) ? (int)$_GET['page'] : 1;