Normalize Ruby style and docs

Clean up line continuations, block forwarding, and memoization
naming across tree helpers while keeping behavior unchanged. Update
documentation/comments to match the refactored layout.

Author: evolve75

lib/tree.rb

@@ -316,9 +316,11 @@ def marshal_load(dumped_tree_array)
     # @return [String] A string representation of the node.
     def to_s
       content_str = @content.nil? ? '<Empty>' : @content.to_s
-      "Node Name: #{@name} Content: #{content_str} " \
-        "Parent: #{root? ? '<None>' : @parent.name.to_s} "       \
+      [
+        "Node Name: #{@name} Content: #{content_str}",
+        "Parent: #{root? ? '<None>' : @parent.name}",
         "Children: #{@children.length} Total Nodes: #{size}"
+      ].join(' ')
     end
 
     # Returns the requested node from the set of immediate children.
@@ -354,6 +356,7 @@ def [](name_or_index)
         @children_hash[name_or_index]
       end
     end
+
     # Provides a comparison operation for the nodes.
     #
     # Comparison is based on the natural ordering of the node name objects.

lib/tree/binarytree.rb

@@ -119,7 +119,7 @@ def right_child?
     def add(child)
       raise ArgumentError, 'Already has two child nodes' if @children.size == 2
 
-      super(child)
+      super
     end
 
     # Instantiate and insert child nodes from data in a Ruby +Hash+
@@ -152,10 +152,9 @@ def add(child)
     # @raise [ArgumentError] This exception is raised if a non-hash is passed.
     # @return [Array] Array of child nodes added
     def add_from_hash(hashed_subtree)
-      raise ArgumentError, 'Too many children'\
-                           if hashed_subtree.size + @children.size > 2
+      raise ArgumentError, 'Too many children' if hashed_subtree.size + @children.size > 2
 
-      super(hashed_subtree)
+      super
     end
 
     # Performs in-order traversal (including this node).
@@ -203,8 +202,8 @@ def inordered_each
     #
     # @raise [ArgumentError] If the index is out of limits.
     def set_child_at(child, at_index)
-      raise ArgumentError, 'A binary tree cannot have more than two children.'\
-                           unless (0..1).include? at_index
+      raise ArgumentError,
+            'A binary tree cannot have more than two children.' unless (0..1).include? at_index
 
       old_child = @children[at_index]
       if old_child && old_child != child

lib/tree/utils/hash_converter.rb

@@ -98,11 +98,9 @@ module ClassMethods
         #                        values that are not hashes or nils.
 
         def from_hash(hash)
-          raise ArgumentError, 'Argument must be a type of hash'\
-                               unless hash.is_a?(Hash)
+          raise ArgumentError, 'Argument must be a type of hash' unless hash.is_a?(Hash)
 
-          raise ArgumentError, 'Hash must have one top-level element'\
-                               if hash.size != 1
+          raise ArgumentError, 'Hash must have one top-level element' if hash.size != 1
 
           root, children = hash.first
 
@@ -147,8 +145,7 @@ def from_hash(hash)
       # @return [Array] Array of child nodes added
       # @see ClassMethods#from_hash
       def add_from_hash(children)
-        raise ArgumentError, 'Argument must be a type of hash'\
-                             unless children.is_a?(Hash)
+        raise ArgumentError, 'Argument must be a type of hash' unless children.is_a?(Hash)
 
         child_nodes = []
         children.each do |child, grandchildren|

lib/tree/utils/metrics_methods.rb

@@ -52,7 +52,7 @@ module TreeMetricsHandler
       #
       # @return [Integer] Total number of nodes in this (sub)tree.
       def size
-        @node_size ||= count
+        @size ||= count
       end
 
       # @!attribute [r] length

lib/tree/utils/navigation_methods.rb

@@ -43,9 +43,9 @@ def children?
       alias has_children? children? # @todo: Aliased for eventual replacement
 
       # An array of all the immediate children of this node.
-      def children(&block)
+      def children(&)
         if block_given?
-          @children.each(&block)
+          @children.each(&)
           self
         else
           @children.clone
@@ -108,6 +108,7 @@ def siblings
           siblings = []
           parent.send(:children_array).each do |my_sibling|
             next unless my_sibling
+
             siblings << my_sibling if my_sibling != self
           end
           siblings
@@ -116,7 +117,7 @@ def siblings
 
       # +true+ if this node is the only child of its parent.
       def only_child?
-        root? ? true : parent.send(:children_array).count { |child| child } == 1
+        root? || parent.send(:children_array).one? { |child| child }
       end
 
       alias is_only_child? only_child? # @todo: Aliased for eventual replacement

lib/tree/utils/structure_methods.rb

@@ -53,18 +53,20 @@ def add(child, at_index = -1)
 
         # Lazy man's unique test, won't test if children of child are unique in
         # this tree too.
-        raise "Child #{child.name} already added!"\
-              if @children_hash.include?(child.name)
+        raise "Child #{child.name} already added!" if @children_hash.include?(child.name)
 
         child.parent&.remove! child # Detach from the old parent
 
         if insertion_range.include?(at_index)
           @children.insert(at_index, child)
         else
-          raise 'Attempting to insert a child at a non-existent location'\
-                " (#{at_index}) "\
-                'when only positions from '\
-                "#{insertion_range.min} to #{insertion_range.max} exist."
+          message = [
+            'Attempting to insert a child at a non-existent location',
+            "(#{at_index})",
+            'when only positions from',
+            "#{insertion_range.min} to #{insertion_range.max} exist."
+          ].join(' ')
+          raise message
         end
 
         @children_hash[child.name] = child
@@ -95,11 +97,11 @@ def rename(new_name)
 
       # Renames the specified child node
       def rename_child(old_name, new_name)
-        raise ArgumentError, "Invalid child name specified: #{old_name}"\
-              unless @children_hash.key?(old_name)
+        raise ArgumentError,
+              "Invalid child name specified: #{old_name}" unless @children_hash.key?(old_name)
 
-        raise ArgumentError, "Child name already exists: #{new_name}"\
-              if @children_hash.key?(new_name)
+        raise ArgumentError,
+              "Child name already exists: #{new_name}" if @children_hash.key?(new_name)
 
         @children_hash[new_name] = @children_hash.delete(old_name)
         @children_hash[new_name].name = new_name
@@ -180,7 +182,7 @@ def clear_root_cache!
       def invalidate_size_cache_upwards!
         node = self
         while node
-          node.instance_variable_set(:@node_size, nil)
+          node.instance_variable_set(:@size, nil)
           node = node.parent
         end
       end

lib/tree/utils/traversal_methods.rb

@@ -55,8 +55,8 @@ def each # :yields: node
       end
 
       # Traverses the (sub)tree rooted at this node in pre-ordered sequence.
-      def preordered_each(&block) # :yields: node
-        each(&block)
+      def preordered_each(&) # :yields: node
+        each(&)
       end
 
       # Traverses the (sub)tree rooted at this node in post-ordered sequence.
@@ -137,7 +137,7 @@ def print_tree(level = node_depth, max_depth = nil,
                      block = lambda { |node, prefix|
                                puts "#{prefix} #{node.name}"
                              })
-        prefix = ''.dup # dup NEEDs to be invoked to make this mutable.
+        prefix = ''.dup # dup must be invoked to make this mutable.
 
         if root?
           prefix << '*'