Avoid Measuring Cell Nodes with Empty Size Range (#3000)

* Always avoid measuring cell nodes with empty bounds

* Be lenient

* Add required assertion comment

* Avoid importing non-modular header publicly

Author: Adlai Holler

AsyncDisplayKit/Details/ASDataController.mm

@@ -173,6 +173,8 @@ - (void)batchLayoutNodesFromContexts:(NSArray<ASIndexedNodeContext *> *)contexts
  */
 - (void)_layoutNode:(ASCellNode *)node withConstrainedSize:(ASSizeRange)constrainedSize
 {
+  ASDisplayNodeAssert(ASSizeRangeHasSignificantArea(constrainedSize), @"Attempt to layout cell node with invalid size range %@", NSStringFromASSizeRange(constrainedSize));
+
   CGRect frame = CGRectZero;
   frame.size = [node layoutThatFits:constrainedSize].size;
   node.frame = frame;
@@ -214,7 +216,12 @@ - (void)_batchLayoutAndInsertNodesFromContexts:(NSArray<ASIndexedNodeContext *>
       node = [[ASCellNode alloc] init]; // Fallback to avoid crash for production apps.
     }
 
-    [self _layoutNode:node withConstrainedSize:context.constrainedSize];
+    // Layout the node if the size range is valid.
+    ASSizeRange sizeRange = context.constrainedSize;
+    if (ASSizeRangeHasSignificantArea(sizeRange)) {
+      [self _layoutNode:node withConstrainedSize:sizeRange];
+    }
+
 #if AS_MEASURE_AVOIDED_DATACONTROLLER_WORK
     [ASDataController _didLayoutNode];
 #endif
@@ -893,7 +900,9 @@ - (void)_relayoutNodesOfKind:(NSString *)kind
       RETURN_IF_NO_DATASOURCE();
       NSIndexPath *indexPath = [NSIndexPath indexPathForRow:rowIndex inSection:sectionIndex];
       ASSizeRange constrainedSize = [self constrainedSizeForNodeOfKind:kind atIndexPath:indexPath];
-      [self _layoutNode:node withConstrainedSize:constrainedSize];
+      if (ASSizeRangeHasSignificantArea(constrainedSize)) {
+        [self _layoutNode:node withConstrainedSize:constrainedSize];
+      }
       rowIndex += 1;
     }
     sectionIndex += 1;

AsyncDisplayKit/Layout/ASDimension.h

@@ -211,6 +211,15 @@ extern ASSizeRange const ASSizeRangeZero;
  */
 extern ASSizeRange const ASSizeRangeUnconstrained;
 
+/**
+ * Returns whether a size range has > 0.1 max width and max height.
+ */
+ASDISPLAYNODE_INLINE AS_WARN_UNUSED_RESULT BOOL ASSizeRangeHasSignificantArea(ASSizeRange sizeRange)
+{
+  static CGFloat const limit = 0.1;
+  return (sizeRange.max.width > limit && sizeRange.max.height > limit);
+}
+
 /**
  * Creates an ASSizeRange with provided min and max size.
  */