refactor: extract test StateChart definitions to tests/machines/ (#591)

Move reusable StateChart class definitions from inline test code to
dedicated modules under tests/machines/, organized by feature:

- workflow/: CampaignMachine variants, ReverseTrafficLightMachine
- error/: ErrorInGuardSC, ErrorInActionSC, ErrorInErrorHandlerSC, etc.
- validators/: OrderValidation, MultiValidator, ValidatorWithCond, etc.
- compound/: ShireToRivendell, MoriaExpedition, MiddleEarthJourney, etc.
- history/: GollumPersonality variants, DeepMemoryOfMoria, ShallowMoria
- parallel/: WarOfTheRing, TwoTowers, Session variants
- eventless/: RingCorruption variants, BeaconChain, AutoAdvance, etc.
- in_condition/: Fellowship, GateOfMoria, CombinedGuard, etc.
- donedata/: DestroyTheRing, NestedQuestDoneData, QuestForErebor variants

Test files now import from these modules instead of defining classes
inline. Machines that test invalid definitions or use closures remain
inline in test files.

Author: fgmacedo

tests/conftest.py

@@ -22,86 +22,32 @@ def current_time():
 
 @pytest.fixture()
 def campaign_machine():
-    "Define a new class for each test"
-    from statemachine import State
-    from statemachine import StateChart
-
-    class CampaignMachine(StateChart):
-        "A workflow machine"
-
-        draft = State(initial=True)
-        producing = State("Being produced")
-        closed = State(final=True)
-
-        add_job = draft.to(draft) | producing.to(producing)
-        produce = draft.to(producing)
-        deliver = producing.to(closed)
+    from tests.machines.workflow.campaign_machine import CampaignMachine
 
     return CampaignMachine
 
 
 @pytest.fixture()
 def campaign_machine_with_validator():
-    "Define a new class for each test"
-    from statemachine import State
-    from statemachine import StateChart
-
-    class CampaignMachine(StateChart):
-        "A workflow machine"
-
-        draft = State(initial=True)
-        producing = State("Being produced")
-        closed = State(final=True)
-
-        add_job = draft.to(draft) | producing.to(producing)
-        produce = draft.to(producing, validators="can_produce")
-        deliver = producing.to(closed)
+    from tests.machines.workflow.campaign_machine_with_validator import (
+        CampaignMachineWithValidator,
+    )
 
-        def can_produce(*args, **kwargs):
-            if "goods" not in kwargs:
-                raise LookupError("Goods not found.")
-
-    return CampaignMachine
+    return CampaignMachineWithValidator
 
 
 @pytest.fixture()
 def campaign_machine_with_final_state():
-    "Define a new class for each test"
-    from statemachine import State
-    from statemachine import StateChart
-
-    class CampaignMachine(StateChart):
-        "A workflow machine"
-
-        draft = State(initial=True)
-        producing = State("Being produced")
-        closed = State(final=True)
-
-        add_job = draft.to(draft) | producing.to(producing)
-        produce = draft.to(producing)
-        deliver = producing.to(closed)
+    from tests.machines.workflow.campaign_machine import CampaignMachine
 
     return CampaignMachine
 
 
 @pytest.fixture()
 def campaign_machine_with_values():
-    "Define a new class for each test"
-    from statemachine import State
-    from statemachine import StateChart
-
-    class CampaignMachineWithKeys(StateChart):
-        "A workflow machine"
-
-        draft = State(initial=True, value=1)
-        producing = State("Being produced", value=2)
-        closed = State(value=3, final=True)
-
-        add_job = draft.to(draft) | producing.to(producing)
-        produce = draft.to(producing)
-        deliver = producing.to(closed)
+    from tests.machines.workflow.campaign_machine_with_values import CampaignMachineWithValues
 
-    return CampaignMachineWithKeys
+    return CampaignMachineWithValues
 
 
 @pytest.fixture()
@@ -153,18 +99,7 @@ def classic_traffic_light_machine_allow_event(classic_traffic_light_machine):
 
 @pytest.fixture()
 def reverse_traffic_light_machine():
-    from statemachine import State
-    from statemachine import StateChart
-
-    class ReverseTrafficLightMachine(StateChart):
-        "A traffic light machine"
-
-        green = State(initial=True)
-        yellow = State()
-        red = State()
-
-        stop = red.from_(yellow, green, red)
-        cycle = green.from_(red) | yellow.from_(green) | red.from_(yellow) | red.from_.itself()
+    from tests.machines.workflow.reverse_traffic_light import ReverseTrafficLightMachine
 
     return ReverseTrafficLightMachine
 

tests/machines/compound/__init__.py

@@ -0,0 +1,25 @@
+from statemachine import State
+from statemachine import StateChart
+
+
+class MiddleEarthJourney(StateChart):
+    class rivendell(State.Compound):
+        council = State(initial=True)
+        preparing = State()
+
+        get_ready = council.to(preparing)
+
+    class moria(State.Compound):
+        gates = State(initial=True)
+        bridge = State(final=True)
+
+        cross = gates.to(bridge)
+
+    class lothlorien(State.Compound):
+        mirror = State(initial=True)
+        departure = State(final=True)
+
+        leave = mirror.to(departure)
+
+    march_to_moria = rivendell.to(moria)
+    march_to_lorien = moria.to(lothlorien)

tests/machines/compound/middle_earth_journey.py

@@ -0,0 +1,18 @@
+from statemachine import State
+from statemachine import StateChart
+
+
+class MiddleEarthJourneyTwoCompounds(StateChart):
+    class rivendell(State.Compound):
+        council = State(initial=True)
+        preparing = State()
+
+        get_ready = council.to(preparing)
+
+    class moria(State.Compound):
+        gates = State(initial=True)
+        bridge = State(final=True)
+
+        cross = gates.to(bridge)
+
+    march_to_moria = rivendell.to(moria)

tests/machines/compound/middle_earth_journey_two_compounds.py

@@ -0,0 +1,25 @@
+from statemachine import State
+from statemachine import StateChart
+
+
+class MiddleEarthJourneyWithFinals(StateChart):
+    class rivendell(State.Compound):
+        council = State(initial=True)
+        preparing = State(final=True)
+
+        get_ready = council.to(preparing)
+
+    class moria(State.Compound):
+        gates = State(initial=True)
+        bridge = State(final=True)
+
+        cross = gates.to(bridge)
+
+    class lothlorien(State.Compound):
+        mirror = State(initial=True)
+        departure = State(final=True)
+
+        leave = mirror.to(departure)
+
+    march_to_moria = rivendell.to(moria)
+    march_to_lorien = moria.to(lothlorien)

tests/machines/compound/middle_earth_journey_with_finals.py

@@ -0,0 +1,15 @@
+from statemachine import State
+from statemachine import StateChart
+
+
+class MoriaExpedition(StateChart):
+    class moria(State.Compound):
+        class upper_halls(State.Compound):
+            entrance = State(initial=True)
+            bridge = State(final=True)
+
+            cross = entrance.to(bridge)
+
+        assert isinstance(upper_halls, State)
+        depths = State(final=True)
+        descend = upper_halls.to(depths)

tests/machines/compound/moria_expedition.py

@@ -0,0 +1,18 @@
+from statemachine import State
+from statemachine import StateChart
+
+
+class MoriaExpeditionWithEscape(StateChart):
+    class moria(State.Compound):
+        class upper_halls(State.Compound):
+            entrance = State(initial=True)
+            bridge = State()
+
+            cross = entrance.to(bridge)
+
+        assert isinstance(upper_halls, State)
+        depths = State(final=True)
+        descend = upper_halls.to(depths)
+
+    daylight = State(final=True)
+    escape = moria.to(daylight)

tests/machines/compound/moria_expedition_with_escape.py

@@ -0,0 +1,13 @@
+from statemachine import State
+from statemachine import StateChart
+
+
+class QuestForErebor(StateChart):
+    class lonely_mountain(State.Compound):
+        approach = State(initial=True)
+        inside = State(final=True)
+
+        enter_mountain = approach.to(inside)
+
+    victory = State(final=True)
+    done_state_lonely_mountain = lonely_mountain.to(victory)

tests/machines/compound/quest_for_erebor.py

@@ -0,0 +1,13 @@
+from statemachine import State
+from statemachine import StateChart
+
+
+class ShireToRivendell(StateChart):
+    class shire(State.Compound):
+        bag_end = State(initial=True)
+        green_dragon = State()
+
+        visit_pub = bag_end.to(green_dragon)
+
+    road = State(final=True)
+    depart = shire.to(road)