PostgreSQL: fix broken main (test compile, clippy, keyword sort, doctest) (#23)

* chore(tests): restore green main; fix clippy and keyword sort regressions

`cargo test --all-features` and `cargo clippy --all-targets --all-features
-- -D warnings` were both failing on `main`; CI never ran on the fork to
catch it. This commit makes them green so subsequent PRs can be
verified.

Test compile errors:
- `Statement::AlterTable` was refactored from struct to tuple form
  carrying `AlterTable`. Update 10 ATTACH/DETACH PARTITION test sites
  in `sqlparser_postgres.rs` to match the new shape.
- `CreateView` gained a `with_data` field (added with the
  `WITH [NO] DATA` parser support). Add `with_data: _,` to 6 destructure
  sites in `sqlparser_common.rs`.

Test runtime failures:
- `all_keywords_sorted`: `CONFIGURATION`, `INLINE`, and `TRANSFORM` were
  inserted out of ASCII order in `keywords.rs`; move each to its
  alphabetical slot.
- `alter_procedure_rename` / `alter_procedure_set_search_path` /
  `parse_fulltext_column_and_index_in_postgres`: `verified_stmt` round-trip
  fails because Display canonicalises type names and access methods to
  uppercase. Update the input SQL to match.

Lib clippy regressions (forbidden via `#![forbid(clippy::unreachable)]`
and `-D warnings`):
- `parse_create_aggregate_options` PARALLEL arm: replace `_ => unreachable!()`
  with an explicit `Internal parser error` so `clippy::unreachable` is
  satisfied.
- `parse_create_aggregate_args`: drop the let-and-return.
- `parse_create_rule` INSTEAD/ALSO: collapse the always-false else-if
  branches into a single optional-keyword consume.

Doctest:
- `Statement::CreateStatistics` doc block was missing its opening
  ```sql fence.

Spans:
- Drop the duplicate `ForceRowLevelSecurity` / `NoForceRowLevelSecurity`
  arms in `AlterTableOperation::span()` (warnings, but `-D warnings`
  blocks clippy).

* chore(ci): fix lint, no-std, RAT, and benchmark-lint regressions

CI on `main` was failing five jobs (test/lint/compile-no-std/RAT/
benchmark-lint). The first commit on this branch fixed test compile +
runtime + a few clippy and doctest issues found locally. CI surfaced
the rest. This commit covers them.

`lint` (clippy 1.95 — 8 collapsible_match errors)
- Fold inner `if` blocks into match guards in `parse_sql` (END token
  delimiter), `parse_compound_field` (period-qualified identifier), the
  DO/loop sequence terminator, and the five `HiveRowFormat::DELIMITED`
  arms (FIELDS / COLLECTION / MAP / LINES / NULL DEFINED AS).

`compile-no-std` (`thumbv6m-none-eabi`)
- `src/ast/table_constraints.rs` introduced an EXCLUDE-constraint type
  with `pub operator: String` but did not import `String` in the
  `#[cfg(not(feature = "std"))]` alloc block. Add `string::String`.

`Release Audit Tool (RAT)`
- Add `CLAUDE.md` to `dev/release/rat_exclude_files.txt` next to the
  existing `AGENTS.md` exclusion. Both are agent-guideline files that
  do not need an Apache header.

`benchmark-lint`
- `sqlparser_bench/Cargo.toml` referenced the path-dep as `sqlparser`
  but the fork's package was renamed to `pgmold-sqlparser`. Add the
  `package = "pgmold-sqlparser"` rename so the bench resolves.

Verified locally on rustc 1.95.0:
  cargo fmt --all -- --check
  cargo clippy --all-targets --all-features -- -D warnings
  cargo test --all-features
  cargo check --no-default-features --target thumbv6m-none-eabi
  (cd sqlparser_bench && cargo clippy --all-targets --all-features -- -D warnings)

Author: fmguerreiro

dev/release/rat_exclude_files.txt

@@ -6,4 +6,5 @@ dev/release/rat_exclude_files.txt
 sqlparser_bench/img/flamegraph.svg
 **Cargo.lock
 filtered_rat.txt
-AGENTS.md
+AGENTS.md
+CLAUDE.md

sqlparser_bench/Cargo.toml

@@ -23,7 +23,7 @@ authors = ["Dandandan <danielheres@gmail.com>"]
 edition = "2018"
 
 [dependencies]
-sqlparser = { path = "../" }
+sqlparser = { package = "pgmold-sqlparser", path = "../" }
 
 [dev-dependencies]
 criterion = "0.8"

src/ast/ddl.rs

@@ -43,15 +43,14 @@ use crate::ast::{
     },
     ArgMode, AttachedToken, CommentDef, ConditionalStatements, CreateFunctionBody,
     CreateFunctionUsing, CreateServerOption, CreateTableLikeKind, CreateTableOptions,
-    CreateViewParams, DataType, Expr,
-    FileFormat, FunctionBehavior, FunctionCalledOnNull, FunctionDefinitionSetParam, FunctionDesc,
-    FunctionDeterminismSpecifier, FunctionParallel, FunctionSecurity, HiveDistributionStyle,
-    HiveFormat, HiveIOFormat, HiveRowFormat, HiveSetLocation, Ident, InitializeKind,
-    MySQLColumnPosition, ObjectName, OnCommit, OneOrManyWithParens, OperateFunctionArg,
-    OrderByExpr, ProjectionSelect, Query, RefreshModeKind, ResetConfig, RowAccessPolicy,
-    SequenceOptions, Spanned, SqlOption, StorageLifecyclePolicy, StorageSerializationPolicy,
-    TableVersion, Tag, TriggerEvent, TriggerExecBody, TriggerObject, TriggerPeriod,
-    TriggerReferencing, Value, ValueWithSpan, WrappedCollection,
+    CreateViewParams, DataType, Expr, FileFormat, FunctionBehavior, FunctionCalledOnNull,
+    FunctionDefinitionSetParam, FunctionDesc, FunctionDeterminismSpecifier, FunctionParallel,
+    FunctionSecurity, HiveDistributionStyle, HiveFormat, HiveIOFormat, HiveRowFormat,
+    HiveSetLocation, Ident, InitializeKind, MySQLColumnPosition, ObjectName, OnCommit,
+    OneOrManyWithParens, OperateFunctionArg, OrderByExpr, ProjectionSelect, Query, RefreshModeKind,
+    ResetConfig, RowAccessPolicy, SequenceOptions, Spanned, SqlOption, StorageLifecyclePolicy,
+    StorageSerializationPolicy, TableVersion, Tag, TriggerEvent, TriggerExecBody, TriggerObject,
+    TriggerPeriod, TriggerReferencing, Value, ValueWithSpan, WrappedCollection,
 };
 use crate::display_utils::{DisplayCommaSeparated, Indent, NewLine, SpaceOrNewline};
 use crate::keywords::Keyword;
@@ -3555,7 +3554,6 @@ impl fmt::Display for DistStyle {
     }
 }
 
-
 #[derive(Debug, Clone, PartialEq, PartialOrd, Eq, Ord, Hash)]
 #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
 #[cfg_attr(feature = "visitor", derive(Visit, VisitMut))]
@@ -5919,7 +5917,11 @@ impl fmt::Display for CreateForeignTable {
         write!(
             f,
             "CREATE FOREIGN TABLE {if_not_exists}{name} ({columns}) SERVER {server_name}",
-            if_not_exists = if self.if_not_exists { "IF NOT EXISTS " } else { "" },
+            if_not_exists = if self.if_not_exists {
+                "IF NOT EXISTS "
+            } else {
+                ""
+            },
             name = self.name,
             columns = display_comma_separated(&self.columns),
             server_name = self.server_name,
@@ -6967,11 +6969,7 @@ impl fmt::Display for CreateUserMapping {
         }
         write!(f, " FOR {} SERVER {}", self.user, self.server_name)?;
         if let Some(options) = &self.options {
-            write!(
-                f,
-                " OPTIONS ({})",
-                display_comma_separated(options)
-            )?;
+            write!(f, " OPTIONS ({})", display_comma_separated(options))?;
         }
         Ok(())
     }

src/ast/mod.rs

@@ -90,7 +90,7 @@ pub use self::ddl::{
     SecurityLabelObjectKind, StatisticsKind, TagsColumnOption, TransformElement, TriggerObjectKind,
     Truncate, UserDefinedTypeCompositeAttributeDef, UserDefinedTypeInternalLength,
     UserDefinedTypeRangeOption, UserDefinedTypeRepresentation, UserDefinedTypeSqlDefinitionOption,
-    UserDefinedTypeStorage, UserMappingUser, ViewColumnDef
+    UserDefinedTypeStorage, UserMappingUser, ViewColumnDef,
 };
 pub use self::dml::{
     Delete, Insert, Merge, MergeAction, MergeClause, MergeClauseKind, MergeInsertExpr,
@@ -4077,6 +4077,7 @@ pub enum Statement {
     /// Note: this is a PostgreSQL-specific statement.
     /// <https://www.postgresql.org/docs/current/sql-createrule.html>
     CreateRule(CreateRule),
+    /// ```sql
     /// CREATE STATISTICS [ IF NOT EXISTS ] name [ ( kind [, ...] ) ] ON expr [, ...] FROM table_name
     /// ```
     /// Note: this is a PostgreSQL-specific statement.

src/ast/spans.rs

@@ -1187,8 +1187,6 @@ impl Spanned for AlterTableOperation {
             AlterTableOperation::EnableReplicaRule { name } => name.span,
             AlterTableOperation::EnableReplicaTrigger { name } => name.span,
             AlterTableOperation::EnableRowLevelSecurity => Span::empty(),
-            AlterTableOperation::ForceRowLevelSecurity => Span::empty(),
-            AlterTableOperation::NoForceRowLevelSecurity => Span::empty(),
             AlterTableOperation::EnableRule { name } => name.span,
             AlterTableOperation::EnableTrigger { name } => name.span,
             AlterTableOperation::RenamePartitions {

src/ast/table_constraints.rs

@@ -26,7 +26,7 @@ use crate::tokenizer::Span;
 use core::fmt;
 
 #[cfg(not(feature = "std"))]
-use alloc::{boxed::Box, vec::Vec};
+use alloc::{boxed::Box, string::String, vec::Vec};
 
 #[cfg(feature = "serde")]
 use serde::{Deserialize, Serialize};

src/keywords.rs

@@ -246,9 +246,9 @@ define_keywords!(
     COMPRESSION,
     COMPUPDATE,
     COMPUTE,
-    CONFIGURATION,
     CONCURRENTLY,
     CONDITION,
+    CONFIGURATION,
     CONFLICT,
     CONNECT,
     CONNECTION,
@@ -514,7 +514,6 @@ define_keywords!(
     IN,
     INCLUDE,
     INCLUDE_NULL_VALUES,
-    INLINE,
     INCLUDING,
     INCREMENT,
     INCREMENTAL,
@@ -524,6 +523,7 @@ define_keywords!(
     INHERITS,
     INITIALIZE,
     INITIALLY,
+    INLINE,
     INNER,
     INOUT,
     INPATH,
@@ -1082,8 +1082,8 @@ define_keywords!(
     TRAILING,
     TRAN,
     TRANSACTION,
-    TRANSIENT,
     TRANSFORM,
+    TRANSIENT,
     TRANSLATE,
     TRANSLATE_REGEX,
     TRANSLATION,