Core: Smart select better check for required View

nolimits4web · nolimits4web · commit a39b700da339 · 2018-06-07T21:11:05.000+03:00
diff --git a/src/core/components/smart-select/smart-select-class.js b/src/core/components/smart-select/smart-select-class.js
@@ -34,7 +34,7 @@ class SmartSelect extends Framework7Class {
     if (!view) {
       view = $el.parents('.view').length && $el.parents('.view')[0].f7View;
     }
-    if (!view) {
+    if (!view && (params.openIn === 'page' || (params.openIn !== 'page' && params.routableModals === true))) {
       throw Error('Smart Select requires initialized View');
     }
 

Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ class SmartSelect extends Framework7Class {`
`34`	`34`	`if (!view) {`
`35`	`35`	`view = $el.parents('.view').length && $el.parents('.view')[0].f7View;`
`36`	`36`	`}`
`37`		`- if (!view) {`
	`37`	`+ if (!view && (params.openIn === 'page' \|\| (params.openIn !== 'page' && params.routableModals === true))) {`
`38`	`38`	`throw Error('Smart Select requires initialized View');`
`39`	`39`	`}`
`40`	`40`