Merge pull request #4 from jkaddo91/getcountries-perf-improvement

GetCountries performance improvement

Author: Seesi

CountryData.Standard.csproj

@@ -8,6 +8,9 @@
     <RepositoryUrl>https://github.com/frankodoom/CountryData.Standard</RepositoryUrl>
     <PackageTags>Xamarin, Country-Api Country-Data Country-Region</PackageTags>
     <NeutralLanguage />
+    <Version>1.0.1</Version>
+    <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
+    <PackageLicenseExpression>MIT</PackageLicenseExpression>
   </PropertyGroup>
 
   <ItemGroup>

CountryHelper.cs

@@ -69,17 +69,8 @@ public List<Regions> GetRegionByCountryCode(string ShortCode)
         /// <summary>
         /// Gets the list of all countries in the worlld
         /// </summary>
-        /// <returns>List<String> countries</returns>
-        public List<String> GetCountries()
-        {
-            List<String> data = new List<string>();
-            var countries = _Countries.Select(c => c.CountryName).ToList();
-            foreach (var item in countries)
-            {
-                data.Add(item);
-            }
-            return countries;
-        }
+        /// <returns>IEnumerable<string> countries</returns>
+        public IEnumerable<string> GetCountries() => _Countries.Select(c => c.CountryName);
 
     }
 }

README.md

@@ -1,5 +1,11 @@
 # CountryData.Standard
-:earth_africa: A simple cross platform offline .NET library for getting Global Country Data
+:earth_africa: A simple cross platform offline .NET library for getting Global Country Data without making any HTTP calls.
+
+
+### Install Library
+```cSharp
+   PM> Install-Package CountryData.Standard -Version 1.0.1
+```
 
 
 ### Initialize the Country data object
@@ -53,13 +59,14 @@
 ### Comming Soon
 * Support for more ISO Standard Country Data
 * Support for ISO 3166 Country A3 Codes
+* Support for Country Phone Code
 * Country ShortCode Enums
 
 
 ```
 The MIT License
 
-Copyright (c) 2019 Frank Odoom
+Copyright (c) 2019 Accede Ltd.
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

azure-pipelines.yml

@@ -0,0 +1,26 @@
+# Starter pipeline
+# Start with a minimal pipeline that you can customize to build and deploy your code.
+# Add steps that build, run tests, deploy, and more:
+# https://aka.ms/yaml
+
+trigger:
+- master
+
+pool:
+  vmImage: 'ubuntu-latest'
+
+steps:
+ - task: DotNetCoreCLI@2
+   inputs:
+     command: 'restore'
+     projects: '**/*.csproj'
+     feedsToUse: 'select'
+
+
+- task: DotNetCoreCLI@2
+  displayName: Build
+  inputs:
+    command: build
+    projects: '**/*.csproj'
+    arguments: '--configuration Release' # Update this to match your need
+

bin/Debug/CountryData.Standard.1.0.0.nupkg

@@ -1,37 +1,33 @@
 {
   "format": 1,
   "restore": {
-    "C:\\Users\\u\\Documents\\CountryData.Standard\\CountryData.Standard.csproj": {}
+    "C:\\Users\\FrankOdoom\\Desktop\\Labs\\open-source\\CountryData.Standard\\CountryData.Standard.csproj": {}
   },
   "projects": {
-    "C:\\Users\\u\\Documents\\CountryData.Standard\\CountryData.Standard.csproj": {
-      "version": "1.0.0",
+    "C:\\Users\\FrankOdoom\\Desktop\\Labs\\open-source\\CountryData.Standard\\CountryData.Standard.csproj": {
+      "version": "1.0.1",
       "restore": {
-        "projectUniqueName": "C:\\Users\\u\\Documents\\CountryData.Standard\\CountryData.Standard.csproj",
+        "projectUniqueName": "C:\\Users\\FrankOdoom\\Desktop\\Labs\\open-source\\CountryData.Standard\\CountryData.Standard.csproj",
         "projectName": "CountryData.Standard",
-        "projectPath": "C:\\Users\\u\\Documents\\CountryData.Standard\\CountryData.Standard.csproj",
-        "packagesPath": "C:\\Users\\u\\.nuget\\packages\\",
-        "outputPath": "C:\\Users\\u\\Documents\\CountryData.Standard\\obj\\",
+        "projectPath": "C:\\Users\\FrankOdoom\\Desktop\\Labs\\open-source\\CountryData.Standard\\CountryData.Standard.csproj",
+        "packagesPath": "C:\\Users\\FrankOdoom\\.nuget\\packages\\",
+        "outputPath": "C:\\Users\\FrankOdoom\\Desktop\\Labs\\open-source\\CountryData.Standard\\obj\\",
         "projectStyle": "PackageReference",
         "fallbackFolders": [
           "C:\\Microsoft\\Xamarin\\NuGet\\",
           "C:\\Program Files\\dotnet\\sdk\\NuGetFallbackFolder"
         ],
         "configFilePaths": [
-          "C:\\Users\\u\\AppData\\Roaming\\NuGet\\NuGet.Config",
-          "C:\\Program Files (x86)\\NuGet\\Config\\DevExpress 18.2.config",
+          "C:\\Users\\FrankOdoom\\AppData\\Roaming\\NuGet\\NuGet.Config",
           "C:\\Program Files (x86)\\NuGet\\Config\\Microsoft.VisualStudio.Offline.config",
           "C:\\Program Files (x86)\\NuGet\\Config\\Xamarin.Offline.config"
         ],
         "originalTargetFrameworks": [
           "netstandard2.0"
         ],
         "sources": {
-          "C:\\Program Files (x86)\\DevExpress 18.2\\Components\\System\\Components\\Packages": {},
           "C:\\Program Files (x86)\\Microsoft SDKs\\NuGetPackages\\": {},
-          "https://accededevteam.pkgs.visualstudio.com/_packaging/DevFeed/nuget/v3/index.json": {},
-          "https://api.nuget.org/v3/index.json": {},
-          "https://nuget.devexpress.com/v7aYrEMVJxPS3BWcMo5ijD2svwwknYzijrVJobwGmBBmpVlJq2/api": {}
+          "https://api.nuget.org/v3/index.json": {}
         },
         "frameworks": {
           "netstandard2.0": {

obj/CountryData.Standard.csproj.nuget.dgspec.json

@@ -5,7 +5,7 @@
     <RestoreTool Condition=" '$(RestoreTool)' == '' ">NuGet</RestoreTool>
     <ProjectAssetsFile Condition=" '$(ProjectAssetsFile)' == '' ">$(MSBuildThisFileDirectory)project.assets.json</ProjectAssetsFile>
     <NuGetPackageRoot Condition=" '$(NuGetPackageRoot)' == '' ">$(UserProfile)\.nuget\packages\</NuGetPackageRoot>
-    <NuGetPackageFolders Condition=" '$(NuGetPackageFolders)' == '' ">C:\Users\u\.nuget\packages\;C:\Microsoft\Xamarin\NuGet\;C:\Program Files\dotnet\sdk\NuGetFallbackFolder</NuGetPackageFolders>
+    <NuGetPackageFolders Condition=" '$(NuGetPackageFolders)' == '' ">C:\Users\FrankOdoom\.nuget\packages\;C:\Microsoft\Xamarin\NuGet\;C:\Program Files\dotnet\sdk\NuGetFallbackFolder</NuGetPackageFolders>
     <NuGetProjectStyle Condition=" '$(NuGetProjectStyle)' == '' ">PackageReference</NuGetProjectStyle>
     <NuGetToolVersion Condition=" '$(NuGetToolVersion)' == '' ">5.3.1</NuGetToolVersion>
   </PropertyGroup>

obj/CountryData.Standard.csproj.nuget.g.props

@@ -4,6 +4,6 @@
     <MSBuildAllProjects>$(MSBuildAllProjects);$(MSBuildThisFileFullPath)</MSBuildAllProjects>
   </PropertyGroup>
   <ImportGroup Condition=" '$(ExcludeRestorePackageImports)' != 'true' ">
-    <Import Project="C:\Program Files\dotnet\sdk\NuGetFallbackFolder\netstandard.library\2.0.3\build\netstandard2.0\NETStandard.Library.targets" Condition="Exists('C:\Program Files\dotnet\sdk\NuGetFallbackFolder\netstandard.library\2.0.3\build\netstandard2.0\NETStandard.Library.targets')" />
+    <Import Project="$(NuGetPackageRoot)netstandard.library\2.0.3\build\netstandard2.0\NETStandard.Library.targets" Condition="Exists('$(NuGetPackageRoot)netstandard.library\2.0.3\build\netstandard2.0\NETStandard.Library.targets')" />
   </ImportGroup>
 </Project>

obj/CountryData.Standard.csproj.nuget.g.targets

@@ -6,3 +6,11 @@ C:\Users\FrankOdoom\source\repos\Country.Data.Standard\Country.Data.Standard\obj
 C:\Users\FrankOdoom\source\repos\Country.Data.Standard\Country.Data.Standard\obj\Debug\netstandard2.0\CountryData.Standard.AssemblyInfo.cs
 C:\Users\FrankOdoom\source\repos\Country.Data.Standard\Country.Data.Standard\obj\Debug\netstandard2.0\CountryData.Standard.dll
 C:\Users\FrankOdoom\source\repos\Country.Data.Standard\Country.Data.Standard\obj\Debug\netstandard2.0\CountryData.Standard.pdb
+C:\Users\FrankOdoom\Desktop\Labs\open-source\CountryData.Standard\bin\Debug\netstandard2.0\CountryData.Standard.deps.json
+C:\Users\FrankOdoom\Desktop\Labs\open-source\CountryData.Standard\bin\Debug\netstandard2.0\CountryData.Standard.dll
+C:\Users\FrankOdoom\Desktop\Labs\open-source\CountryData.Standard\bin\Debug\netstandard2.0\CountryData.Standard.pdb
+C:\Users\FrankOdoom\Desktop\Labs\open-source\CountryData.Standard\obj\Debug\netstandard2.0\CountryData.Standard.csprojAssemblyReference.cache
+C:\Users\FrankOdoom\Desktop\Labs\open-source\CountryData.Standard\obj\Debug\netstandard2.0\CountryData.Standard.AssemblyInfoInputs.cache
+C:\Users\FrankOdoom\Desktop\Labs\open-source\CountryData.Standard\obj\Debug\netstandard2.0\CountryData.Standard.AssemblyInfo.cs
+C:\Users\FrankOdoom\Desktop\Labs\open-source\CountryData.Standard\obj\Debug\netstandard2.0\CountryData.Standard.dll
+C:\Users\FrankOdoom\Desktop\Labs\open-source\CountryData.Standard\obj\Debug\netstandard2.0\CountryData.Standard.pdb