Skip to content

Commit a969de1

Browse files
committed
Remove FJ affinity option from benchmark runner
1 parent 66a9e5d commit a969de1

3 files changed

Lines changed: 1 addition & 10 deletions

File tree

benchmark-runner/README.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,6 @@ Run `./run-benchmark.sh --help` for the full list.
6262
| `--io` | `SERVER_IO` | epoll | I/O type: epoll, nio, io_uring |
6363
| `--poller-mode` | `SERVER_POLLER_MODE` | | jdk.pollerMode: 1, 2, or 3 |
6464
| `--fj-parallelism` | `SERVER_FJ_PARALLELISM` | | ForkJoinPool parallelism |
65-
| `--fj-affinity` | `SERVER_FJ_AFFINITY` | false | FJ scheduler affinity |
6665
| `--server-cpuset` | `SERVER_CPUSET` | 2,3 | CPU pinning |
6766
| `--jvm-args` | `SERVER_JVM_ARGS` | | Additional JVM arguments |
6867

benchmark-runner/scripts/run-benchmark.sh

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ SERVER_CPUSET="${SERVER_CPUSET:-2,3}" # CPUs for handoff server
3535
SERVER_JVM_ARGS="${SERVER_JVM_ARGS:-}"
3636
SERVER_POLLER_MODE="${SERVER_POLLER_MODE:-}" # jdk.pollerMode value (1, 2, or 3); empty = JVM default, NETTY_SCHEDULER defaults to 3
3737
SERVER_FJ_PARALLELISM="${SERVER_FJ_PARALLELISM:-}" # ForkJoinPool parallelism (empty = JVM default)
38-
SERVER_FJ_AFFINITY="${SERVER_FJ_AFFINITY:-false}" # ForkJoinPool virtual thread scheduler affinity
3938
SERVER_MODE="${SERVER_MODE:-NON_VIRTUAL_NETTY}" # Server mode: NON_VIRTUAL_NETTY, REACTIVE, VIRTUAL_NETTY
4039
SERVER_MOCKLESS="${SERVER_MOCKLESS:-false}" # Skip mock server; do Jackson work inline
4140

@@ -402,8 +401,6 @@ start_handoff_server() {
402401
jvm_args="$jvm_args -Djdk.virtualThreadScheduler.parallelism=$SERVER_FJ_PARALLELISM"
403402
fi
404403

405-
jvm_args="$jvm_args -Djdk.virtualThreadScheduler.affinity=$SERVER_FJ_AFFINITY"
406-
407404
# Add debug non-safepoints if profiling is enabled
408405
if [[ "$ENABLE_PROFILER" == "true" ]]; then
409406
jvm_args="$jvm_args -XX:+UnlockDiagnosticVMOptions"
@@ -723,7 +720,6 @@ print_config() {
723720
log " I/O Type: $SERVER_IO"
724721
log " Poller Mode: $SERVER_POLLER_MODE"
725722
log " FJ Parallelism: ${SERVER_FJ_PARALLELISM:-<default>}"
726-
log " FJ Affinity: $SERVER_FJ_AFFINITY"
727723
log " CPU Affinity: ${SERVER_CPUSET:-<none>}"
728724
log " Extra JVM Args: ${SERVER_JVM_ARGS:-<none>}"
729725
log ""
@@ -794,7 +790,6 @@ main() {
794790
--io) SERVER_IO="$2"; shift 2 ;;
795791
--poller-mode) SERVER_POLLER_MODE="$2"; shift 2 ;;
796792
--fj-parallelism) SERVER_FJ_PARALLELISM="$2"; shift 2 ;;
797-
--fj-affinity) SERVER_FJ_AFFINITY=true; shift ;;
798793
--server-cpuset) SERVER_CPUSET="$2"; shift 2 ;;
799794
--jvm-args) SERVER_JVM_ARGS="$2"; shift 2 ;;
800795
# Mock
@@ -840,7 +835,6 @@ Server:
840835
--io <type> I/O type: epoll, nio, io_uring (SERVER_IO, default: epoll)
841836
--poller-mode <n> jdk.pollerMode: 1, 2, or 3 (SERVER_POLLER_MODE)
842837
--fj-parallelism <n> ForkJoinPool parallelism (SERVER_FJ_PARALLELISM)
843-
--fj-affinity Enable FJ scheduler affinity (SERVER_FJ_AFFINITY)
844838
--server-cpuset <cpus> Server CPU pinning, e.g. "2,3" (SERVER_CPUSET, default: 2,3)
845839
--jvm-args <args> Additional JVM arguments (SERVER_JVM_ARGS)
846840

benchmark-runner/src/test/java/io/netty/loom/benchmark/runner/BenchmarkIntegrationTest.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,7 @@
3636
* <p>
3737
* Tests cover:
3838
* <ul>
39-
* <li>NIO I/O with affinity mode</li>
40-
* <li>NIO I/O with manual (no affinity) mode</li>
41-
* <li>NIO I/O with inherit locality mode</li>
39+
* <li>NIO I/O with virtual Netty mode</li>
4240
* </ul>
4341
*/
4442
class BenchmarkIntegrationTest {

0 commit comments

Comments
 (0)