[Repo Assist] Fix script warnings and add CheckDocScripts to Verify pipeline (#1083)

* Fix script warnings and add CheckDocScripts to Verify pipeline

- Fix FS0760 IDisposable warnings in docs/evaluation.fsx by using
  'new FsiEvaluator()' constructor syntax (two occurrences)
- Improve error message in ParseScript when type errors are found
  in a script file (now includes the file path)
- Add CheckDocScripts stage to the Verify pipeline in build.fsx so
  that 'dotnet fsi build.fsx -- -p Verify' also type-checks docs
  scripts with --strict, catching errors locally before CI

The full CI pipeline already ran 'fsdocs build --strict' in the
GenerateDocs stage (permanent check). The new CheckDocScripts stage
makes the same check available via the lighter-weight Verify pipeline.

Closes #1081

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* ci: trigger checks

* feat: run CheckDocScripts stage on Windows too

Remove the 'whenNot Windows' guard and use System.OperatingSystem.IsWindows()
to select the correct binary extension (fsdocs.exe on Windows, fsdocs on Unix).
This means the Verify pipeline now type-checks documentation scripts on all
platforms.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* ci: trigger checks

* build: add CheckDocScripts to CI pipeline

Move fsdocsLocalBin/checkDocScriptsStage definitions before the CI
pipeline and include the stage in CI (after Tests, before GenerateDocs).
This ensures doc-script type errors are caught on all CI runners, not
only when running the Verify pipeline locally.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* ci: trigger checks

* chore: remove changelog entries from RELEASE_NOTES.md

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* ci: trigger checks

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: github-actions[bot]

build.fsx

@@ -49,6 +49,17 @@ let testStage =
             $"dotnet test {solutionFile} --configuration {configuration} --no-build --blame --logger trx --results-directory TestResults -tl"
     }
 
+// Standalone doc-script type-check using the locally built fsdocs tool.
+// Assumes the solution has been built (e.g. after running the CI pipeline or
+// `dotnet build`). Catches type errors in .fsx documentation sources early,
+// matching the `--strict` check in the full GenerateDocs stage.
+let fsdocsLocalBin =
+    let ext = if System.OperatingSystem.IsWindows() then ".exe" else ""
+    $"src/fsdocs-tool/bin/Release/net10.0/fsdocs{ext}"
+
+let checkDocScriptsStage =
+    stage "CheckDocScripts" { run $"\"{fsdocsLocalBin}\" build --strict --clean --properties Configuration=Release" }
+
 pipeline "CI" {
     lintStage
 
@@ -68,6 +79,8 @@ pipeline "CI" {
 
     testStage
 
+    checkDocScriptsStage
+
     stage "GenerateDocs" {
         // Skip on Windows CI runners: docs are only deployed from Linux
         whenNot { envVar "RUNNER_OS" "Windows" }
@@ -92,6 +105,7 @@ pipeline "Verify" {
     lintStage
     testStage
     stage "Analyzers" { run "dotnet msbuild /t:AnalyzeSolution" }
+    checkDocScriptsStage
     runIfOnlySpecified true
 }
 

docs/evaluation.fsx

@@ -158,7 +158,7 @@ let a = 10
 (*** include-value:a ***)"""
 
 // Create evaluator and parse script
-let fsi = FsiEvaluator()
+let fsi = new FsiEvaluator()
 
 let doc = Literate.ParseScriptString(content, fsiEvaluator = fsi)
 
@@ -192,7 +192,7 @@ This can be done by calling `cref:M:FSharp.Formatting.Literate.Evaluation.FsiEva
 
 *)
 // Create evaluator & register simple formatter for lists
-let fsiEvaluator = FsiEvaluator()
+let fsiEvaluator = new FsiEvaluator()
 
 fsiEvaluator.RegisterTransformation(fun (o, ty, _executionCount) ->
     // If the type of value is an F# list, format it nicely

src/FSharp.Formatting.Literate/ParseScript.fs

@@ -370,14 +370,14 @@ type internal ParseScript(parseOptions, ctx: CompilerContext) =
         let sourceSnippets, diagnostics =
             CodeFormatter.ParseAndCheckSource(filePath, content, ctx.CompilerOptions, defines, onError)
 
-        let mutable fail = false
+        let mutable hasErrors = false
 
         for (SourceError((l0, c0), (l1, c1), kind, msg)) in diagnostics do
             printfn
                 "   %s: %s(%d,%d)-(%d,%d) %s"
                 filePath
                 (if kind = ErrorKind.Error then
-                     fail <- true
+                     hasErrors <- true
                      "error"
                  else
                      "warning")
@@ -387,8 +387,8 @@ type internal ParseScript(parseOptions, ctx: CompilerContext) =
                 c1
                 msg
 
-        if fail then
-            ctx.OnError "errors parsing or checking script"
+        if hasErrors then
+            ctx.OnError(sprintf "errors found in '%s'" filePath)
 
         let parsedBlocks =
             [ for Snippet(name, lines) in sourceSnippets do