fix: 🐛 Fix rounding errors

Author: robvanderleek

codelimit/common/report/Report.py

@@ -43,14 +43,14 @@ def all_report_units_sorted_by_length_asc(self, threshold=0) -> list[ReportUnit]
         result = sorted(result, key=lambda unit: unit.measurement.value, reverse=True)
         return result
 
-    def quality_profile(self):
+    def quality_profile(self) -> list[int]:
         return make_profile(self.codebase.all_measurements())
 
     def quality_profile_percentage(self):
         profile = self.quality_profile()
         total = sum(profile)
-        unmaintainable = ceil((profile[3] / total) * 100) if total > 0 else 0
-        hard_to_maintain = ceil((profile[2] / total) * 100) if total > 0 else 0
-        verbose = ceil((profile[1] / total) * 100) if total > 0 else 0
+        unmaintainable = ceil((profile[3] / total) * 100 - 0.001) if total > 0 else 0
+        hard_to_maintain = ceil((profile[2] / total) * 100 - 0.001) if total > 0 else 0
+        verbose = ceil((profile[1] / total) * 100 - 0.001) if total > 0 else 0
         easy = 100 - unmaintainable - hard_to_maintain - verbose
         return easy, verbose, hard_to_maintain, unmaintainable

tests/common/report/test_Report.py

@@ -18,6 +18,14 @@ def test_quality_profile_percentage():
     assert report.quality_profile_percentage() == (100, 0, 0, 0)
 
 
+def test_quality_profile_percentage_rounding():
+    report = Report(Codebase("/"))
+    report.quality_profile = lambda: [2530, 2883, 1395, 0]
+    assert report.quality_profile_percentage() == (36, 43, 21, 0)
+
+    report.quality_profile = lambda: [630, 300, 70, 0]
+    assert report.quality_profile_percentage() == (63, 30, 7, 0)
+
 def test_all_units():
     codebase = Codebase("/")
     codebase.add_file(