Skip to content

Commit 332e6e2

Browse files
authored
Merge pull request #340 from gitpod-io/wv/drop-test-pause-spans
fix: drop test.paused/test.continued spans from test tracing
2 parents aa69503 + 3fbc943 commit 332e6e2

File tree

2 files changed

+10
-42
lines changed

2 files changed

+10
-42
lines changed

pkg/leeway/gotest_trace.go

Lines changed: 3 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -133,10 +133,9 @@ func (t *GoTestTracer) handleEvent(event *goTestEvent) {
133133
switch event.Action {
134134
case "run":
135135
t.handleRun(event)
136-
case "pause":
137-
t.handlePause(event)
138-
case "cont":
139-
t.handleCont(event)
136+
case "pause", "cont":
137+
// Intentionally dropped: these events generate high-volume spans
138+
// (test.paused/test.continued) with no diagnostic value.
140139
case "pass", "fail", "skip":
141140
t.handleEnd(event)
142141
case "output":
@@ -205,36 +204,6 @@ func (t *GoTestTracer) handlePackageStart(event *goTestEvent) {
205204
t.spans[key] = &testSpanData{span: span}
206205
}
207206

208-
// handlePause records that a test was paused (for t.Parallel())
209-
func (t *GoTestTracer) handlePause(event *goTestEvent) {
210-
if event.Test == "" {
211-
return
212-
}
213-
214-
t.mu.Lock()
215-
defer t.mu.Unlock()
216-
217-
key := spanKey(event.Package, event.Test)
218-
if data, ok := t.spans[key]; ok {
219-
data.span.AddEvent("test.paused", trace.WithTimestamp(event.Time))
220-
}
221-
}
222-
223-
// handleCont records that a paused test continued
224-
func (t *GoTestTracer) handleCont(event *goTestEvent) {
225-
if event.Test == "" {
226-
return
227-
}
228-
229-
t.mu.Lock()
230-
defer t.mu.Unlock()
231-
232-
key := spanKey(event.Package, event.Test)
233-
if data, ok := t.spans[key]; ok {
234-
data.span.AddEvent("test.continued", trace.WithTimestamp(event.Time))
235-
}
236-
}
237-
238207
// handleEnd ends a span for a completed test
239208
func (t *GoTestTracer) handleEnd(event *goTestEvent) {
240209
t.mu.Lock()

pkg/leeway/gotest_trace_test.go

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -154,14 +154,13 @@ func TestGoTestTracer_ParallelTests(t *testing.T) {
154154
t.Fatal("TestParallel span not found")
155155
}
156156

157-
// Verify pause and cont events were recorded
158-
eventNames := make([]string, 0)
159-
for _, e := range testSpan.Events {
160-
eventNames = append(eventNames, e.Name)
161-
}
162-
163-
if len(eventNames) != 2 {
164-
t.Errorf("expected 2 events (pause, cont), got %d: %v", len(eventNames), eventNames)
157+
// Verify pause and cont events are NOT recorded (dropped to reduce span volume)
158+
if len(testSpan.Events) != 0 {
159+
eventNames := make([]string, 0, len(testSpan.Events))
160+
for _, e := range testSpan.Events {
161+
eventNames = append(eventNames, e.Name)
162+
}
163+
t.Errorf("expected 0 events (pause/cont dropped), got %d: %v", len(testSpan.Events), eventNames)
165164
}
166165
}
167166

0 commit comments

Comments
 (0)