Properly specify the STATIC_CRT libgit2 flag

Faless · Faless · commit c7c78221911d · 2025-05-27T11:53:22.000+02:00
libgit2 CMake configuration uses a custom flag `STATIC_CRT` and not the
new CMake policy CMP0091.

When forcing the CMake policy (as we do in our cmake tool), we need to
also set the custom `STATIC_CRT` to avoid compiler warning about the /MD
and /MT flag being overridden.
diff --git a/tools/git2.py b/tools/git2.py
@@ -26,7 +26,7 @@ def build_library(env, deps):
         "LIBSSH2_INCLUDE_DIR": env.Dir("#thirdparty/ssh2/libssh2/include").abspath,
         "LIBSSH2_LIBRARY": deps[-1],
         "USE_WINHTTP": 0,
-        "STATIC_CRT": 0,
+        "STATIC_CRT": env.get("use_static_cpp", True),
     }
 
     if env["platform"] != "windows":

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ def build_library(env, deps):`
`26`	`26`	`"LIBSSH2_INCLUDE_DIR": env.Dir("#thirdparty/ssh2/libssh2/include").abspath,`
`27`	`27`	`"LIBSSH2_LIBRARY": deps[-1],`
`28`	`28`	`"USE_WINHTTP": 0,`
`29`		`- "STATIC_CRT": 0,`
	`29`	`+ "STATIC_CRT": env.get("use_static_cpp", True),`
`30`	`30`	`}`
`31`	`31`
`32`	`32`	`if env["platform"] != "windows":`